[Bug 8420] New: tool statisticfines.pl(bz 6858) and hourly loan(bz5549)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8420 Priority: P5 - low Change sponsored?: --- Bug ID: 8420 CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: tool statisticfines.pl(bz 6858) and hourly loan(bz5549) Severity: enhancement Classification: Unclassified OS: All Reporter: stephane.delaye@biblibre.com Hardware: All Status: NEW Version: rel_3_8 Component: Circulation Product: Koha the tool statisticfines.pl (bz 6858) and the hourly loan (bz5549) are not compatible. statisticfines control date_due with this format : AAAA-MM-JJ and hourly loan have change the format date with the hour AAAA-MM-JJ HH:MM:SS so when i want use statisticfines.pl i have this error message datedue_days: Skipping at staticfines.pl line 159. Illegal date specified (year = 0, month = 0, day = 00) at staticfines.pl line 155 Error on date for borrower 4706: Date::Calc::Date_to_Days(): not a valid date at staticfines.pl line 156. date_due: 0000-00-00 00:00:00 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8420 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 CC| |fridolyn.somers@biblibre.co | |m Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8420 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6858, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5549 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8420 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |fridolyn.somers@biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 11838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11838&action=edit Proposed patch Proposed patch. The main change is the use of Koha::DateUtils::dt_from_string to use DateTime objects in fine computing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8420 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #2 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Delaye Stephane <stephane.delaye@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8420 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11838|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8420 --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 11844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11844&action=edit Bug 8420: tool statisticfines.pl and hourly loan Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8420 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com Version|rel_3_8 |master QA Contact| |mtj@kohaaloha.com --- Comment #4 from Mason James <mtj@kohaaloha.com> ---
Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com>
looks good, passing QA... i've changed version from 3.8 to master $ koha-qa.pl testing 1 commit(s) (applied to commit 60790d0) * e0debe5 Bug 8420: tool statisticfines.pl and hourly loan misc/cronjobs/staticfines.pl * misc/cronjobs/staticfines.pl OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8420 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master Very local fix to a cron job. Even if the patch is written & signed-off by BibLibre, no side-effect risk at all, i've pushed it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8420 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Doesn't apply cleanly to 3.8.x, please supply a patch for it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8420 --- Comment #7 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 12271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12271&action=edit Proposed patch (for 3.8.X) Rebased patch for 3.8.X version. Only one existing line is different form master version. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8420 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org