[Bug 17536] New: Remove Duplication of receipting code in EDI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17536 Bug ID: 17536 Summary: Remove Duplication of receipting code in EDI Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campbell@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org When the Current Koha/EDI.pm was written the api to Acquisitions::ModReceiveOrder was unstable as a result the process was duplicated in Koha::EDI as the interface has stabilised EDI should revert to using the Acquisitions interface and remove the duplicate code. This should guard against bugs from incompatibilities and allow it to take advantage of enhancements in C4::acquisitions (e.g. new handling of Standing Orders) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17536 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com Status|NEW |Needs Signoff --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 57071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57071&action=edit Proposed patch This patch removes the code which duplicated functionality from C4::Acquisitions and instead calls ModReceiveOrder. Removes potential divergencies from the two paths. Koha::EDI now only required to load data provided by the GIR segment in the invoice. This removes some anomalies which caused partial receipts to sometimes skip adding a barcode to some items (if supplier applies barcodes) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17536 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Looking at a small change to this patch to eliminate an unnecssary warning -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17536 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7736 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 [Bug 7736] Edifact QUOTE and ORDER functionality -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17536 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like this patch was never finished. Should we reset to NEW/unassigned? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17536 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|colin.campbell@ptfs-europe. |martin.renvoize@ptfs-europe |com |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17536 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'll take a look, see if I can work out what was being done here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17536 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |WISHLIST -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org