[Bug 29450] New: Allow flatPickr to instantiate in any order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29450 Bug ID: 29450 Summary: Allow flatPickr to instantiate in any order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Currently, we automatically instantiate a flatPickr instance for any input fields that have the flatpickr class. This instantiation is handling within a loop and works well in most cases. However, if the the input is paired so we have a start/end date pair and the start date is pre-populated with the template you are faced with javascript errors. This is because the pre-populated value triggers our onClose function that resides in the instantiation settings. The onClose looks for the associated 'end' input and grabs the flatpickr instance to set the minDate property.. but as we've not yet hit the end input field the flatpicker instance for that field doesn't yet exist. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29450 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127507&action=edit Bug 29450: Allow flatpickr to instantiate in any order This patch updates the flatpickr wrapper code to allow for cases where the startdate/enddate pickers are pre-populated and thus the onClose event of the startdate pickr may be fired before the enddate flatpickr is instantiated.. which leads to an error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29450 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29450 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29450 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29450 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127507|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127621&action=edit Bug 29450: Allow flatpickr to instantiate in any order This patch updates the flatpickr wrapper code to allow for cases where the startdate/enddate pickers are pre-populated and thus the onClose event of the startdate pickr may be fired before the enddate flatpickr is instantiated.. which leads to an error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29450 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Removed a console.log statement I errantly left in.. otherwise, latest patch matches the previous upload. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29450 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Can you remember where you observed this bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29450 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Martin, could you please add a test plan for this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29450 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29002 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29450 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #5)
Hi Martin, could you please add a test plan for this?
Ping! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29450 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|Failed QA |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org