[Bug 15472] New: Do not display links to circulation.pl if remaining_permissions is not set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472 Bug ID: 15472 Summary: Do not display links to circulation.pl if remaining_permissions is not set Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If permisison 'remaining_permissions' is not set, links to 'Circulation' (/circ/circulation-home.pl) lead to an error message (Error: You do not have permission to access this page). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 46265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46265&action=edit Bug 15472: Do not display links to circulation.pl if remaining_permissions is not set If permission 'circulate_remaining_permissions' is not set, links to 'Circulation' (/circ/circulation-home.pl) on the intranet home page lead to an error message: "Error: You do not have permission to access this page." This patch hides the links if the permission is not set. To test: - Apply patch - Log in to the intranet (staff client) with a patron who has the permission 'circulate_remaining_pernissions' not set - Verify that no links to Circulation appear on the intranet start page (menu top left and menu in main page area) - Log in as a user who has the permission set. - Verify that te links appear as appropriate. http://bugs.koha-community.org/show_bug.cgi?id=15442 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Good catch, Marc. If I want a staff patron has only access to one or two granular permissions, e.g., self_checkout, the System displays the circulation links. If patron clicks in one of the links, the program logs out the user and is presented with the error message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46265|0 |1 is obsolete| | --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 46499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46499&action=edit [SIGNED-OFF]Bug 15472: Do not display links to circulation.pl if remaining_permissions is not set If permission 'circulate_remaining_permissions' is not set, links to 'Circulation' (/circ/circulation-home.pl) on the intranet home page lead to an error message: "Error: You do not have permission to access this page." This patch hides the links if the permission is not set. To test: - Apply patch - Log in to the intranet (staff client) with a patron who has the permission 'circulate_remaining_pernissions' not set - Verify that no links to Circulation appear on the intranet start page (menu top left and menu in main page area) - Log in as a user who has the permission set. - Verify that te links appear as appropriate. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46499|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46577&action=edit Bug 15472: Do not display links to circulation.pl if remaining_permissions is not set If permission 'circulate_remaining_permissions' is not set, links to 'Circulation' (/circ/circulation-home.pl) on the intranet home page lead to an error message: "Error: You do not have permission to access this page." This patch hides the links if the permission is not set. To test: - Apply patch - Log in to the intranet (staff client) with a patron who has the permission 'circulate_remaining_pernissions' not set - Verify that no links to Circulation appear on the intranet start page (menu top left and menu in main page area) - Log in as a user who has the permission set. - Verify that te links appear as appropriate. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org