[Bug 5501] New: why is there a 'do not notify' option?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 Summary: why is there a 'do not notify' option? Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 Component: Patrons AssignedTo: kyle.m.hall@gmail.com ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Estimated Hours: 0.0 When looking at the enhanced messages for patrons there is a 'do not notify' option - which is basically the same as not checking any messaging choices - so why do we need that option at all? I recommend removing it since it's confusing. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- This still confuses people in training. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 Danielle Elder <danielle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle@bywatersolutions.c | |om --- Comment #2 from Danielle Elder <danielle@bywatersolutions.com> --- Libraries still reporting confusion over this feature. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti@jns.fi --- Comment #3 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- We have confusion as well. The worst thing is that it actually doesn't do what it says. We still have print messages even if the "do not notify"-option is used. Looking into adding a new message-transport-type "do not notify" used to catch that. So instead of clicking an "clear"-button in the GUI we actually select a viable transport alternative overriding message sending behaviour. Sometimes the message_transport_type defaults to print if no transport is defined. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 --- Comment #4 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 35413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35413&action=edit Bug 5501 - Improve the 'do not notify' option Introducing the message_transport_type 'none' and enabling it for all messages. Enabling print-option for "HOLD Fulfilled". Print option can be added for other messages as well, but HOLD seems to make the most sense. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|why is there a 'do not |Improve the 'do not notify' |notify' option? |option -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 --- Comment #5 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 35414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35414&action=edit Bug 5501 - Improve the 'do not notify' option. HOLD-letter. TEST PLAN: 1. Find a Borrower and edit "Patron messaging preferences". 2. Check the "Do not notify" for "Hold filled" -letter. 3. Check any other checkboxes for "Hold filled" -letter. The "Do not notify"-checkbox should get unchecked. 4. Check the "Do not notify" -checkbox again for the "Hold filled" -letter. Other selections for the row get unchecked. 5. Save changes. 6. Make a hold for a borrower. 7. Check-in the reserved Item and catch the hold. 8. In the notices-tab for the Borrower, there should be no message for the borrower about getting the caught Hold. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 --- Comment #6 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- This feature is about enabling explicit message rejection for selectable message types. Default behaviour is only overridden if the "Do not notify"-checkbox is checked. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli@cineca.it --- Comment #7 from Zeno Tajoli <z.tajoli@cineca.it> --- Is this patch ready to be tested ? If yes, we need to set as "Needs sign-off" -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #8 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Zeno, this feature is ready to be tested regarding the patches I made, but this is still missing a lot more message types. I need to take a look at our acquisitions department as they report severe slowdowns in the acquisitions process (and a ton of stuff) so I'll let you sign off these if you want. But followups need to be provided for the other message_types. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 --- Comment #9 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- But I feel like this is a good start for improving on this feature. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia@hotmail.com --- Comment #10 from Aleisha Amohia <aleishaamohia@hotmail.com> --- When I applied the patches, it got rid of all the checkboxes for Do not notify completely so I can't check or uncheck the boxes to test. I feel like this wasn't the preferred outcome? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 --- Comment #11 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Hi there and thanks for testing this! Did you run the updatedatabase.pl-script? I think I should have mentioned it in the TEST PLAN, but I have a bad habit of not doing so :) Thanks for reminding me! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35414|0 |1 is obsolete| | --- Comment #12 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 46566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46566&action=edit Bug 5501 - Improve the 'do not notify' option. HOLD-letter. TEST PLAN: 1. Find a Borrower and edit "Patron messaging preferences". 2. Check the "Do not notify" for "Hold filled" -letter. 3. Check any other checkboxes for "Hold filled" -letter. The "Do not notify"-checkbox should get unchecked. 4. Check the "Do not notify" -checkbox again for the "Hold filled" -letter. Other selections for the row get unchecked. 5. Save changes. 6. Make a hold for a borrower. 7. Check-in the reserved Item and catch the hold. 8. In the notices-tab for the Borrower, there should be no message for the borrower about getting the caught Hold. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Olli, is it still valid? As it, it cannot be pushed to master, it should be done for any letter types if we want it. Moreover, there is now a "none" message transport type when editing letter templates, I am not sure it removes confusion :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org