[Bug 29828] New: If no content is added to news/additional content entries, they are silently not saved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Bug ID: 29828 Summary: If no content is added to news/additional content entries, they are silently not saved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org To test: Add a new news or HTML customization entry, fill in the title for one or more languages. Leave content empty. Save. The entry hasn't been saved. There is no error and nothing visible in the logs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major Depends on| |29805 Summary|If no content is added to |If no content is added to |news/additional content |default, but a translation, |entries, they are silently |news/additional content |not saved |entries don't show in list See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29778 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think I got it now - the problem is a little different, but bad. Updated step by step: 1) Add a new html customization or news entry 2) Fill in the title for default, leave content empty 3) Fill in title and content for English 4) Save 5) Verify the new entry doesn't show in the list of entries 6) Run select idnew, category, code, location, title, lang from additional_contents order by code, lang; 7) Verify your entry is in the database Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 [Bug 29805] Database update fails in MySQL 5.7 because it's missing REGEXP_REPLACE -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29805 |24387 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 [Bug 24387] Rename News tool https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 [Bug 29805] Database update fails in MySQL 5.7 because it's missing REGEXP_REPLACE -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129239&action=edit Bug 29828: Prevent additional content to be created without default When creating or editing an additional content, the form is submitted if only the title of the 'default' tab is filled in. We should submit the form only if both title and content exist. Test plan: Create a new content using text editor (codemirror) Confirm that the form is submitted only if title and content from the default tab are not empty Try again with wysiwyg (tinymce) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Joubu, I am not sure that fixes the problem. The problem is translations again, because if there is no default entry, the entry won't show in the list at all. This will just force you to enter a default text. I think it should work without, in case you want to add content only for a specific language, as you could do that with news before too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #3)
Hi Joubu, I am not sure that fixes the problem.
The problem is translations again, because if there is no default entry, the entry won't show in the list at all. This will just force you to enter a default text.
I think it should work without, in case you want to add content only for a specific language, as you could do that with news before too.
Can you please have another look? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Status|Failed QA |Needs Signoff --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Sorry for the delay. I think we need to go with this patch, for a solution that can be backportable. It will fix "invisible" entries. On bug 24387 we (I) assumed that a default must exist. If we want to change this behavior it must be done on its own bug report I'd say, it may introduce side-effects. Here we need something easy that can be backported. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eb@efdss.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129239|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135097&action=edit Bug 29828: Prevent additional content to be created without default When creating or editing an additional content, the form is submitted if only the title of the 'default' tab is filled in. We should submit the form only if both title and content exist. Test plan: Create a new content using text editor (codemirror) Confirm that the form is submitted only if title and content from the default tab are not empty Try again with wysiwyg (tinymce) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Michael Kuhn <mik@adminkuhn.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mik@adminkuhn.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135097|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 135162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135162&action=edit Bug 29828: Prevent additional content to be created without default When creating or editing an additional content, the form is submitted if only the title of the 'default' tab is filled in. We should submit the form only if both title and content exist. Test plan: Create a new content using text editor (codemirror) Confirm that the form is submitted only if title and content from the default tab are not empty Try again with wysiwyg (tinymce) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #8 from David Nind <david@davidnind.com> --- Testing notes (koha-testing-docker): - When testing, I was getting some "flaky" behaviour with new news items not displaying. - In the end, I emptied the additional_contents table (truncate additional_contents;) and started again. - I think the issue was the difference between the date on my computer (we are NZST - so date was 19 May 2022) compared with koha-testing-docker (UTC time 18 May 2022): news wasn't displaying in the OPAC and staff interface as the date of the news item was in the future (that is, the publication date had not yet been reached). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |m.de.rooy@rijksmuseum.nl --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QAing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This adds a new string. Which kind of blocks it for 22.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135162|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 135191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135191&action=edit Bug 29828: Prevent additional content to be created without default When creating or editing an additional content, the form is submitted if only the title of the 'default' tab is filled in. We should submit the form only if both title and content exist. Test plan: Create a new content using text editor (codemirror) Confirm that the form is submitted only if title and content from the default tab are not empty Try again with wysiwyg (tinymce) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- @RM: Includes string changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 --- Comment #13 from Elaine Bradtke <eb@efdss.org> --- (In reply to David Nind from comment #8)
Testing notes (koha-testing-docker):
- When testing, I was getting some "flaky" behaviour with new news items not displaying.
- In the end, I emptied the additional_contents table (truncate additional_contents;) and started again.
- I think the issue was the difference between the date on my computer (we are NZST - so date was 19 May 2022) compared with koha-testing-docker (UTC time 18 May 2022): news wasn't displaying in the OPAC and staff interface as the date of the news item was in the future (that is, the publication date had not yet been reached).
I have seen the same flaky behaviour. I'm eight hours behind the catalogue I maintain, so there are times when they're on a different date. Good to know this is a potential problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Pushed to 22.05.x for 22.05.01, thanks all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |arthur.suzuki@biblibre.com --- Comment #16 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- pushed to 21.11.x for 21.11.07, thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00 22.05 21.11 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to stable |Needs documenting --- Comment #17 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Missing dependencies for 21.05.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org