[Bug 30466] New: Convert serials pages tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466 Bug ID: 30466 Summary: Convert serials pages tabs to Bootstrap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 29226 Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in three serials templates with Bootstrap: - serials-collection.tt - serials-search.tt - subscription-detail.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 132987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132987&action=edit Bug 30466: Convert serials pages tabs to Bootstrap This patch modifies three serials templates in order to replace jQueryUI tabs with Bootstrap tabs. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Serials. - Perform a serials search which will return one or more results. - On the search results page you should see an Open and Closed tab. - The tabs should look correct and work correctly. - Confirm that "Select all" and "Clear all" controls work correctly in each tab. - Click one of the search results to view the details for that subscription. - You should see tabs for Information, Planning, Issues, and Summary. You may also see an Acquisition details tab depending on your data. - In the sidebar menu click "Serial collection." - On this page you should see tabs corresponding to each year the serial has been received. - Under each tab the "Select all" and "Clear all" controls should work correctly in the context of that tab. Other controls should apply to all tabs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- I think because of Bug 29609 this one no longer cleanly applies to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30204 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204 [Bug 30204] Add subtitle to serial subscription search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132987|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 133209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133209&action=edit Bug 30466: Convert serials pages tabs to Bootstrap This patch modifies three serials templates in order to replace jQueryUI tabs with Bootstrap tabs. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Serials. - Perform a serials search which will return one or more results. - On the search results page you should see an Open and Closed tab. - The tabs should look correct and work correctly. - Confirm that "Select all" and "Clear all" controls work correctly in each tab. - Click one of the search results to view the details for that subscription. - You should see tabs for Information, Planning, Issues, and Summary. You may also see an Acquisition details tab depending on your data. - In the sidebar menu click "Serial collection." - On this page you should see tabs corresponding to each year the serial has been received. - Under each tab the "Select all" and "Clear all" controls should work correctly in the context of that tab. Other controls should apply to all tabs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133209|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 133467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133467&action=edit Bug 30466: Convert serials pages tabs to Bootstrap This patch modifies three serials templates in order to replace jQueryUI tabs with Bootstrap tabs. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Serials. - Perform a serials search which will return one or more results. - On the search results page you should see an Open and Closed tab. - The tabs should look correct and work correctly. - Confirm that "Select all" and "Clear all" controls work correctly in each tab. - Click one of the search results to view the details for that subscription. - You should see tabs for Information, Planning, Issues, and Summary. You may also see an Acquisition details tab depending on your data. - In the sidebar menu click "Serial collection." - On this page you should see tabs corresponding to each year the serial has been received. - Under each tab the "Select all" and "Clear all" controls should work correctly in the context of that tab. Other controls should apply to all tabs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30436 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 [Bug 30436] Convert article requests tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133467|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 133478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133478&action=edit Bug 30466: Convert serials pages tabs to Bootstrap This patch modifies three serials templates in order to replace jQueryUI tabs with Bootstrap tabs. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Serials. - Perform a serials search which will return one or more results. - On the search results page you should see an Open and Closed tab. - The tabs should look correct and work correctly. - Confirm that "Select all" and "Clear all" controls work correctly in each tab. - Click one of the search results to view the details for that subscription. - You should see tabs for Information, Planning, Issues, and Summary. You may also see an Acquisition details tab depending on your data. - In the sidebar menu click "Serial collection." - On this page you should see tabs corresponding to each year the serial has been received. - Under each tab the "Select all" and "Clear all" controls should work correctly in the context of that tab. Other controls should apply to all tabs. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133478|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133481&action=edit Bug 30466: Convert serials pages tabs to Bootstrap This patch modifies three serials templates in order to replace jQueryUI tabs with Bootstrap tabs. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Serials. - Perform a serials search which will return one or more results. - On the search results page you should see an Open and Closed tab. - The tabs should look correct and work correctly. - Confirm that "Select all" and "Clear all" controls work correctly in each tab. - Click one of the search results to view the details for that subscription. - You should see tabs for Information, Planning, Issues, and Summary. You may also see an Acquisition details tab depending on your data. - In the sidebar menu click "Serial collection." - On this page you should see tabs corresponding to each year the serial has been received. - Under each tab the "Select all" and "Clear all" controls should work correctly in the context of that tab. Other controls should apply to all tabs. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looks great! Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466 Bug 30466 depends on bug 30204, which changed state. Bug 30204 Summary: Add subtitle to serial subscription search https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Sorry this does not apply on master anymore, please rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133481|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 134530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134530&action=edit Bug 30466: Convert serials pages tabs to Bootstrap This patch modifies three serials templates in order to replace jQueryUI tabs with Bootstrap tabs. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Serials. - Perform a serials search which will return one or more results. - On the search results page you should see an Open and Closed tab. - The tabs should look correct and work correctly. - Confirm that "Select all" and "Clear all" controls work correctly in each tab. - Click one of the search results to view the details for that subscription. - You should see tabs for Information, Planning, Issues, and Summary. You may also see an Acquisition details tab depending on your data. - In the sidebar menu click "Serial collection." - On this page you should see tabs corresponding to each year the serial has been received. - Under each tab the "Select all" and "Clear all" controls should work correctly in the context of that tab. Other controls should apply to all tabs. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466 Bug 30466 depends on bug 30204, which changed state. Bug 30204 Summary: Add subtitle to serial subscription search https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466 Bug 30466 depends on bug 30204, which changed state. Bug 30204 Summary: Add subtitle to serial subscription search https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org