[Bug 38049] New: Admin/RecordSources_spec.ts failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 Bug ID: 38049 Summary: Admin/RecordSources_spec.ts failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Record sources CRUD tests ✓ Add (3304ms) ✓ List (3217ms) 1) Edit ✓ Delete (2965ms) 4 passing (16s) 1 failing 1) Record sources CRUD tests Edit: TypeError: The following error originated from your application code, not from Cypress. It was caused by an unhandled promise rejection.
$(...).tooltip is not a function
When Cypress detects uncaught errors originating from your application it will automatically fail the current test. This behavior is configurable, and you can choose to turn this off by listening to the `uncaught:exception` event. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37917 Assignee|chris@bigballofwax.co.nz |jonathan.druart@gmail.com Severity|enhancement |normal Status|NEW |ASSIGNED Summary|Admin/RecordSources_spec.ts |Admin/RecordSources_spec.ts |failing randomly |is still failing randomly --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Patch from bug 37917 didn't fix the problem. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37917 [Bug 37917] RecordSources_spec.ts is failing randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Recreated locally on 14th run. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- commit 5fe1ad8ac66072ef7e06d21d0ccc48d388ecaf79 Bug 35402: Update the OPAC and staff interface to Bootstrap 5 - $(".dt_button_clear_filter, .columns_controls, .export_controls, .dt_button_configure_table").tooltip(); + // $(".dt_button_clear_filter, .columns_controls, .export_controls, .dt_button_configure_table").tooltip(); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #3)
commit 5fe1ad8ac66072ef7e06d21d0ccc48d388ecaf79
Bug 35402: Update the OPAC and staff interface to Bootstrap 5
- $(".dt_button_clear_filter, .columns_controls, .export_controls, .dt_button_configure_table").tooltip(); + // $(".dt_button_clear_filter, .columns_controls, .export_controls, .dt_button_configure_table").tooltip();
What's the point of this tooltip() call actually? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 172250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172250&action=edit Revert "Bug 37917: Add some wait time to RecordSources_spec.ts for the intercepted request responses" This reverts commit 23b00bdc06d28e012724a37ed5052bf056026302. JD: No, really, don't wait. And it does not fix the issue initially raised on bug 37917 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 172251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172251&action=edit Bug 38049: Remove tooltip call from DT Not really sure why we had this line, but Owen decided to remove it when upgrading to Bootstrap5. We had a cypress test failing because of this line $(...).tooltip is not a function Removing it should fix the problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Still failing, so it's coming from the other occurrence: koha-tmpl/intranet-tmpl/prog/js/staff-global.js 376 $('[data-bs-toggle="tooltip"]').tooltip(); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Note that I have seen it in the console of the browser as well, so it's not a cypress thing (it just highlighted the problem). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37748 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Then it would be caused by commit df1ec831bfc33e3ef46cce5afaef04abebc4f886 Bug 37748: (follow-up) Move tooltip initialization to staff-global.js Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 [Bug 37748] In Bootstrap 5 "disabled" class must be on anchor tag, not list item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172251|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 172259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172259&action=edit Bug 38049: Remove tooltip call from DT Not really sure why we had this line, but Owen decided to remove it when upgrading to Bootstrap5. So let's remove them from the other files as well. Waiting for Owen to confirm this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 172260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172260&action=edit Bug 38049: Call .tooltip() only if needed This is cheating, yes. We had a cypress test failing because of this line $(...).tooltip is not a function It's failing randomly on Admin/RecordSources_spec.ts, which does not need the tooltip. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de, | |tomascohen@gmail.com Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Hmmm, I was a loop with this test running, and I *think* it failed, but I lost the output... I will need to try again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #12)
Hmmm, I was a loop with this test running, and I *think* it failed, but I lost the output...
I will need to try again.
Retried and looks ok (40 successful runs) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Just got hit (main) by this on /erm/agreements, and the console was pointing to $( ".dt_button_clear_filter, .columns_controls, .export_controls, .dt_button_configure_table" ).tooltip() in KohaTable.vue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172250|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 172431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172431&action=edit Revert "Bug 37917: Add some wait time to RecordSources_spec.ts for the intercepted request responses" This reverts commit 23b00bdc06d28e012724a37ed5052bf056026302. JD: No, really, don't wait. And it does not fix the issue initially raised on bug 37917 https://bugs.koha-community.org/show_bug.cgi?id=38049 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172259|0 |1 is obsolete| | --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 172432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172432&action=edit Bug 38049: Remove tooltip call from DT Not really sure why we had this line, but Owen decided to remove it when upgrading to Bootstrap5. So let's remove them from the other files as well. Waiting for Owen to confirm this one. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172260|0 |1 is obsolete| | --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 172433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172433&action=edit Bug 38049: Call .tooltip() only if needed This is cheating, yes. We had a cypress test failing because of this line $(...).tooltip is not a function It's failing randomly on Admin/RecordSources_spec.ts, which does not need the tooltip. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #18 from David Nind <david@davidnind.com> --- Testing notes using KTD: 1. Ran tests manually: run_cypress --spec t/cypress/integration/Admin/RecordSources_spec.ts 2. Before patches, repeated 15 times before the tests failed. 3. After patches, repeated 21 times and no failures. 4. Not sure how to run a cypress test repeatedly without doing it manually - happy to run more times if someone could share how to do that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Nind from comment #18)
4. Not sure how to run a cypress test repeatedly without doing it manually - happy to run more times if someone could share how to do that.
I am doing this (run 300x and stop on error): % for i in {1..300}; do echo "loop $i"; yarn cypress run --spec t/cypress/integration/Admin/RecordSources_spec.ts ; if [ "$?" = "1" ]; then break; fi; done -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 --- Comment #20 from David Nind <david@davidnind.com> --- (In reply to Jonathan Druart from comment #19)
(In reply to David Nind from comment #18)
4. Not sure how to run a cypress test repeatedly without doing it manually - happy to run more times if someone could share how to do that.
I am doing this (run 300x and stop on error): % for i in {1..300}; do echo "loop $i"; yarn cypress run --spec t/cypress/integration/Admin/RecordSources_spec.ts ; if [ "$?" = "1" ]; then break; fi; done
Thanks Jonathan! Have run with the patches applied 300 times, and no test failures. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172431|0 |1 is obsolete| | --- Comment #21 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172510&action=edit Revert "Bug 37917: Add some wait time to RecordSources_spec.ts for the intercepted request responses" This reverts commit 23b00bdc06d28e012724a37ed5052bf056026302. JD: No, really, don't wait. And it does not fix the issue initially raised on bug 37917 https://bugs.koha-community.org/show_bug.cgi?id=38049 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172432|0 |1 is obsolete| | --- Comment #22 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172511&action=edit Bug 38049: Remove tooltip call from DT Not really sure why we had this line, but Owen decided to remove it when upgrading to Bootstrap5. So let's remove them from the other files as well. Waiting for Owen to confirm this one. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172433|0 |1 is obsolete| | --- Comment #23 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172512&action=edit Bug 38049: Call .tooltip() only if needed This is cheating, yes. We had a cypress test failing because of this line $(...).tooltip is not a function It's failing randomly on Admin/RecordSources_spec.ts, which does not need the tooltip. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |pedro.amorim@ptfs-europe.co |y.org |m CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 Bug 38049 depends on bug 37748, which changed state. Bug 37748 Summary: In Bootstrap 5 "disabled" class must be on anchor tag, not list item https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 Bug 38049 depends on bug 37917, which changed state. Bug 37917 Summary: RecordSources_spec.ts is failing randomly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37917 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org