https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36775 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrewfh@dubcolib.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36775 --- Comment #1 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 166152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166152&action=edit Bug 36775: Allow multiple holds on record when holds per record is unlimited To test: 1 set Holds Per Record to Unlimited 2 confirm hold placement interface does not include "Holds to place (count)" 3 apply patch, restart all 4 reload hold placement interface, confirm it does include "Holds to place (count)" 5 set Holds Per Record to 2 6 confirm Holds to place shows when placing a first hold for a patron, but not when placing a second 7 set Holds Per Record to 1 8 confirm Holds to Place does not show 9 sign off and eat a nice snack -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36775 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166152|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 166158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166158&action=edit Bug 36775: Allow multiple holds on record when holds per record is unlimited To test: 1 set Holds Per Record to Unlimited 2 confirm hold placement interface does not include "Holds to place (count)" 3 apply patch, restart all 4 reload hold placement interface, confirm it does include "Holds to place (count)" 5 set Holds Per Record to 2 6 confirm Holds to place shows when placing a first hold for a patron, but not when placing a second 7 set Holds Per Record to 1 8 confirm Holds to Place does not show 9 sign off and eat a nice snack Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36775 --- Comment #4 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Emily Lamancusa from comment #3)

Patch does not apply. :(

Sorry, you don't get the nice snack from the test plan :( -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36775 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166158|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 166467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166467&action=edit Bug 36775: Allow multiple holds on record when holds per record is unlimited To test: 1 set Holds Per Record to Unlimited 2 confirm hold placement interface does not include "Holds to place (count)" 3 apply patch, restart all 4 reload hold placement interface, confirm it does include "Holds to place (count)" 5 set Holds Per Record to 2 6 confirm Holds to place shows when placing a first hold for a patron, but not when placing a second 7 set Holds Per Record to 1 8 confirm Holds to Place does not show 9 sign off and eat a nice snack -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36775 --- Comment #7 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 166469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166469&action=edit Bug 36775: (QA follow-up) Remove max_length attribute The existing code for "Holds to place (count)" sets the input field's maxlength to remaining_holds_for_record, which does not do what we want and makes the field unusable when the circulation rules allow unlimited holds. Better to remove it. Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36775 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36775 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36775 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Does not apply on 23.11.x maybe some dependancy -- You are receiving this mail because: You are watching all bug changes.