[Bug 7645] New: System preferences editor save button obscured by language chooser
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7645 Priority: P5 - low Change sponsored?: --- Bug ID: 7645 CC: gmcharlt@gmail.com Assignee: oleonard@myacpl.org Summary: System preferences editor save button obscured by language chooser QA Contact: koha.sekjal@gmail.com Severity: normal Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: ASSIGNED Version: master Component: System Administration Product: Koha Created attachment 8017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8017&action=edit Screenshot detail If you have multiple languages enabled in the staff client and you're working on a preferences page which requires scrolling the bottom-most submit button is partially obscured by the language chooser. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7645 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 8019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8019&action=edit Bug 7645 - System preferences editor save button obscured by language chooser This patch amends the preferences page's CSS file to add bottom padding to the page container. This gives the bottom- most submit button some breathing room. Markup correction: Adding "row" and "col" attributes to <textareas> to quiet validation errors. This doesn't affect output at all (dimensions are specified in CSS). To test, open the system preferences page to a tab like OPAC which contains many preferences. At the bottom of the page the last submit button should have about a line's worth of white space below it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7645 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7645 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8019|0 |1 is obsolete| | --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 8092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8092&action=edit [Signed-off] Bug 7645 - System preferences editor save button obscured by language chooser Simple patch, easy to test. ++ for the html correction (W3 validator on opac sysprefs page gives me 41 errors on master, 17 with the patch) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7645 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7645 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Ian Walls <koha.sekjal@gmail.com> --- Template and CSS only change. Improves automated validation tests. Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7645 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_6 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- Comment : to test this patch, it's required to flush FF cache (CTRL-F5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7645 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This bug will be included in the Koha 3.6.5 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org