[Bug 7656] New: "undefined" pop-up message when putting hold on reference item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7656 Priority: P5 - low Change sponsored?: --- Bug ID: 7656 CC: gmcharlt@gmail.com Assignee: koha.sekjal@gmail.com Summary: "undefined" pop-up message when putting hold on reference item QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: kyle.m.hall@gmail.com Hardware: All Status: NEW Version: rel_3_8 Component: Hold requests Product: Koha Created attachment 8042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8042&action=edit Image of message box When placing a hold on an item that needs confirmation, the pop-up window says: undefined Place a hold on this item? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7656 --- Comment #1 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 8043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8043&action=edit Bug 7656 - "undefined" pop-up message when putting hold on reference item This is a single line fix. Initializing the msg var to an empty string solves the problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7656 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7656 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7656 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8043|0 |1 is obsolete| | --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 8184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8184&action=edit Bug 7656 - "undefined" pop-up message when putting hold on reference item This is a single line fix. Initializing the msg var to an empty string solves the problem. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7656 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jcamins@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7656 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Ian Walls <koha.sekjal@gmail.com> --- Trivial patch to define msg as a blank string. Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7656 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|rel_3_8 |rel_3_6 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- Kyle : when you submit a bug, please don't use "rel_3_8" for now, as you can't be sure it will be included for 3.8. I use this version when pushing a patch, because when I push, it will be in 3.8, for sure ! + this bug is probably also relevant for 3.6, so switching to rel_3_6 (patch pushed) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7656 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This bug will be included in the Koha 3.6.5 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org