[Bug 36017] New: Dead code in admin/clone-rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36017 Bug ID: 36017 Summary: Dead code in admin/clone-rules Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 18936 Since commit 61628c97c245e72c750b61d9df6fa9b9100f3093 Bug 18936: (follow-up) Add cloning of circulation rules back to Koha There are some dead code in admin/clone-rules. "result" is always passed to the template. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 [Bug 18936] Move issuingrules into circulation_rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36017 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36017 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 161809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161809&action=edit Bug 36017: Remove dead code in admin/clone-rules Since commit 61628c97c245e72c750b61d9df6fa9b9100f3093 Bug 18936: (follow-up) Add cloning of circulation rules back to Koha There are some dead code in admin/clone-rules. "result" is always passed to the template. Test plan: Confirm the above and that cloning rules from the circ rules page still works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36017 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34478 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36017 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36017 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161809|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 161818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161818&action=edit Bug 36017: Remove dead code in admin/clone-rules Since commit 61628c97c245e72c750b61d9df6fa9b9100f3093 Bug 18936: (follow-up) Add cloning of circulation rules back to Koha There are some dead code in admin/clone-rules. "result" is always passed to the template. Test plan: Confirm the above and that cloning rules from the circ rules page still works correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36017 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36017 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161818|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 161950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161950&action=edit Bug 36017: Remove dead code in admin/clone-rules Since commit 61628c97c245e72c750b61d9df6fa9b9100f3093 Bug 18936: (follow-up) Add cloning of circulation rules back to Koha There are some dead code in admin/clone-rules. "result" is always passed to the template. Test plan: Confirm the above and that cloning rules from the circ rules page still works correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36017 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Pushed to master for 24.05.00. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36017 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org