[Bug 36019] New: Dead code in tags/review
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36019 Bug ID: 36019 Summary: Dead code in tags/review Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 20489 Since bug 20489 it is no longer possible to login with the DB user. At the time, get_template_and_user returned borrowernumber=0 in this case. In tags/review.pl we have: $borrowernumber == 0 and push @errors, {op_zero=>1}; This condition is never met, and op_zero related code can be removed in the template. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 [Bug 20489] Prevent DB user login -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36019 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34478 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36019 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36019 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 161811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161811&action=edit Bug 36019: Remove dead code in tags/review Since bug 20489 it is no longer possible to login with the DB user. At the time, get_template_and_user returned borrowernumber=0 in this case. In tags/review.pl we have: $borrowernumber == 0 and push @errors, {op_zero=>1}; This condition is never met, and op_zero related code can be removed in the template. Test plan: Confirm the above -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36019 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36019 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161811|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 161817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161817&action=edit Bug 36019: Remove dead code in tags/review Since bug 20489 it is no longer possible to login with the DB user. At the time, get_template_and_user returned borrowernumber=0 in this case. In tags/review.pl we have: $borrowernumber == 0 and push @errors, {op_zero=>1}; This condition is never met, and op_zero related code can be removed in the template. Test plan: Confirm the above Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36019 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36019 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Pushed to master for 24.05.00. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36019 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org