https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149578|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149579&action=edit Bug 33505: Improve styling of scan index page This patch makes some changes to the 'scan index' page. * Updates second h1 heading "Scan index:" to h2 level heading "Scan index" * Removes table from the search form * Moves search index pull down and search term into one line * Reorders options with search index first and search term after, matching the advanced search form * Removes the catalog results toolbar from the top, card hold etc. are not needed here. * Fixes doubled up id attribute: scan-index by turning one into scan-index-term. To test: * Go to advanced search in staff interface * Activate 'More options' * Check checkbox for scan indexes * Switch to author (especially when using Elasticsearch) * Search for C * Check display, especially search options, options at the top of the page etc. * Apply patch * Verify changes listed above * Regression test the normal search results, all should look the same with and without patch. * If you think the scan index page is nicer now - sign off. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I fixed a problem with the dependent bug and forgot to rebase this one on top. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149579|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149625&action=edit Bug 33505: Improve styling of scan index page This patch makes some changes to the 'scan index' page. * Updates second h1 heading "Scan index:" to h2 level heading "Scan index" * Removes table from the search form * Moves search index pull down and search term into one line * Reorders options with search index first and search term after, matching the advanced search form * Removes the catalog results toolbar from the top, card hold etc. are not needed here. * Fixes doubled up id attribute: scan-index by turning one into scan-index-term. To test: * Go to advanced search in staff interface * Activate 'More options' * Check checkbox for scan indexes * Switch to author (especially when using Elasticsearch) * Search for C * Check display, especially search options, options at the top of the page etc. * Apply patch * Verify changes listed above * Regression test the normal search results, all should look the same with and without patch. * If you think the scan index page is nicer now - sign off. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- This is an improvement, here are some additional things I noted: 1. Zebra and Elasticsearch result differences: - when using Zebra, only 20 results are displayed - it looks to me like the pagination of search results is missing, or maybe it is too difficult. - when using Elasticsearch, there is pagination at the bottom (like the normal staff interface catalog search results) 2. The results pages need the page section added (bug 31757). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #7)

It definitely looks better! There is a small typo around line 376:

[% ELSE %]<option selected="selected" value="">Any word</option[% END %]

should be:

[% ELSE %]<option selected="selected" value="">Any word</option>[% END %]

Hi Lucas, thx for noticing :) I have fixed that for the third (and hopefully last time) now. I hope this one for good (had some problems with the branches building on each other and rebases :( ) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149713|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 150299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150299&action=edit Bug 33505: Improve styling of scan index page This patch makes some changes to the 'scan index' page. * Updates second h1 heading "Scan index:" to h2 level heading "Scan index" * Removes table from the search form * Moves search index pull down and search term into one line * Reorders options with search index first and search term after, matching the advanced search form * Removes the catalog results toolbar from the top, card hold etc. are not needed here. * Fixes doubled up id attribute: scan-index by turning one into scan-index-term. To test: * Go to advanced search in staff interface * Activate 'More options' * Check checkbox for scan indexes * Switch to author (especially when using Elasticsearch) * Search for C * Check display, especially search options, options at the top of the page etc. * Apply patch * Verify changes listed above * Regression test the normal search results, all should look the same with and without patch. * If you think the scan index page is nicer now - sign off. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 --- Comment #12 from David Nind <david@davidnind.com> --- (In reply to Nick Clemens from comment #11)

(In reply to David Nind from comment #6)

...

This is an improvement, here are some additional things I noted:

1. Zebra and Elasticsearch result differences: - when using Zebra, only 20 results are displayed - it looks to me like the pagination of search results is missing, or maybe it is too difficult. - when using Elasticsearch, there is pagination at the bottom (like the normal staff interface catalog search results)

This is because the Zebra scan only returns a single page of results, not a full count - I don't know why, it seems to be a variable we pass/set somewhere, but the scan size is always limited - much deeper bug than this

Thanks Nick for explaining. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---

2. The results pages need the page section added (bug 31757).

Moved to: Bug 33643 - Add page-section to 'scan index' page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.