[Bug 33506] New: Series has wrong index name on scan index page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 Bug ID: 33506 Summary: Series has wrong index name on scan index page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org On the 'scan index' page in the staff interface, there is a typo in the template: <option value="su">Series</option> su is the index for subjects. This should be series-title or se. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Series has wrong index name |Series has wrong index name |on scan index page |on scan index page and | |search option selection is | |not retained -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149576&action=edit Bug 33506: Fix false index for series and keep selected index on scan index page The pull down with search options had the wrong index linked to the Series entry: su instead of se To test: * Go to advanced search in staff interface * Activate 'More options' * Check checkbox for scan indexes * Switch to author (especially when using Elasticsearch) * Search for C * Verify search results link to authors using c * Switch to series * Verify search results use 'su' for subject * Verify that search option pull down always jumps back to first entry: Any word * Apply patch * Verify the search results for series now use correct index se * Verify that coming from advanced search, the correct search option is selected * Verify that changing the search option also keeps the selection after searching Note: with Elasticsearch and default configuration author, title and series will give you results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 [Bug 33505] Doubled up id 'scan-index' on 'scan index' page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149576|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149577&action=edit Bug 33506: Fix false index for series and keep selected index on scan index page The pull down with search options had the wrong index linked to the Series entry: su instead of se To test: * Go to advanced search in staff interface * Activate 'More options' * Check checkbox for scan indexes * Switch to author (especially when using Elasticsearch) * Search for C * Verify search results link to authors using c * Switch to series * Verify search results use 'su' for subject * Verify that search option pull down always jumps back to first entry: Any word * Apply patch * Verify the search results for series now use correct index se * Verify that coming from advanced search, the correct search option is selected * Verify that changing the search option also keeps the selection after searching Note: with Elasticsearch and default configuration author, title and series will give you results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149577|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 149620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149620&action=edit Bug 33506: Fix false index for series and keep selected index on scan index page The pull down with search options had the wrong index linked to the Series entry: su instead of se To test: * Go to advanced search in staff interface * Activate 'More options' * Check checkbox for scan indexes * Switch to author (especially when using Elasticsearch) * Search for C * Verify search results link to authors using c * Switch to series * Verify search results use 'su' for subject * Verify that search option pull down always jumps back to first entry: Any word * Apply patch * Verify the search results for series now use correct index se * Verify that coming from advanced search, the correct search option is selected * Verify that changing the search option also keeps the selection after searching Note: with Elasticsearch and default configuration author, title and series will give you results. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. One thing I noted (not related to this bug) is that: - when using Zebra, only 20 results are displayed - it looks to me like the pagination of search results is missing - when using Elasticsearch, there is pagination at the bottom (like the normal staff interface catalog search results) 2. Also not related to this bug, the results pages need the page section added (bug 31757). I'm happy to add the bugs for these if they don't exist already. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 --- Comment #5 from David Nind <david@davidnind.com> --- (In reply to David Nind from comment #4)
Testing notes (using KTD):
1. One thing I noted (not related to this bug) is that: - when using Zebra, only 20 results are displayed - it looks to me like the pagination of search results is missing - when using Elasticsearch, there is pagination at the bottom (like the normal staff interface catalog search results)
2. Also not related to this bug, the results pages need the page section added (bug 31757).
I'm happy to add the bugs for these if they don't exist already.
Please ignore this comment. I've added it to bug 33505. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149620|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 150300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150300&action=edit Bug 33506: Fix false index for series and keep selected index on scan index page The pull down with search options had the wrong index linked to the Series entry: su instead of se To test: * Go to advanced search in staff interface * Activate 'More options' * Check checkbox for scan indexes * Switch to author (especially when using Elasticsearch) * Search for C * Verify search results link to authors using c * Switch to series * Verify search results use 'su' for subject * Verify that search option pull down always jumps back to first entry: Any word * Apply patch * Verify the search results for series now use correct index se * Verify that coming from advanced search, the correct search option is selected * Verify that changing the search option also keeps the selection after searching Note: with Elasticsearch and default configuration author, title and series will give you results. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.13 released in| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org