[Bug 9591] New: BUG: Set Library changes after viewing Holds Queue >> reserves item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9591 Bug ID: 9591 Summary: BUG: Set Library changes after viewing Holds Queue >> reserves item Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: jesse@bywatersolutions.com CC: gmcharlt@gmail.com Serious bug encountered. SET LIBRARY automatically changes after viewing Holds Queue report for another library and then clicking on a reserved item on patron record. See attached video. Video Link: http://media.bywatersolutions.com/Video/set_library_change_bug.mp4 Best Regards, -Jesse -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9591 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master Summary|BUG: Set Library changes |Set Library changes after |after viewing Holds Queue |viewing Holds Queue >> |>> reserves item |reserves item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9591 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Steps to reproduce: 1. Log in to the staff client. Note your logged in library. 2. Navigate to Circulation -> Holds queue. 3. Select a holds queue report for a library other than your own. 4. From the holds queue report page, click the "Check out" tab and enter the card number of a patron who has holds. 5. On the circulation page for that patron, click the "Holds" tab. 6. Click one of the titles in the list of holds. Your logged in branch will now match the library you chose for the holds queue report. Alternate sequence: 4. From the holds queue report page, click the "Check out" tab and do a non-exact search (search which will return more than one result) for a patron who has holds. 5. Choose the correct patron from the list of results. Your logged in branch will now match the library you chose for the holds queue report. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9591 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9591 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 CC| |wizzyrea@gmail.com --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- I verify this as a problem, and it's a big one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9591 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |chris@bigballofwax.co.nz Assignee|koha-bugs@lists.koha-commun |chris@bigballofwax.co.nz |ity.org | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Working on a fix for this -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9591 --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Ah ha <input autocomplete="off" id="findborrower" name="findborrower" size="40" class="focus" type="text" /> <input id="autocsubmit" type="submit" class="submit" value="Submit" /> <input name="branch" value="AS" type="hidden" /> And we set branch => $branchlimit, Which is what we chose to limit on. However in koha-tmpl/intranet-tmpl/prog/en/includes/patron-search-box.inc we set <input name="branch" value="[% branch %]" type="hidden" /> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9591 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9591 --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17274&action=edit Bug 9591 : Set Library changes after viewing Holds Queue >> reserves item To test 1. Log in to the staff client. Note your logged in library. 2. Navigate to Circulation -> Holds queue. 3. Select a holds queue report for a library other than your own. 4. From the holds queue report page, click the "Check out" tab and enter the card number of a patron who has holds. 5. On the circulation page for that patron, click the "Holds" tab. 6. Click one of the titles in the list of holds. Your logged in branch will now match the library you chose for the holds queue report. Alternate sequence: 4. From the holds queue report page, click the "Check out" tab and do a non-exact search (search which will return more than one result) for a patron who has holds. 5. Choose the correct patron from the list of results. Your logged in branch will now match the library you chose for the holds queue report. Apply the patch and repeat, this time it should not change your logged in branch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9591 --- Comment #6 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 17282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17282&action=edit Bug 9591 : Set Library changes after viewing Holds Queue >> reserves item To test 1. Log in to the staff client. Note your logged in library. 2. Navigate to Circulation -> Holds queue. 3. Select a holds queue report for a library other than your own. 4. From the holds queue report page, click the "Check out" tab and enter the card number of a patron who has holds. 5. On the circulation page for that patron, click the "Holds" tab. 6. Click one of the titles in the list of holds. Your logged in branch will now match the library you chose for the holds queue report. Alternate sequence: 4. From the holds queue report page, click the "Check out" tab and do a non-exact search (search which will return more than one result) for a patron who has holds. 5. Choose the correct patron from the list of results. Your logged in branch will now match the library you chose for the holds queue report. Apply the patch and repeat, this time it should not change your logged in branch Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Weird bug, the patch works for me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9591 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17274|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9591 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9591 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9591 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17282|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17322&action=edit [PASSED QA] Bug 9591 : Set Library changes after viewing Holds Queue >> reserves item To test 1. Log in to the staff client. Note your logged in library. 2. Navigate to Circulation -> Holds queue. 3. Select a holds queue report for a library other than your own. 4. From the holds queue report page, click the "Check out" tab and enter the card number of a patron who has holds. 5. On the circulation page for that patron, click the "Holds" tab. 6. Click one of the titles in the list of holds. Your logged in branch will now match the library you chose for the holds queue report. Alternate sequence: 4. From the holds queue report page, click the "Check out" tab and do a non-exact search (search which will return more than one result) for a patron who has holds. 5. Choose the correct patron from the list of results. Your logged in branch will now match the library you chose for the holds queue report. Apply the patch and repeat, this time it should not change your logged in branch Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Weird bug, the patch works for me. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Good catch. All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9591 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9591 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.6 and 3.8.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org