[Bug 9802] New: Add test case to verify package man pages are well formatted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9802 Bug ID: 9802 Summary: Add test case to verify package man pages are well formatted Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: robin@catalyst.net.nz CC: robin@catalyst.net.nz This will add a test case that ensures that the .xml files in debian/docs are correctly formatted, just as a quick extra check that things are all happy. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9802 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |robin@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9802 --- Comment #1 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 16086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16086&action=edit Bug 9802 - add test case to ensure man pages have correct XML To test: * run xt/verify-debian-docbook.t and make sure it's all OK * modify an xml file in debian/docs, try again, make sure it fails -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9802 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9802 --- Comment #2 from Robin Sheat <robin@catalyst.net.nz> --- Forgot to add to the commit message: this will also cause a package build failure if the XML is invalid. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9802 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16086|0 |1 is obsolete| | --- Comment #3 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 16519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16519&action=edit Bug 9802 - add test case to ensure man pages have correct XML To test: * run xt/verify-debian-docbook.t and make sure it's all OK * modify an xml file in debian/docs, try again, make sure it fails Signed-off-by: Magnus Enger <magnus@enger.priv.no> - Running "prove -v xt/verify-debian-docbook.t" loops through all the XML files in debian/docs and reports them as being ok. - Removing a "<" from one of the files makes the test report it as an error - I did not verify that the test actually trips up a package build if there is invalid XML. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9802 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9802 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16519|0 |1 is obsolete| | --- Comment #4 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 16520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16520&action=edit Bug 9802 - add test case to ensure man pages have correct XML To test: * run xt/verify-debian-docbook.t and make sure it's all OK * modify an xml file in debian/docs, try again, make sure it fails Signed-off-by: Magnus Enger <magnus@enger.priv.no> - Running "prove -v xt/verify-debian-docbook.t" loops through all the XML files in debian/docs and reports them as being ok. - Removing a "<" from one of the files makes the test report it as an error - I did not verify that the test actually trips up a package build if there is invalid XML. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9802 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16520|0 |1 is obsolete| | --- Comment #5 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 16521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16521&action=edit Bug 9802 - [SIGNED-OFF] add test case to ensure man pages have correct XML To test: * run xt/verify-debian-docbook.t and make sure it's all OK * modify an xml file in debian/docs, try again, make sure it fails Signed-off-by: Magnus Enger <magnus@enger.priv.no> - Running "prove -v xt/verify-debian-docbook.t" loops through all the XML files in debian/docs and reports them as being ok. - Removing a "<" from one of the files makes the test report it as an error - I did not verify that the test actually trips up a package build if there is invalid XML. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9802 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |magnus@enger.priv.no --- Comment #6 from Magnus Enger <magnus@enger.priv.no> --- <magnuse> jcamins: i just signed off 9802 - i guess it does not need qa since it's from eythian and to do with the packages? <magnuse> bug 9802 <huginn> Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9802 enhancement, P5 - low, ---, robin, Signed Off , Add test case to verify package man pages are well formatted <jcamins> magnuse: yes, please set to Passed QA. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9802 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9802 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.5 and 3.8.12 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9802 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9802 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8158 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9802 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8158 See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8158 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9802 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #9 from Magnus Enger <magnus@enger.priv.no> --- Works nicely in master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org