[Bug 38642] New: DataTables expand button has no label
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38642 Bug ID: 38642 Summary: DataTables expand button has no label Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Accessibility Assignee: koha-bugs@lists.koha-community.org Reporter: jake.deery@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, oleonard@myacpl.org It has been noted in a recent accessibility audit that the expand row button found on /cgi-bin/koha/opac-detail.pl when on mobile, or zoomed in, has no meaningful label. Ideally, a label should be present to describe the function of this button, as the plus / minus symbol is ambiguous. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38642 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38642 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38642 Edith Speller <edith.speller@ukhsa.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |edith.speller@ukhsa.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38642 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38642 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 184685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184685&action=edit Bug 38642: Added title and label to the expand row button To test: 1. Apply the patch * Restart all relevant services (e.g., Plack, Apache) to ensure changes take effect. 2. Navigate to a record’s detail page * Example URL: /cgi-bin/koha/opac-detail.pl?biblionumber=51&query_desc=kw%2Cwrdl%3A code 3. Inspect the holdings table * Locate the expand/collapse button (the first cell in each row, with class dtr-control). 4. Check the accessibility attributes * Right-click on the expand button > Inspect Element (in browser dev tools). * Confirm the following are present on the <td>: * title="Expand or collapse row details" * aria-label="Expand or collapse row details" * tabindex="0" 5. Sign off and have an incredible day! :D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38642 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Assignee|koha-bugs@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38642 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184752&action=edit Bug 38642: [Alternate] DataTables expand button has no label This patch modifies the OPAC's DataTables JS so that any table heading with a "dtr-control-col" will trigger the application of title and aria-label attributes on the responsive controls column. All OPAC tables with a responsive configuration have been modified with the class. To test, apply the patch and check all affected tables. - Narrow the width of the browser window until the responsive functionality is triggered. - Check that the expand/collapse button has title and aria-label attributes, "Expand or collapse row details" - Authority search results - Course reserves - List of courses - Course reserves - List of titles for a course - Bibliographic detail page: - Holdsings - Subscriptions - Search history - Bibliographic, past and present - Authorities, past and present - Most popular titles - Logged in user's active clubs - Logged in user's scheduled curbside pickups - Logged in user's recalls history - Logged in user's checkout history - Logged in user's messaging settings - Logged in user's submitted tags Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38642 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Sorry to be a busybody, I just thought we needed a solution which didn't require us to modify the DT configuration for all responsive DataTables. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38642 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Owen, + .attr("aria-label", "Expand or collapse row details") + .attr("title", "Expand or collapse row details"); You need to use __("") to make the strings translatable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38642 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #4)
You need to use __("") to make the strings translatable.
I know better than to make that mistake!! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38642 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184752|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184793&action=edit Bug 38642: [Alternate] DataTables expand button has no label This patch modifies the OPAC's DataTables JS so that any table heading with a "dtr-control-col" will trigger the application of title and aria-label attributes on the responsive controls column. All OPAC tables with a responsive configuration have been modified with the class. To test, apply the patch and check all affected tables. - Narrow the width of the browser window until the responsive functionality is triggered. - Check that the expand/collapse button has title and aria-label attributes, "Expand or collapse row details" - Authority search results - Course reserves - List of courses - Course reserves - List of titles for a course - Bibliographic detail page: - Holdsings - Subscriptions - Search history - Bibliographic, past and present - Authorities, past and present - Most popular titles - Logged in user's active clubs - Logged in user's scheduled curbside pickups - Logged in user's recalls history - Logged in user's checkout history - Logged in user's messaging settings - Logged in user's submitted tags Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38642 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184793|0 |1 is obsolete| | --- Comment #7 from Jake Deery <jake.deery@openfifth.co.uk> --- Created attachment 185310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185310&action=edit Bug 38642: [Alternate] DataTables expand button has no label This patch modifies the OPAC's DataTables JS so that any table heading with a "dtr-control-col" will trigger the application of title and aria-label attributes on the responsive controls column. All OPAC tables with a responsive configuration have been modified with the class. To test, apply the patch and check all affected tables. - Narrow the width of the browser window until the responsive functionality is triggered. - Check that the expand/collapse button has title and aria-label attributes, "Expand or collapse row details" - Authority search results - Course reserves - List of courses - Course reserves - List of titles for a course - Bibliographic detail page: - Holdsings - Subscriptions - Search history - Bibliographic, past and present - Authorities, past and present - Most popular titles - Logged in user's active clubs - Logged in user's scheduled curbside pickups - Logged in user's recalls history - Logged in user's checkout history - Logged in user's messaging settings - Logged in user's submitted tags Sponsored-by: Athens County Public Libraries Signed-off-by: Jake Deery <jake.deery@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38642 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Jake Deery <jake.deery@openfifth.co.uk> --- I like reduced repetition..! Signed off :-) Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38642 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38642 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184685|0 |1 is obsolete| | Attachment #185310|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186121&action=edit Bug 38642: DataTables expand button has no label This patch modifies the OPAC's DataTables JS so that any table heading with a "dtr-control-col" will trigger the application of title and aria-label attributes on the responsive controls column. All OPAC tables with a responsive configuration have been modified with the class. To test, apply the patch and check all affected tables. - Narrow the width of the browser window until the responsive functionality is triggered. - Check that the expand/collapse button has title and aria-label attributes, "Expand or collapse row details" - Authority search results - Course reserves - List of courses - Course reserves - List of titles for a course - Bibliographic detail page: - Holdsings - Subscriptions - Search history - Bibliographic, past and present - Authorities, past and present - Most popular titles - Logged in user's active clubs - Logged in user's scheduled curbside pickups - Logged in user's recalls history - Logged in user's checkout history - Logged in user's messaging settings - Logged in user's submitted tags Sponsored-by: Athens County Public Libraries Signed-off-by: Jake Deery <jake.deery@openfifth.co.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38642 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38642 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |accessibility -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38642 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38642 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38642 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38642 --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38642 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38642 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #13 from David Nind <david@davidnind.com> --- No changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org