[Bug 39980] New: Vendors pages are broken when using Koha as a Mojolicious application
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 Bug ID: 39980 Summary: Vendors pages are broken when using Koha as a Mojolicious application Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org Depends on: 38010 Bug 38010 broke the vendors pages when Koha is running as a Mojolicious application Steps to reproduce: 1. Run `bin/intranet daemon -l http://*:3000/` 2. Point your browser to http://localhost:3000 (replace localhost by the hostname/IP of koha's container, if needed) 3. Go to Acquisitions and search for a vendor. You will get an error 404. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 [Bug 38010] Migrate vendors to Vue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 182768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182768&action=edit Bug 39980: Fix vendors pages when using Koha as a Mojo app Bug 38010 broke the vendors pages when Koha is running as a Mojolicious application This adds new routes to Koha::App::Intranet to mimic the Apache rewrite rules added in bug 38010. To be able to do that, the CGIBinKoha plugin's code had to be moved to a controller. The logic remains the same. Test plan: 1. Run `bin/intranet daemon -l http://*:3000/` 2. Point your browser to http://localhost:3000 (replace localhost by the hostname/IP of koha's container, if needed) 3. Go to Acquisitions and search for a vendor. You should see the list of vendors. 4. Click on "New vendor" button. Notice the URL changed to .../acquisition/vendors/add. 5. Reload the page. You should still see the form to create a new vendor 6. Verify that you can create a vendor and that you are then redirected to the list of vendors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 182769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182769&action=edit Bug 39980: Add tests for .../acquisition/vendors* in Mojo context -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- The tests are not executed inside a DB transaction because when they are, I get the following error: DBIx::Class::Storage::DBI::mysql::_exec_svp_release(): DBI Exception: DBD::mysql::db do failed: SAVEPOINT savepoint_1 does not exist at /home/koha/koha/Koha/Object.pm line 174 Anyone knows how to fix this ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- I had a go at testing, but I can't get it to work for me using KTD. Starting up: bin/intranet daemon -l http://*:3000/ [2025-05-23 20:51:42.98851] [4056] [info] Listening at "http://*:3000/" Web application available at http://127.0.0.1:3000/ Accessing the URL: This site can’t be reached 127.0.0.1 refused to connect. Try: Checking the connection Checking the proxy and the firewall ERR_CONNECTION_REFUSED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to David Nind from comment #4)
I had a go at testing, but I can't get it to work for me using KTD. You have to point your browser to the KTD container's IP, not 127.0.0.1
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182768|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 182874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182874&action=edit Bug 39980: Fix vendors pages when using Koha as a Mojo app Bug 38010 broke the vendors pages when Koha is running as a Mojolicious application This adds new routes to Koha::App::Intranet to mimic the Apache rewrite rules added in bug 38010. To be able to do that, the CGIBinKoha plugin's code had to be moved to a controller. The logic remains the same. Test plan: 1. Run `bin/intranet daemon -l http://*:3000/` 2. Point your browser to http://localhost:3000 (replace localhost by the hostname/IP of koha's container, if needed) 3. Go to Acquisitions and search for a vendor. You should see the list of vendors. 4. Click on "New vendor" button. Notice the URL changed to .../acquisition/vendors/add. 5. Reload the page. You should still see the form to create a new vendor 6. Verify that you can create a vendor and that you are then redirected to the list of vendors Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182769|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 182875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182875&action=edit Bug 39980: Add tests for .../acquisition/vendors* in Mojo context Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes vendor pages release notes| |when running Koha as a | |Mojolicious application. | |You couldn't search for or | |create vendors (you get a | |page not found error). | |(This is related to bug | |38010 - Migrate vendors to | |Vue, added to Koha 25.05.) --- Comment #8 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Step 2 - to find the IP address of the koha docker container: - access a new terminal window on your computer - find the name of the koha container: docker ps (it should be kohadev-koha-1) - find the IP address (for me, it was at the very end of the output - IPAddress): sudo docker container inspect kohadev-koha-1 2. Check that the tests pass: prove t/db_dependent/mojo/acquisition/vendors.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- [FAIL] Koha/App/Controller/CGI.pm SKIP pod_coverage No POD exists SKIP spelling FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl Koha/App/Controller/CGI.pm` [FAIL] Koha/App/Intranet.pm SKIP spelling FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl Koha/App/Intranet.pm` [FAIL] Koha/App/Opac.pm SKIP spelling FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl Koha/App/Opac.pm` [PASS] Koha/App/Plugin/CGIBinKoha.pm [FAIL] t/db_dependent/mojo/acquisition/vendors.t SKIP spelling FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl t/db_dependent/mojo/acquisition/vendors.t` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Test Summary Report ------------------- /usr/share/koha/t/db_dependent/mojo/acquisition/vendors.t (Wstat: 256 (exited 1) Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=1, 10 wallclock secs ( 0.03 usr 0.01 sys + 9.59 cusr 0.40 csys = 10.03 CPU) Result: FAIL not ok 4 - Login OK # Failed test 'Login OK' # at t/db_dependent/mojo/acquisition/vendors.t line 35. [etc etc] Auth ERROR: Cannot get_session() at /usr/share/koha/C4/Auth.pm line 1060. => in sub checkauth -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182874|0 |1 is obsolete| | --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 184292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184292&action=edit Bug 39980: Fix vendors pages when using Koha as a Mojo app Bug 38010 broke the vendors pages when Koha is running as a Mojolicious application This adds new routes to Koha::App::Intranet to mimic the Apache rewrite rules added in bug 38010. To be able to do that, the CGIBinKoha plugin's code had to be moved to a controller. The logic remains the same. Test plan: 1. Run `bin/intranet daemon -l http://*:3000/` 2. Point your browser to http://localhost:3000 (replace localhost by the hostname/IP of koha's container, if needed) 3. Go to Acquisitions and search for a vendor. You should see the list of vendors. 4. Click on "New vendor" button. Notice the URL changed to .../acquisition/vendors/add. 5. Reload the page. You should still see the form to create a new vendor 6. Verify that you can create a vendor and that you are then redirected to the list of vendors Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182875|0 |1 is obsolete| | --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 184293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184293&action=edit Bug 39980: Add tests for .../acquisition/vendors* in Mojo context Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- Fixed the tidiness but tests pass for me. Can you take another look Marcel ? I believe get_session() without params is not supposed to fail unless there is a problem with the session storage itself -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Julian Maurice from comment #13)
Fixed the tidiness but tests pass for me. Can you take another look Marcel ? I believe get_session() without params is not supposed to fail unless there is a problem with the session storage itself
Still fails with me. Also tried: t::lib::Mocks::mock_preference( 'SessionStorage', 'tmp' ); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186452&action=edit Bug 39980: Add Test::NoWarnings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@gmail.com --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- All good for me, can you add the license and POD back in the module please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 --- Comment #17 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 186475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186475&action=edit Bug 39980: Add license and POD to Koha::App::Controller::CGI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #18 from Julian Maurice <julian.maurice@biblibre.com> --- QA script is happy now. Changing status back to signed off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184292|0 |1 is obsolete| | Attachment #184293|0 |1 is obsolete| | Attachment #186452|0 |1 is obsolete| | Attachment #186475|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186482&action=edit Bug 39980: Fix vendors pages when using Koha as a Mojo app Bug 38010 broke the vendors pages when Koha is running as a Mojolicious application This adds new routes to Koha::App::Intranet to mimic the Apache rewrite rules added in bug 38010. To be able to do that, the CGIBinKoha plugin's code had to be moved to a controller. The logic remains the same. Test plan: 1. Run `bin/intranet daemon -l http://*:3000/` 2. Point your browser to http://localhost:3000 (replace localhost by the hostname/IP of koha's container, if needed) 3. Go to Acquisitions and search for a vendor. You should see the list of vendors. 4. Click on "New vendor" button. Notice the URL changed to .../acquisition/vendors/add. 5. Reload the page. You should still see the form to create a new vendor 6. Verify that you can create a vendor and that you are then redirected to the list of vendors Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186483&action=edit Bug 39980: Add tests for .../acquisition/vendors* in Mojo context Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 --- Comment #21 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186484&action=edit Bug 39980: Add Test::NoWarnings Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 --- Comment #22 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186485&action=edit Bug 39980: Add license and POD to Koha::App::Controller::CGI Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 --- Comment #23 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 --- Comment #24 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #25 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 38010 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #26 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org