[Bug 31378] New: Add a generic OAuth2/OIDC client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Bug ID: 31378 Summary: Add a generic OAuth2/OIDC client implementation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org We need a generic client implementation that allows setting different authentication services and configurations. It needs to: - work for the - work for the staff interface - have a CRUD page for dealing with authentication services - be designed so we eventually move other authentication mechanisms into this CRUD (e.g. CAS? LDAP?) - allow setting configurations per-service and per-domain (i.e. an OIDC service might allow authenticating several (campus?) domains and we should handle that). - provide a prettier integration with the login form than CAS and friends Follow-ups: - Prioritize IdP's when displaying login options - Icon / user-oriented presentation Not all of this needs to be implemented on this bug report. Should be splitted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30988 Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |agustinmoyano@theke.io |ity.org | CC| |joy@bywatersolutions.com, | |nick@bywatersolutions.com, | |nugged@gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Forgot to mention (and is very important): - Implementation should use a library to handle OAuth2 (as opposed to the current googleopenidconnect script, which does things manually). Mojolicious::Plugin::OAuth2 is already packaged in the staging repo for this purpose (mtj++) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au, | |hagud@orex.es -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- +1 Here for authoring, testing, or QAing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu, | |uwe.dierolf@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8993 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Carl <ctodd@hcc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ctodd@hcc.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141362&action=edit Bug 31378: DB changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141363&action=edit Bug 31378: DBIC updates [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141364&action=edit Bug 31378: Add dependencies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141365&action=edit Bug 31378: Add Koha::Auth::Provider::Domain(s) class(es) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141366&action=edit Bug 31378: Add Koha::Auth::Provider(s) class(es) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141367&action=edit Bug 31378: Add Koha::Auth::Client* modules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141368&action=edit Bug 31378: Add Auth mojo plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141369&action=edit Bug 31378: Add API routes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141370&action=edit Bug 31378: Add auth providers template plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141371&action=edit Bug 31378: Add the API-based auth mechanism to C4::Auth::check_api_auth -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141372&action=edit Bug 31378: Add OPAC support for authentication providers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141373&action=edit Bug 31378: Add STAFF support for authentication providers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141374&action=edit Bug 31378: Add accessor methods for JSON attributes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141375&action=edit Bug 31378: Add manage_authentication_providers permission Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141376&action=edit Bug 31378: Add 'parameter' parameter to Koha::Exceptions::MissingParameter Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141377&action=edit Bug 31378: Add authentication provider endpoints This patch adds routes for handling authentication providers to the REST API. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_providers.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141378&action=edit Bug 31378: Add an administration interface for authentication sources -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Notes for testing: KTD (master) comes with the koha-staging repo already configured, so in order to test this patches you can just run: $ apt install libmojolicious-plugin-oauth2-perl After installing the dependency, you need to restart Plack (as usual): $ koha-plack --restart kohadev The OAuth2 Mojolicious plugin is feeded with the configured authentication providers at (plack) startup time, so in order for new providers to be picked, restart Plack, just to be sure. Enjoy, provide any constructive comments you can, early. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I just noticed that you need to run the database update for Koha to work. Not sure if this could cause problem with the web installer. Error while loading /etc/koha/sites/kohadev/plack.psgi: Can't load application from file "/kohadevbox/koha/api/v1/app.pl": DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Table 'koha_kohadev.auth_providers' doesn't exist at /kohadevbox/koha/Koha/Objects.pm line 312 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 141514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141514&action=edit Bug 31378: Use base URLs for redirect uri -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Lukas Koszyk <lukasz.koszyk@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lukasz.koszyk@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #23 from David Cook <dcook@prosentient.com.au> --- Are there test plans for the UIs? I'm keen to test this out (although might be worth saving my SO for the QA stage). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141362|0 |1 is obsolete| | --- Comment #24 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 141771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141771&action=edit Bug 31378: DB changes Signed-off-by: Katrin <me@myemail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141363|0 |1 is obsolete| | --- Comment #25 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 141772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141772&action=edit Bug 31378: DBIC updates [DO NOT PUSH] Signed-off-by: Katrin <me@myemail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141364|0 |1 is obsolete| | --- Comment #26 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 141773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141773&action=edit Bug 31378: Add dependencies Signed-off-by: Katrin <me@myemail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141365|0 |1 is obsolete| | --- Comment #27 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 141774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141774&action=edit Bug 31378: Add Koha::Auth::Provider::Domain(s) class(es) Signed-off-by: Katrin <me@myemail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141366|0 |1 is obsolete| | --- Comment #28 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 141775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141775&action=edit Bug 31378: Add Koha::Auth::Provider(s) class(es) Signed-off-by: Katrin <me@myemail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141367|0 |1 is obsolete| | --- Comment #29 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 141776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141776&action=edit Bug 31378: Add Koha::Auth::Client* modules Signed-off-by: Katrin <me@myemail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141368|0 |1 is obsolete| | --- Comment #30 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 141777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141777&action=edit Bug 31378: Add Auth mojo plugin Signed-off-by: Katrin <me@myemail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141369|0 |1 is obsolete| | --- Comment #31 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 141778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141778&action=edit Bug 31378: Add API routes Signed-off-by: Katrin <me@myemail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141370|0 |1 is obsolete| | --- Comment #32 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 141779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141779&action=edit Bug 31378: Add auth providers template plugin Signed-off-by: Katrin <me@myemail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141371|0 |1 is obsolete| | --- Comment #33 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 141780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141780&action=edit Bug 31378: Add the API-based auth mechanism to C4::Auth::check_api_auth Signed-off-by: Katrin <me@myemail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141372|0 |1 is obsolete| | --- Comment #34 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 141781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141781&action=edit Bug 31378: Add OPAC support for authentication providers Signed-off-by: Katrin <me@myemail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141373|0 |1 is obsolete| | --- Comment #35 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 141782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141782&action=edit Bug 31378: Add STAFF support for authentication providers Signed-off-by: Katrin <me@myemail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141374|0 |1 is obsolete| | --- Comment #36 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 141783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141783&action=edit Bug 31378: Add accessor methods for JSON attributes Signed-off-by: Katrin <me@myemail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141375|0 |1 is obsolete| | --- Comment #37 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 141784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141784&action=edit Bug 31378: Add manage_authentication_providers permission Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin <me@myemail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141376|0 |1 is obsolete| | --- Comment #38 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 141785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141785&action=edit Bug 31378: Add 'parameter' parameter to Koha::Exceptions::MissingParameter Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin <me@myemail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141377|0 |1 is obsolete| | --- Comment #39 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 141786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141786&action=edit Bug 31378: Add authentication provider endpoints This patch adds routes for handling authentication providers to the REST API. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_providers.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Katrin <me@myemail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141378|0 |1 is obsolete| | --- Comment #40 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 141787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141787&action=edit Bug 31378: Add an administration interface for authentication sources Signed-off-by: Katrin <me@myemail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141514|0 |1 is obsolete| | --- Comment #41 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 141788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141788&action=edit Bug 31378: Use base URLs for redirect uri Signed-off-by: Katrin <me@myemail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Was not me, but the sandbox was created in my name. We'll fix sign-off lines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141771|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141801&action=edit Bug 31378: DB changes Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141772|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141802&action=edit Bug 31378: DBIC updates [DO NOT PUSH] Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141773|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141803&action=edit Bug 31378: Add dependencies Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141774|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141804&action=edit Bug 31378: Add Koha::Auth::Provider::Domain(s) class(es) Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141775|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141805&action=edit Bug 31378: Add Koha::Auth::Provider(s) class(es) Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141776|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141806&action=edit Bug 31378: Add Koha::Auth::Client* modules Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141777|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141807&action=edit Bug 31378: Add Auth mojo plugin Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141778|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141808&action=edit Bug 31378: Add API routes Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141779|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141809&action=edit Bug 31378: Add auth providers template plugin Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141780|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141810&action=edit Bug 31378: Add the API-based auth mechanism to C4::Auth::check_api_auth Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141781|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141811&action=edit Bug 31378: Add OPAC support for authentication providers Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141782|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141812&action=edit Bug 31378: Add STAFF support for authentication providers Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141783|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141813&action=edit Bug 31378: Add accessor methods for JSON attributes Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141784|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141814&action=edit Bug 31378: Add manage_authentication_providers permission Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141785|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141815&action=edit Bug 31378: Add 'parameter' parameter to Koha::Exceptions::MissingParameter Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141786|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141816&action=edit Bug 31378: Add authentication provider endpoints This patch adds routes for handling authentication providers to the REST API. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_providers.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141787|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141817&action=edit Bug 31378: Add an administration interface for authentication sources Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141788|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141818&action=edit Bug 31378: Use base URLs for redirect uri Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #61 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Just fixing up signoff lines.. I think David offered to QA this so I'll set him as assigned for it :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #62 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #21)
I just noticed that you need to run the database update for Koha to work. Not sure if this could cause problem with the web installer.
Error while loading /etc/koha/sites/kohadev/plack.psgi: Can't load application from file "/kohadevbox/koha/api/v1/app.pl": DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Table 'koha_kohadev.auth_providers' doesn't exist at /kohadevbox/koha/Koha/Objects.pm line 312
This is certainly an issue. I'm looking at follow-ups... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #63 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize from comment #58)
To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_providers.t => SUCCESS: Tests pass! 3. Sign off :-D
Looks like the unit test file is t/db_dependent/Koha/Auth/Provider.t these days. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #64 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Cook from comment #62)
(In reply to Katrin Fischer from comment #21)
I just noticed that you need to run the database update for Koha to work. Not sure if this could cause problem with the web installer.
Error while loading /etc/koha/sites/kohadev/plack.psgi: Can't load application from file "/kohadevbox/koha/api/v1/app.pl": DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Table 'koha_kohadev.auth_providers' doesn't exist at /kohadevbox/koha/Koha/Objects.pm line 312
This is certainly an issue. I'm looking at follow-ups...
I think the old GoogleOpenId... stuff removal is to blame, as we decided to defer it. Will look tomorrow morning -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #65 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Cook from comment #63)
(In reply to Martin Renvoize from comment #58)
To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_providers.t => SUCCESS: Tests pass! 3. Sign off :-D
Looks like the unit test file is t/db_dependent/Koha/Auth/Provider.t these days.
There should be tests for the providers CRUD in there as well. git diff origin/master --name-only -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #66 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Cook from comment #62)
(In reply to Katrin Fischer from comment #21)
I just noticed that you need to run the database update for Koha to work. Not sure if this could cause problem with the web installer.
Error while loading /etc/koha/sites/kohadev/plack.psgi: Can't load application from file "/kohadevbox/koha/api/v1/app.pl": DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Table 'koha_kohadev.auth_providers' doesn't exist at /kohadevbox/koha/Koha/Objects.pm line 312
This is certainly an issue. I'm looking at follow-ups...
Please comment about the code, propose things and stuff so this shines for the release. Follow-ups will come out of course. Thanks for your time! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #67 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #66)
Please comment about the code, propose things and stuff so this shines for the release. Follow-ups will come out of course. Thanks for your time!
I've spent the last few hours working on this one, and have a ton of feedback. Hopefully all pretty easy to fix I think... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #68 from David Cook <dcook@prosentient.com.au> --- I'll shortly add a follow-up to catch the error of the missing database update. In theory, with a package install, the database will be automatically upgraded before the web app is started up. But some people will still need to use the web installer, so we don't want it to fail. (Those people will need to restart their Koha before they're able to use the new auth functionality of course.) Test plan 1: 1. apt install libmojolicious-plugin-oauth2-perl 2. restart_all 3. koha-upgrade-schema kohadev 4. koha-plack --restart kohadev 5. prove t/db_dependent/Koha/Auth/Provider.t So far so good. Test plan 2: 1. Go to http://localhost:8081/cgi-bin/koha/admin/admin-home.pl 2. Click on "Authentication providers" (#NOTE: I would've preferred "Identity Providers" since that's a more common industry term.) 3. Click "New authentication provider" (#NOTE: The UI looks poorly formatted, but I think that's probably a symptom of the new staff interface styling. Not a blocker for me. This can be fixed later...) (#NOTE: There is a bug with the "Configuration" where "Add new X configuration" doesn't work if you've manually changed anything in the text box. Not a blocker for me, but will need to be fixed at some point. Same goes for "Add default OIDC mapping.) (#NOTE: There's not enough documentation/help text on how to use this UI. I'm figuring it out through trial and error, but a bit of help text for "Code", "Description", and "Icon URL" at a minimum would be good.) (#NOTE: With the new Staff Interface, there should be a "Help" link on the right hand side, but I don't see it for this new functionality. I think that's a blocker.) (#NOTE: I don't really like having to include raw JSON in this UI. This could be made more beautiful.) (#NOTE: "Code" doesn't appear to be restricted or validated in any way. We should stick to alphanumeric codes. This is borderline... but I think it's a blocker. We need to set the rule before people start using it.) (#NOTE: We need to add help text at the bottom of this page that says this auth provider won't be available until after a Koha restart.) 4. Click on "Manage Domains" 5. Click "Edit" for first and only line (#NOTE: It's not clear what a "Domain" is in this context. This needs more help text/documentation. I'd say that's a blocker. From past code review in Koha for OIDC, "Domain" referred to email domain. That really should spelled out clearly. ) 6. The breadcrumb doesn't show the auth provider code on the "Edit authentication provider domain" like it does on the "Authentication provider domains" page 4. koha-plack --restart kohadev (#NOTE: This is an unfortunate step but necessary because of the plugin being used. Auth providers are rarely set up, so not a big drama.) 4. In an Incognito tab or different browser, go to http://localhost:8081/ (#NOTE: In my opinion, we should *not* be allowing staff login by default. While "Auto register" is "Don't allow" by default, we should keep the staff interface as locked down as possible. Not a blocker but an observation...) 5. When I try to login with Keycloak, I get the following error in Koha: [{"message":"Malformed query string","path":"\/query\/session_state"}] (#NOTE: Newer OIDC providers will provide session_state in the authentication response. I'll turn this off in Keycloak. Folks can read more about session_state at https://openid.net/specs/openid-connect-session-1_0.html) 6. Now I'm getting this error on the Koha Staff Interface login page (since the user doesn't exist in Koha and I have auto-register turned off): There was an error authenticating to external identity provider Exception 'Koha::Exceptions::Auth::Unauthorized' thrown 'External auth user cannot access resource' with code => 401 (#NOTE: I don't think printing the exception on the staff interface is a good idea. Let's remove that.) 7. After adding my user to Koha and giving staff permissions, I'm able to log in. Very nice! 8. Go to http://localhost:8080/ and click "Log in with Keycloak IdP" 9. Since I already have a session in Keycloak, I'm logged into the OPAC with no login. Very good! 10. If I logout of Keycloak and try to log back into http://localhost:8080/ via Keycloak, I get the following: There was an error authenticating to external identity provider Can't call method "auto_register" on an undefined value at /kohadevbox/koha/Koha/REST/Plugin/Auth.pm line 66. (#NOTE: In the code I see "tranverse_hash" but it should be "traverse_hash" in English.) 11. Turn on auto register for all blank domain... 12. restart_all in ktd 13. Try to log into OPAC and Staff Interface 14. Neither works... (#NOTE: In Koha/REST/Plugin/Auth.pm, it looks like auto-register should only work for OPAC. In theory, I like that, although I suppose the workaround would be to auto-register for the OPAC, and then your account would exist for the Staff Interface anyway...) 15. I tried "Update on login" using the blank domain and a domain of "prosentient.com.au" and both failed to update my firstname and surname on login. That's a blocker... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #69 from David Cook <dcook@prosentient.com.au> --- Here is the TL;DR version: Question: 1. I noticed that the default "Mapping configuration" is just 1-to-1 for strings, but Oauth/OIDC claims can be complex data structures. How do you handle when the claim is an array or an object? The most common one I see in the real world is the "address" object, but there are others too. Looking at Koha/Auth/Client/OAuth.pm and Koha/Auth/Client.pm, I think that you have added code for this. Would it be "address.street_address" in the Mapping to get the "street_address" value out of the "address" claim? The code is uncommented and a bit obscure, so I can't tell if you can handle array values, although I'm less worried about them. Can you? TODO: 0. Add missing "Help" link to all new pages 1. Restrict "Code" to alphanumeric code 2. Add help text to "New authentication provider" UI 3. Add help text to "Edit authentication provider domain" UI 4. Fix breadcrumb on "Edit authentication provider domain" UI 5. Remove exception text from Koha staff interface login page 6. Remove exception text from Koha OPAC login page 7. Think about changing "tranverse_hash" to "traverse_hash" 8. Fix "Auto register" 9. Fix "Update on login" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #70 from David Cook <dcook@prosentient.com.au> --- Created attachment 141853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141853&action=edit Bug 31378: (follow-up) catch startup error when missing Oauth provider table In theory, this shouldn't come up with a package install, but it could happen with other installations, so best to let it get to the web installer. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #71 from David Cook <dcook@prosentient.com.au> --- QA tool complaints: FAIL Koha/Auth/Client/OAuth.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 FAIL Koha/Auth/Provider/Domain.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 FAIL Koha/Exceptions/Auth.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 FAIL Koha/REST/Plugin/Auth.pm FAIL pod coverage POD is missing for 'register' FAIL Koha/Schema/Result/AuthProvider.pm FAIL pod coverage POD is missing for koha_object_class POD is missing for koha_objects_class FAIL Koha/Schema/Result/AuthProviderDomain.pm FAIL pod coverage POD is missing for koha_object_class POD is missing for koha_objects_class FAIL admin/authentication_providers.pl FAIL file permissions File must have the exec flag FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/authentication_providers.tt FAIL forbidden patterns forbidden pattern: simple-quote string (line 407) forbidden pattern: tab char (line 427) forbidden pattern: tab char (line 442) forbidden pattern: simple-quote string (line 449) forbidden pattern: simple-quote string (line 450) forbidden pattern: simple-quote string (line 456) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt FAIL valid_template DBIx::Class::Schema::source(): Can't find source for AuthProvider at /kohadevbox/koha/Koha/Objects.pm line 524 FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc FAIL valid_template DBIx::Class::Schema::source(): Can't find source for AuthProvider at /kohadevbox/koha/Koha/Objects.pm line 524 FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt FAIL valid_template DBIx::Class::Schema::source(): Can't find source for AuthProvider at /kohadevbox/koha/Koha/Objects.pm line 524 FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt FAIL valid_template DBIx::Class::Schema::source(): Can't find source for AuthProvider at /kohadevbox/koha/Koha/Objects.pm line 524 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #72 from David Cook <dcook@prosentient.com.au> --- At line 407 of koha-tmpl/intranet-tmpl/prog/en/modules/admin/authentication_providers.tt, "Not a valid JSON" should be "Not valid JSON" since JSON refers to the format and not the data itself. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #73 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #65)
There should be tests for the providers CRUD in there as well.
git diff origin/master --name-only
Not that I can see. Just t/db_dependent/Koha/Auth/Provider.t Maybe there are some missing patches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #74 from David Cook <dcook@prosentient.com.au> --- Another problem: If you have a "blank" domain and a specific domain, the "blank" domain is used instead of the specific domain. If you want to set different "Default library" and "Default category" based on email domain, it won't work if you have a "blank" domain. It also means the "Auto register" and "Update on login" wouldn't work right... if they were working... I think the only thing that does work is having "Allow staff: No" in "blank" domain and "Allow staff: Yes" in specific domain. ("Allow opac: no" for "blank" would also work but that would be an unlikely scenario.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #75 from David Cook <dcook@prosentient.com.au> --- One last thing: the styling on the login buttons on the Staff Interface and OPAC have little to no contrast which is hard on the eyes. It also makes the Staff Interface buttons look strange when you have multiple providers with descriptions of different lengths. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #76 from David Cook <dcook@prosentient.com.au> --- One last last thing: It would be good to have a "Sequence" value for the providers, so that you could arrange them on the Staff Interface and OPAC in a desired order rather than the order that they were added to Koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #77 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Cook from comment #62)
(In reply to Katrin Fischer from comment #21)
I just noticed that you need to run the database update for Koha to work. Not sure if this could cause problem with the web installer.
Error while loading /etc/koha/sites/kohadev/plack.psgi: Can't load application from file "/kohadevbox/koha/api/v1/app.pl": DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Table 'koha_kohadev.auth_providers' doesn't exist at /kohadevbox/koha/Koha/Objects.pm line 312
This is certainly an issue. I'm looking at follow-ups...
Thx David :) Read your comment below and I think it describes the problem well, package installations being probably ok, but others could get trapped with the web installer not coming up to tell them about the missing package. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #78 from Agustín Moyano <agustinmoyano@theke.io> --- Hi everyone, it's been a long time since I wrote to you! Thanks so much David for so extensive testing.. I'll try to address as much points as possible. (In reply to David Cook from comment #68)
(#NOTE: I would've preferred "Identity Providers" since that's a more common industry term.)
Nice point. I'll talk to Tomas if we change it
(#NOTE: The UI looks poorly formatted, but I think that's probably a symptom of the new staff interface styling. Not a blocker for me. This can be fixed later...)
Sorry, it's been a long time since I've done anything related to Koha.. If you could point me to a well formated page, I'll try to stick to the style as much as possible
(#NOTE: There is a bug with the "Configuration" where "Add new X configuration" doesn't work if you've manually changed anything in the text box. Not a blocker for me, but will need to be fixed at some point. Same goes for "Add default OIDC mapping.)
I do not believe this patches are at the latest version.. I've added a jquery-validator to check if your jsons are valid before saving. I imagine this is a patch for now, and we need a way to edit a json in a proper way
(#NOTE: There's not enough documentation/help text on how to use this UI.
Yes, I've been coding this between jobs so I had no time to document, but surely we will add some follow-ups.
I'm figuring it out through trial and error, but a bit of help text for "Code", "Description", and "Icon URL" at a minimum would be good.)
Code should be a unique name for your Identity Provider, the Description is the text that will appear in the login button, and Icon URL should be a URL where we can fetch an icon for login button
(#NOTE: With the new Staff Interface, there should be a "Help" link on the right hand side, but I don't see it for this new functionality. I think that's a blocker.)
Ok, I'll ask Tomas for help about how this shoul be done
(#NOTE: I don't really like having to include raw JSON in this UI. This could be made more beautiful.)
Me neither, there should be a JSON editor or something.. does Koha have one?
(#NOTE: "Code" doesn't appear to be restricted or validated in any way. We should stick to alphanumeric codes. This is borderline... but I think it's a blocker. We need to set the rule before people start using it.)
Good point. Will be done
(#NOTE: We need to add help text at the bottom of this page that says this auth provider won't be available until after a Koha restart.)
Yes, but we have plans to make it so that you wont need to restart Koha for the provider to be available (a PR to Mojolicious::Plugin::OAuth2 project)
4. Click on "Manage Domains" 5. Click "Edit" for first and only line (#NOTE: It's not clear what a "Domain" is in this context. This needs more help text/documentation. I'd say that's a blocker. From past code review in Koha for OIDC, "Domain" referred to email domain. That really should spelled out clearly. )
Agree. Domain in this case is, as you said, email domain.
6. The breadcrumb doesn't show the auth provider code on the "Edit authentication provider domain" like it does on the "Authentication provider domains" page
I'll check it
4. koha-plack --restart kohadev (#NOTE: This is an unfortunate step but necessary because of the plugin being used. Auth providers are rarely set up, so not a big drama.)
4. In an Incognito tab or different browser, go to http://localhost:8081/ (#NOTE: In my opinion, we should *not* be allowing staff login by default. While "Auto register" is "Don't allow" by default, we should keep the staff interface as locked down as possible. Not a blocker but an observation...)
Ok, that's easily done
5. When I try to login with Keycloak, I get the following error in Koha: [{"message":"Malformed query string","path":"\/query\/session_state"}] (#NOTE: Newer OIDC providers will provide session_state in the authentication response. I'll turn this off in Keycloak. Folks can read more about session_state at https://openid.net/specs/openid-connect-session-1_0.html)
6. Now I'm getting this error on the Koha Staff Interface login page (since the user doesn't exist in Koha and I have auto-register turned off): There was an error authenticating to external identity provider Exception 'Koha::Exceptions::Auth::Unauthorized' thrown 'External auth user cannot access resource' with code => 401 (#NOTE: I don't think printing the exception on the staff interface is a good idea. Let's remove that.)
As I said, I do not believe these patches to be at the latest version.. now the user gets redirected to the login page (staff or opac) with error message
7. After adding my user to Koha and giving staff permissions, I'm able to log in. Very nice!
8. Go to http://localhost:8080/ and click "Log in with Keycloak IdP" 9. Since I already have a session in Keycloak, I'm logged into the OPAC with no login. Very good!
10. If I logout of Keycloak and try to log back into http://localhost:8080/ via Keycloak, I get the following: There was an error authenticating to external identity provider Can't call method "auto_register" on an undefined value at /kohadevbox/koha/Koha/REST/Plugin/Auth.pm line 66.
Strange, I'll have to check that out
(#NOTE: In the code I see "tranverse_hash" but it should be "traverse_hash" in English.)
typo... sorry
11. Turn on auto register for all blank domain... 12. restart_all in ktd 13. Try to log into OPAC and Staff Interface 14. Neither works... (#NOTE: In Koha/REST/Plugin/Auth.pm, it looks like auto-register should only work for OPAC. In theory, I like that, although I suppose the workaround would be to auto-register for the OPAC, and then your account would exist for the Staff Interface anyway...)
15. I tried "Update on login" using the blank domain and a domain of "prosentient.com.au" and both failed to update my firstname and surname on login. That's a blocker...
Yep, I think I forgot to code that part Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #79 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to David Cook from comment #74)
Another problem:
If you have a "blank" domain and a specific domain, the "blank" domain is used instead of the specific domain.
Strange, the behavior should be the opposite. The logic was that you could define multiple domains (even partially) and the domain with the longest matching text should win. If there was no matching domain, then go with the default.
If you want to set different "Default library" and "Default category" based on email domain, it won't work if you have a "blank" domain.
Maybe I've done something wrong with the regexp, and if the email domain doesn't match, you won't see that "default library" and "default category" configured for the domain
It also means the "Auto register" and "Update on login" wouldn't work right... if they were working...
I've fixed auto register in latest patches, but for it to work, you need to define userid or cardnumber in the mapper.
I think the only thing that does work is having "Allow staff: No" in "blank" domain and "Allow staff: Yes" in specific domain. ("Allow opac: no" for "blank" would also work but that would be an unlikely scenario.)
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #80 from David Cook <dcook@prosentient.com.au> --- (In reply to Agustín Moyano from comment #78)
(#NOTE: The UI looks poorly formatted, but I think that's probably a symptom of the new staff interface styling. Not a blocker for me. This can be fixed later...)
Sorry, it's been a long time since I've done anything related to Koha.. If you could point me to a well formated page, I'll try to stick to the style as much as possible
I'm not familiar with the new staff UI myself, but I think you'll be able to see what I mean at a glance. On CRUD pages, the labels and fields aren't aligned correctly in all cases at the moment.
(#NOTE: With the new Staff Interface, there should be a "Help" link on the right hand side, but I don't see it for this new functionality. I think that's a blocker.)
Ok, I'll ask Tomas for help about how this shoul be done
Sounds good. I think it might involve the Koha/Manual.pm file. (I just noticed it on a different issue report earlier today.)
(#NOTE: I don't really like having to include raw JSON in this UI. This could be made more beautiful.)
Me neither, there should be a JSON editor or something.. does Koha have one?
Not that I know of. Rather, I meant it would make sense to just have a regular HTML form and translate that into JSON on the backend.
As I said, I do not believe these patches to be at the latest version.. now the user gets redirected to the login page (staff or opac) with error message
Looking forward to testing the next round!
10. If I logout of Keycloak and try to log back into http://localhost:8080/ via Keycloak, I get the following: There was an error authenticating to external identity provider Can't call method "auto_register" on an undefined value at /kohadevbox/koha/Koha/REST/Plugin/Auth.pm line 66.
Strange, I'll have to check that out
I wasn't able to reproduce it again so might've just been a bit glitchy due to restarts/Keycloak logouts/etc. Might not need to worry about it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #81 from David Cook <dcook@prosentient.com.au> --- (In reply to Agustín Moyano from comment #79)
If you have a "blank" domain and a specific domain, the "blank" domain is used instead of the specific domain.
Strange, the behavior should be the opposite. The logic was that you could define multiple domains (even partially) and the domain with the longest matching text should win. If there was no matching domain, then go with the default.
Worth double-checking that one I reckon.
If you want to set different "Default library" and "Default category" based on email domain, it won't work if you have a "blank" domain.
Maybe I've done something wrong with the regexp, and if the email domain doesn't match, you won't see that "default library" and "default category" configured for the domain
How is the domain supposed to be configured? Perhaps I wasn't inputting it as expected either?
I've fixed auto register in latest patches, but for it to work, you need to define userid or cardnumber in the mapper.
You'll definitely need to indicate that on the UI pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #82 from David Cook <dcook@prosentient.com.au> --- Looks like "soft" feature freeze is Oct 28, so if you can get the updates patches up ASAP, I'll make time for QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31851 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31851 [Bug 31851] Allow prioritizing identity providers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #83 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- For the missing help link the last patch on bug 31162 might be interesting. I also noticed the help missing there and it was due to changes to the page structure with the new staff design. For the JSON editor: Maybe CodeMirror that we use for SQL and YAML can do it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31900 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31900 [Bug 31900] Add support for logout from external OAuth2/OIDC identity providers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #84 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #83)
For the missing help link the last patch on bug 31162 might be interesting. I also noticed the help missing there and it was due to changes to the page structure with the new staff design.
For the JSON editor: Maybe CodeMirror that we use for SQL and YAML can do it?
I felt like using the CodeMirror plugin would be enough. Maybe we should make the 'Create' button be a dropdown instead, for choosing the protocol, and make the form be already pre-populated, so we remove the buttons too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #85 from David Cook <dcook@prosentient.com.au> --- I'm not too worried about the JSON editor at this point. More of a nice to have but not essential. Agustin, are we going to get an updated version before the end of this week? I could make time to QA this before the soft feature freeze this Friday. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31965 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #86 from Aleisha Amohia <aleisha@catalyst.net.nz> --- *** Bug 31965 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #87 from David Cook <dcook@prosentient.com.au> --- Comment on attachment 141807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141807 Bug 31378: Add Auth mojo plugin Review of attachment 141807: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=31378&attachment=141807) ----------------------------------------------------------------- ::: Koha/REST/Plugin/Auth.pm @@ +83,5 @@
+ 'auth.session' => sub { + my ( $c, $patron ) = @_; + my $userid = $patron->userid; + my $cardnumber = $patron->cardnumber; + my $cgi = CGI->new;
I don't think that we should be using the CGI module in the Mojolicious REST API, since we're not using CGI. This is hacky. @@ +89,5 @@
+ $cgi->param( userid => $userid ); + $cgi->param( cardnumber => $cardnumber ); + $cgi->param( auth_client_login => 1 ); + + my ( $status, $cookie, $session_id ) = C4::Auth::check_api_auth($cgi);
This is a suboptimal design for at least a couple of reasons: 1) it requires a CGI object; 2) it creates a session for the API interface rather than the OPAC/Staff interfaces; 3) it's not to purpose - we're not checking auth. We know that we're just creating a new session. I've been saying for years that we need to standardize session creation, and it's still true. In the meantime, a minimal session can be created as simply as this: $session->param( 'number', $patron->borrowernumber ); $session->param( 'id', $patron->userid ); $session->param( 'cardnumber', $patron->cardnumber ); $session->param( 'firstname', $patron->firstname ); $session->param( 'surname', $patron->surname ); $session->param( 'branch', $patron->branchcode ); $session->param( 'branchname', $patron->library->branchname ); $session->param( 'flags', $patron->flags ); $session->param( 'emailaddress', $patron->email ); $session->param( 'ip', $session->remote_addr() ); $session->param( 'lasttime', time() ); $session->param( 'interface', $type); Then you can either pass the $session object or the session ID as the return value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #88 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #87)
I've been saying for years that we need to standardize session creation, and it's still true.
Recently, I did a little patch for that at Bug 31050, but I haven't had an urgent reason to continue on it. It would be perfect for a situation like this though. (Of course, I thought of it while working on Koha plugins, other auth solutions, etc.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #89 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Hi all, a couple follow-ups have been pushed to the branch and are ready for testing. We couldn't make some new tests we attempted to write for login work. It would be great to have them, but not sure if required. Why help there is welcome. We ran out of fuel yesterday -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #90 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The branch doesn't seem to be linked, can you please remind us where to find the updated patches? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/thekesol | |utions/Koha/-/commits/oauth | |_client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #91 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Is this the link? https://gitlab.com/thekesolutions/Koha/-/commits/oauth_client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #92 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Aleisha Amohia from comment #91)
Is this the link? https://gitlab.com/thekesolutions/Koha/-/commits/oauth_client
Hi Aleisha, Tomas added it to the URL field after my last comment, it matches with yours. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #93 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #89)
Hi all, a couple follow-ups have been pushed to the branch and are ready for testing. We couldn't make some new tests we attempted to write for login work.
It would be great to have them, but not sure if required. Why help there is welcome. We ran out of fuel yesterday
Does this mean that the tests are failing and you'd like help to fix the tests? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #94 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Cook from comment #93)
(In reply to Tomás Cohen Arazi from comment #89)
Hi all, a couple follow-ups have been pushed to the branch and are ready for testing. We couldn't make some new tests we attempted to write for login work.
It would be great to have them, but not sure if required. Why help there is welcome. We ran out of fuel yesterday
Does this mean that the tests are failing and you'd like help to fix the tests?
It means an attempt from Agustín to write login tests didn't go well. We're can live without those. I'd like you to test that branch, which solves things that were reported, including a rename. That branch probably needs a tidy, I haven't checked that last commit (before the tests). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #95 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #94)
It means an attempt from Agustín to write login tests didn't go well. We're can live without those.
Ok I think I understand. I won't worry too much about failing tests for this go around then.
I'd like you to test that branch, which solves things that were reported, including a rename. That branch probably needs a tidy, I haven't checked that last commit (before the tests).
The follow up commits seem to be a mix of the tests and core code changes, so those would need to be re-organised before QAing and pushing I think. -- I suppose Aleisha or myself could QA, so I suppose either of us could sign off. I'll have a look in any case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #96 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Just skip the last commit (wip trying to add tests). I noticed we need to redo Nick's and your patches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #97 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #96)
Just skip the last commit (wip trying to add tests).
I noticed we need to redo Nick's and your patches
It looks like the last commit includes some updates besides tests though despite the commit name? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #98 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Cook from comment #97)
It looks like the last commit includes some updates besides tests though despite the commit name?
Skip the tests themselves, unless you really want to look at them -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #99 from David Cook <dcook@prosentient.com.au> --- Ok. Starting testing now... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #100 from David Cook <dcook@prosentient.com.au> --- Looks like we're 547 commits behind master... and for some reason "qa" think the "qa-prev-commit" is 1 commit behind. Getting a number of failures: testing 1 commit(s) (applied to 46c299f 'd6 Bug 31378: Rename Auth Provider to') Processing files before patches Configure idp routes=====>| 10 / 10 (100.00%) Processing files after patches |========================>| 10 / 10 (100.00%) OK Koha/Auth/Client.pm OK Koha/REST/V1/Auth/Identity/Provider/Domains.pm OK api/v1/swagger/definitions/identity_provider.yaml OK api/v1/swagger/definitions/identity_provider_domain.yaml OK api/v1/swagger/paths/auth.yaml OK installer/data/mysql/atomicupdate/bug_31378.pl OK installer/data/mysql/kohastructure.sql FAIL t/db_dependent/Koha/REST/Plugin/Auth/IdP.t FAIL file permissions File must have the exec flag FAIL forbidden patterns forbidden pattern: trailing space char (line 55) forbidden pattern: trailing space char (line 123) FAIL t/db_dependent/api/v1/idp.t FAIL file permissions File must have the exec flag FAIL forbidden patterns forbidden pattern: trailing space char (line 195) forbidden pattern: trailing space char (line 258) forbidden pattern: trailing space char (line 301) forbidden pattern: Use of Data::Printer (line 310) forbidden pattern: Use of Data::Printer, should only be used for devlopment purpose (line 310) FAIL spelling wiht ==> with wihtout ==> without FAIL valid Can't locate Crypt/OpenSSL/RSA.pm in @INC (you may need to install the Crypt::OpenSSL::RSA module) (@INC contains: /kohadevbox/koha /kohadevbox/koha/lib /kohadevbox/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/ perl/5.32.1 /usr/local/share/perl/5.32.1 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl) FAIL t/lib/IdP/ExternalIdP.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 Processing additional checks * Commit title does not start with 'Bug XXXXX: ' - c649ebc111 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #101 from David Cook <dcook@prosentient.com.au> --- Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc Auto-merging installer/data/mysql/mandatory/userpermissions.sql CONFLICT (content): Merge conflict in installer/data/mysql/mandatory/userpermissions.sql error: could not apply b466baa415... Bug 31378: Add manage_authentication_providers permission Resolve all conflicts manually, mark them as resolved with "git add/rm <conflicted_files>", then run "git rebase --continue". You can instead skip this commit: run "git rebase --skip". To abort and get back to the state before "git rebase", run "git rebase --abort". Could not apply b466baa415... Bug 31378: Add manage_authentication_providers permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #102 from David Cook <dcook@prosentient.com.au> --- Started trying to fix the merge conflicts but looks like there's a fair number. This is something that should've been done before moving it to "Needs Signoff" I reckon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #103 from David Cook <dcook@prosentient.com.au> --- I'll still keep testing to see what I can see though... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA --- Comment #104 from David Cook <dcook@prosentient.com.au> --- Test plan 1: 1. apt install libmojolicious-plugin-oauth2-perl 2. koha-upgrade-schema kohadev 3. restart_all <Note that Nick and David's patches from Bugzilla are still needed for Gitlab branch...> Test plan 2: 1. Go to http://localhost:8081/cgi-bin/koha/admin/admin-home.pl 2. Click on "Identity providers" 3. Click "New identity provider" (#NOTE: UI formatting looks OK on Koha 22.06, but I wonder what it'll look like on Koha 22.11...) (#FIXME: "Add default OAuth..." buttons still don't work if you make any changes in the text box before pressing the button.) (#FIXME: There's still not enough help text on the UI to explain how to fill it all in.) (#NOTE: It probably makes more sense to default to "OIDC" than "OAuth" since the former is more common with common identity providers) 4. Enter relevant details and click "Submit" (#FIXME: "Code" shouldn't be able to contain non-alphanumeric characters) (#FIXME: Putting in garbage values causes the page to return to /cgi-bin/koha/admin/identity_providers.pl with no error messages) (#FIXME: There needs to be a warning that integration won't work until after an application restart...) 5. Click on "Manage Domains" (#FIXME: It's not clear what "domains" means in this context. It should say something like "Identity provider email domains") 6. Click "Edit" on the default domains (#FIXME: The "Default library" and "Default category" are initially set to empty, but you can't set them to empty in the "Edit" interface) (#FIXME: The breadcrumb says "Domains for" instead of "Domains for Test") 7. koha-plack --restart kohadev 8. In an Incognito window or different browser, go to http://localhost:8080, and try logging in with a user that doesn't exist in Koha (#FIXME: When authentication fails, the end user sees the following message: There was an error authenticating to external identity provider Can't call method "auto_register" on an undefined value at /kohadevbox/koha/Koha/REST/Plugin/Auth/IdP.pm line 66. ) 9. Change "Identity provider" default domain to "Auto register" 10. In an Incognito window or different browser, go to http://localhost:8080, and try logging in with a user that doesn't exist in Koha (#FIXME: When authentication fails, the end user sees the following message: There was an error authenticating to external identity provider Can't call method "auto_register" on an undefined value at /kohadevbox/koha/Koha/REST/Plugin/Auth/IdP.pm line 66. ) (#FIXME: The auto register feature doens't work. It needs to be fixed.) 11. Create a Koha user to match your IdP user 12. In an Incognito window or different browser, go to http://localhost:8080, and try logging in with a user that does exist in Koha 13. Login succeeds 14. Kill IdP session and logout of Koha 15. Change default domain to "Update on login" 16. In an Incognito window or different browser, go to http://localhost:8080, and try logging in with a user that does exist in Koha (#FIXME: The update on login feature doesn't work. It needs to be fixed.) 17. Change default domain to "Allow staff" logins 18. In an Incognito window or different browser, go to http://localhost:8080, and try logging in with a user that does exist in Koha 19. Note that you get a normal "Error: You do not have permission to access this page" message. That's good. 20. Add "catalogue" permission to the Koha user 21. In an Incognito window or different browser, go to http://localhost:8080, and try logging in with a user that does exist in Koha 22. Login succeeds 23. In an Incognito window or different browser, go to http://localhost:8081, and try logging in with a user that doesn't exist in Koha (#FIXME: When authentication fails, the end user sees the following message: Error: Session timed out. Please log in again There was an error authenticating to external identity provider Exception 'Koha::Exceptions::Auth::Unauthorized' thrown 'External auth user cannot access resource' with code => 401 ) 24. Add a new domain for that matches the email domain of your IdP/Koha user. 25. Mark "Allow opac" and "Allow staff" as "No" 26. In an Incognito window or different browser, go to http://localhost:8080, and try logging in with a user that does exist in Koha (#FIXME: Koha login happens even though the specific domain says it shouldn't be allowed) 27. In an Incognito window or different browser, go to http://localhost:8081, and try logging in with a user that does exist in Koha (#FIXME: Koha login happens even though the specific domain says it shouldn't be allowed) -- I imagine that there are other problems, but I think that's a fairly thorough analysis of the core functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #105 from David Cook <dcook@prosentient.com.au> --- I appreciate the replacement of "Authentication provider" being changed to "Identity provider" and "tranverse_hash" being changed to "traverse_hash", but it looks like every other issue I described last time is still present in the Gitlab version... I have to fail this again, because several of the features don't work. Before I test this again, I'd like someone to confirm that they've looked at my "FIXME" comments, and fixed them (or at least provide a reason for not fixing them). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #106 from David Cook <dcook@prosentient.com.au> --- Overall, I think that we're on the right track, and I'm so excited for this feature. Thanks for all the work, Theke. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141801|0 |1 is obsolete| | --- Comment #107 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143056&action=edit Bug 31378: DB changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143056|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #108 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to David Cook from comment #105)
I appreciate the replacement of "Authentication provider" being changed to "Identity provider" and "tranverse_hash" being changed to "traverse_hash", but it looks like every other issue I described last time is still present in the Gitlab version...
I have to fail this again, because several of the features don't work.
Before I test this again, I'd like someone to confirm that they've looked at my "FIXME" comments, and fixed them (or at least provide a reason for not fixing them).
Hi David, could you please try again? I've attended to all your valuable FIXME comments in the last patch. Please let me know what you think. Thanks so much! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141802|0 |1 is obsolete| | Attachment #141803|0 |1 is obsolete| | Attachment #141804|0 |1 is obsolete| | Attachment #141805|0 |1 is obsolete| | Attachment #141806|0 |1 is obsolete| | Attachment #141807|0 |1 is obsolete| | Attachment #141808|0 |1 is obsolete| | Attachment #141809|0 |1 is obsolete| | Attachment #141810|0 |1 is obsolete| | Attachment #141811|0 |1 is obsolete| | Attachment #141812|0 |1 is obsolete| | Attachment #141813|0 |1 is obsolete| | Attachment #141814|0 |1 is obsolete| | Attachment #141815|0 |1 is obsolete| | Attachment #141816|0 |1 is obsolete| | Attachment #141817|0 |1 is obsolete| | Attachment #141818|0 |1 is obsolete| | Attachment #141853|0 |1 is obsolete| | --- Comment #109 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143087&action=edit Bug 31378: DB changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #110 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143088&action=edit Bug 31378: DBIC updates [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #111 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143089&action=edit Bug 31378: Add dependencies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #112 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143090&action=edit Bug 31378: Add Koha::Auth::Provider::Domain(s) class(es) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #113 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143091&action=edit Bug 31378: Add Koha::Auth::Provider(s) class(es) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #114 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143092&action=edit Bug 31378: Add Koha::Auth::Client* modules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #115 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143093&action=edit Bug 31378: Add Auth mojo plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #116 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143094&action=edit Bug 31378: Add API routes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #117 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143095&action=edit Bug 31378: Add auth providers template plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #118 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143096&action=edit Bug 31378: Add the API-based auth mechanism to C4::Auth::check_api_auth -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #119 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143097&action=edit Bug 31378: Add OPAC support for authentication providers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #120 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143098&action=edit Bug 31378: Add STAFF support for authentication providers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #121 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143099&action=edit Bug 31378: Add accessor methods for JSON attributes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #122 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143100&action=edit Bug 31378: Add manage_authentication_providers permission Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #123 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143101&action=edit Bug 31378: Add 'parameter' parameter to Koha::Exceptions::MissingParameter Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #124 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143102&action=edit Bug 31378: Add authentication provider endpoints This patch adds routes for handling authentication providers to the REST API. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_providers.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #125 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143103&action=edit Bug 31378: Add an administration interface for authentication sources -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #126 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143104&action=edit Bug 31378: Rename Auth Provider to Identity Provider and add Client.t tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #127 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143105&action=edit Bug 31378: (follow-up) do all FIXME pointed by David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #128 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143106&action=edit Bug 31378: Use base URLs for redirect uri Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #129 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143107&action=edit Bug 31378: (follow-up) catch startup error when missing Oauth provider table In theory, this shouldn't come up with a package install, but it could happen with other installations, so best to let it get to the web installer. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #130 from David Cook <dcook@prosentient.com.au> --- (In reply to Agustín Moyano from comment #108)
Hi David, could you please try again?
I've attended to all your valuable FIXME comments in the last patch.
Please let me know what you think.
Thanks so much!
Thanks, Agustín. I don't have time to thoroughly test it today, and I'm away on Monday, but I'll do a quick glance over it now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #131 from David Cook <dcook@prosentient.com.au> --- First things first...staying in Failed QA due to qa tool failures: -- testing 21 commit(s) (applied to ba01d76 '78 Bug 31713: Fix permissions') Processing files before patches Configure idp routes=====>| 48 / 48 (100.00%) Processing files after patches |========================>| 48 / 48 (100.00%) OK C4/Auth.pm OK Koha/Auth/Client.pm FAIL Koha/Auth/Client/OAuth.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK Koha/Auth/Provider.pm OK Koha/Auth/Provider/Domain.pm OK Koha/Auth/Provider/Domains.pm OK Koha/Auth/Provider/OAuth.pm OK Koha/Auth/Provider/OIDC.pm OK Koha/Auth/Providers.pm OK Koha/Exceptions.pm FAIL Koha/Exceptions/Auth.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK Koha/REST/Plugin/Auth.pm OK Koha/REST/V1.pm OK Koha/REST/V1/Auth/Provider/Domains.pm OK Koha/REST/V1/Auth/Providers.pm OK Koha/REST/V1/OAuth/Client.pm OK Koha/Schema/Result/AuthProvider.pm OK Koha/Schema/Result/AuthProviderDomain.pm OK Koha/Schema/Result/Branch.pm OK Koha/Schema/Result/Category.pm OK Koha/Schema/Result/IdentityProviderDomain.pm OK Koha/Template/Plugin/AuthClient.pm OK admin/authentication_providers.pl OK admin/identity_providers.pl OK api/v1/swagger/definitions/auth_provider.yaml OK api/v1/swagger/definitions/auth_provider_domain.yaml OK api/v1/swagger/paths/auth.yaml OK api/v1/swagger/paths/oauth.yaml OK api/v1/swagger/paths/public_oauth.yaml OK api/v1/swagger/swagger.yaml OK installer/data/mysql/atomicupdate/bug_31378.pl OK installer/data/mysql/kohastructure.sql OK koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc OK koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/authentication_provider_domains.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/authentication_providers.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt FAIL koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt FAIL valid_template DBIx::Class::Schema::source(): Can't find source for IdentityProvider at /kohadevbox/koha/Koha/Objects.pm line 524 FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc FAIL valid_template DBIx::Class::Schema::source(): Can't find source for IdentityProvider at /kohadevbox/koha/Koha/Objects.pm line 524 FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt FAIL valid_template DBIx::Class::Schema::source(): Can't find source for IdentityProvider at /kohadevbox/koha/Koha/Objects.pm line 524 FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt FAIL valid_template DBIx::Class::Schema::source(): Can't find source for IdentityProvider at /kohadevbox/koha/Koha/Objects.pm line 524 OK t/db_dependent/Koha/Auth/Client.t OK t/db_dependent/Koha/Auth/Provider.t OK t/db_dependent/Koha/REST/Plugin/Auth/IdP.t OK t/db_dependent/api/v1/idp.t FAIL t/lib/IdP/ExternalIdP.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 Processing additional checks OK! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #132 from David Cook <dcook@prosentient.com.au> --- Looks like Koha/Template/Plugin/AuthClient.pm might be having an issue with Koha/Auth/Identity/Providers.pm... -- Test plan 1: 0. Apply patches 1. apt install libmojolicious-plugin-oauth2-perl 2. koha-upgrade-schema kohadev 3. restart_all Test plan 2: 1. Go to http://localhost:8081/cgi-bin/koha/admin/admin-home.pl 2. Click on "Identity providers" 3. Click "New identity provider" 4. Enter relevant details and click "Submit" 5. Click on "Manage Domains" 6. Click "Edit" on the default domains 7. Set "Allow staff" and allow update on login and autoregister and click "Submit" 8. koha-plack --restart kohadev 9. In an Incognito window or different browser, go to http://localhost:8080, and try logging in with a user that doesn't exist in Koha -- I'm getting this error: "There was an error authenticating to external identity provider No configuration found for your provider" I'm seeing the following error in the logs on Starman startup: [2022/11/04 06:16:26] [WARN] Warning: Failed to fetch oauth configuration: Can't locate object method "search" via package "Koha::Auth::Providers" (perhaps you forgot to load "Koha::Auth::Providers"?) at /kohadevbox/koha/Koha/REST/V1.pm line 143. [2022/11/04 06:16:26] [WARN] Warning: Failed to fetch oauth configuration: Can't locate object method "search" via package "Koha::Auth::Providers" (perhaps you forgot to load "Koha::Auth::Providers"?) at /kohadevbox/koha/Koha/REST/V1.pm line 143. -- Looks like a typo. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #133 from David Cook <dcook@prosentient.com.au> --- Agustín, how are you testing this during development? In my docker-compose.yml, I use the following: keycloak: image: jboss/keycloak networks: - kohanet environment: KEYCLOAK_USER: <username> KEYCLOAK_PASSWORD: <password> ports: - "8082:8080" If you are interested in using Keycloak for testing, I can give a few more instructions on how to set up the realm, the client, the user, and where to find the details for the Koha configuration. -- That actually reminds me that I don't have a test plan for the "OAuth" Protocol option. Does it still work with the OIDC option since OIDC is just a wrapper around OAuth? -- Anyway, that's all for me for now! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143087|0 |1 is obsolete| | Attachment #143088|0 |1 is obsolete| | Attachment #143089|0 |1 is obsolete| | Attachment #143090|0 |1 is obsolete| | Attachment #143091|0 |1 is obsolete| | Attachment #143092|0 |1 is obsolete| | Attachment #143093|0 |1 is obsolete| | Attachment #143094|0 |1 is obsolete| | Attachment #143095|0 |1 is obsolete| | Attachment #143096|0 |1 is obsolete| | Attachment #143097|0 |1 is obsolete| | Attachment #143098|0 |1 is obsolete| | Attachment #143099|0 |1 is obsolete| | Attachment #143100|0 |1 is obsolete| | Attachment #143101|0 |1 is obsolete| | Attachment #143102|0 |1 is obsolete| | Attachment #143103|0 |1 is obsolete| | Attachment #143104|0 |1 is obsolete| | Attachment #143105|0 |1 is obsolete| | Attachment #143106|0 |1 is obsolete| | Attachment #143107|0 |1 is obsolete| | --- Comment #134 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143186&action=edit Bug 31378: DB changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #135 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143187&action=edit Bug 31378: DBIC updates [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #136 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143188&action=edit Bug 31378: Add dependencies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #137 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143189&action=edit Bug 31378: Add Koha::Auth::Provider::Domain(s) class(es) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #138 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143190&action=edit Bug 31378: Add Koha::Auth::Provider(s) class(es) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #139 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143191&action=edit Bug 31378: Add Koha::Auth::Client* modules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #140 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143192&action=edit Bug 31378: Add Auth mojo plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #141 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143193&action=edit Bug 31378: Add API routes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #142 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143194&action=edit Bug 31378: Add auth providers template plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #143 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143195&action=edit Bug 31378: Add the API-based auth mechanism to C4::Auth::check_api_auth -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #144 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143196&action=edit Bug 31378: Add OPAC support for authentication providers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #145 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143197&action=edit Bug 31378: Add STAFF support for authentication providers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #146 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143198&action=edit Bug 31378: Add accessor methods for JSON attributes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #147 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143199&action=edit Bug 31378: Add manage_authentication_providers permission Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #148 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143200&action=edit Bug 31378: Add 'parameter' parameter to Koha::Exceptions::MissingParameter Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #149 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143202&action=edit Bug 31378: Add authentication provider endpoints This patch adds routes for handling authentication providers to the REST API. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_providers.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #150 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143204&action=edit Bug 31378: Add an administration interface for authentication sources -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #151 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143205&action=edit Bug 31378: Rename Auth Provider to Identity Provider and add Client.t tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #152 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143206&action=edit Bug 31378: (follow-up) do all FIXME pointed by David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #153 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143207&action=edit Bug 31378: Use base URLs for redirect uri Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #154 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 143208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143208&action=edit Bug 31378: (follow-up) catch startup error when missing Oauth provider table In theory, this shouldn't come up with a package install, but it could happen with other installations, so best to let it get to the web installer. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #155 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to David Cook from comment #132)
Looks like Koha/Template/Plugin/AuthClient.pm might be having an issue with Koha/Auth/Identity/Providers.pm...
--
Test plan 1: 0. Apply patches 1. apt install libmojolicious-plugin-oauth2-perl 2. koha-upgrade-schema kohadev 3. restart_all
Test plan 2: 1. Go to http://localhost:8081/cgi-bin/koha/admin/admin-home.pl 2. Click on "Identity providers" 3. Click "New identity provider" 4. Enter relevant details and click "Submit" 5. Click on "Manage Domains" 6. Click "Edit" on the default domains 7. Set "Allow staff" and allow update on login and autoregister and click "Submit"
8. koha-plack --restart kohadev
9. In an Incognito window or different browser, go to http://localhost:8080, and try logging in with a user that doesn't exist in Koha
--
I'm getting this error:
"There was an error authenticating to external identity provider
No configuration found for your provider"
I'm seeing the following error in the logs on Starman startup:
[2022/11/04 06:16:26] [WARN] Warning: Failed to fetch oauth configuration: Can't locate object method "search" via package "Koha::Auth::Providers" (perhaps you forgot to load "Koha::Auth::Providers"?) at /kohadevbox/koha/Koha/REST/V1.pm line 143. [2022/11/04 06:16:26] [WARN] Warning: Failed to fetch oauth configuration: Can't locate object method "search" via package "Koha::Auth::Providers" (perhaps you forgot to load "Koha::Auth::Providers"?) at /kohadevbox/koha/Koha/REST/V1.pm line 143.
--
Looks like a typo.
Sorry, I applied your patch but didn't update Koha::Auth::Providers to Koha::Auth::Identity::Providers Now it should work Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143200|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143202|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143204|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143205|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143206|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143207|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143208|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143186|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143187|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143188|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143189|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143190|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143191|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143192|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143193|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143194|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143195|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143196|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143197|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143198|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143199|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #156 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143215&action=edit Bug 31378: DB changes Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #157 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143216&action=edit Bug 31378: DBIC updates [DO NOT PUSH] Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #158 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143217&action=edit Bug 31378: Add dependencies Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #159 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143218&action=edit Bug 31378: Add Koha::Auth::Provider::Domain(s) class(es) Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #160 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143219&action=edit Bug 31378: Add Koha::Auth::Provider(s) class(es) Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #161 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143220&action=edit Bug 31378: Add Koha::Auth::Client* modules Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #162 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143221&action=edit Bug 31378: Add Auth mojo plugin Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #163 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143222&action=edit Bug 31378: Add API routes Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #164 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143223&action=edit Bug 31378: Add auth providers template plugin Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #165 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143224&action=edit Bug 31378: Add the API-based auth mechanism to C4::Auth::check_api_auth Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #166 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143225&action=edit Bug 31378: Add OPAC support for authentication providers Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #167 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143226&action=edit Bug 31378: Add STAFF support for authentication providers Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #168 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143227&action=edit Bug 31378: Add accessor methods for JSON attributes Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #169 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143228&action=edit Bug 31378: Add manage_authentication_providers permission Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #170 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143229&action=edit Bug 31378: Add 'parameter' parameter to Koha::Exceptions::MissingParameter Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #171 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143230&action=edit Bug 31378: Add authentication provider endpoints This patch adds routes for handling authentication providers to the REST API. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_providers.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #172 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143231&action=edit Bug 31378: Add an administration interface for authentication sources Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #173 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143232&action=edit Bug 31378: Rename Auth Provider to Identity Provider and add Client.t tests Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #174 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143233&action=edit Bug 31378: (follow-up) Fix QA concerns Several FIXME comments added on the report addressed here. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #175 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143234&action=edit Bug 31378: Use base URLs for redirect uri Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #176 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143235&action=edit Bug 31378: (follow-up) catch startup error when missing Oauth provider table In theory, this shouldn't come up with a package install, but it could happen with other installations, so best to let it get to the web installer. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #177 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143236&action=edit Bug 31378: (QA follow-up) Tidy tests This patch perltidys the tests added lately. It also removes some commented debugging lines. Note: There's an attempt to write tests on the full auth workflow that is commented out but left there on purpose for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #178 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I restored Lucasz signature that was lost at some point. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143215|0 |1 is obsolete| | --- Comment #179 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143266&action=edit Bug 31378: DB changes Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143216|0 |1 is obsolete| | --- Comment #180 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143267&action=edit Bug 31378: DBIC updates [DO NOT PUSH] Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143217|0 |1 is obsolete| | --- Comment #181 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143268&action=edit Bug 31378: Add dependencies Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143218|0 |1 is obsolete| | --- Comment #182 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143269&action=edit Bug 31378: Add Koha::Auth::Provider::Domain(s) class(es) Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143219|0 |1 is obsolete| | --- Comment #183 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143270&action=edit Bug 31378: Add Koha::Auth::Provider(s) class(es) Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143220|0 |1 is obsolete| | --- Comment #184 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143271&action=edit Bug 31378: Add Koha::Auth::Client* modules Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143221|0 |1 is obsolete| | --- Comment #185 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143272&action=edit Bug 31378: Add Auth mojo plugin Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143222|0 |1 is obsolete| | --- Comment #186 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143273&action=edit Bug 31378: Add API routes Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143223|0 |1 is obsolete| | --- Comment #187 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143274&action=edit Bug 31378: Add auth providers template plugin Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143224|0 |1 is obsolete| | --- Comment #188 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143275&action=edit Bug 31378: Add the API-based auth mechanism to C4::Auth::check_api_auth Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143225|0 |1 is obsolete| | --- Comment #189 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143277&action=edit Bug 31378: Add OPAC support for authentication providers Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143226|0 |1 is obsolete| | --- Comment #190 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143278&action=edit Bug 31378: Add STAFF support for authentication providers Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143227|0 |1 is obsolete| | --- Comment #191 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143279&action=edit Bug 31378: Add accessor methods for JSON attributes Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143228|0 |1 is obsolete| | --- Comment #192 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143280&action=edit Bug 31378: Add manage_authentication_providers permission Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143229|0 |1 is obsolete| | --- Comment #193 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143281&action=edit Bug 31378: Add 'parameter' parameter to Koha::Exceptions::MissingParameter Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143230|0 |1 is obsolete| | --- Comment #194 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143282&action=edit Bug 31378: Add authentication provider endpoints This patch adds routes for handling authentication providers to the REST API. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_providers.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143231|0 |1 is obsolete| | --- Comment #195 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143283&action=edit Bug 31378: Add an administration interface for authentication sources Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143232|0 |1 is obsolete| | --- Comment #196 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143284&action=edit Bug 31378: Rename Auth Provider to Identity Provider and add Client.t tests Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143233|0 |1 is obsolete| | --- Comment #197 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143285&action=edit Bug 31378: (follow-up) Fix QA concerns Several FIXME comments added on the report addressed here. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143234|0 |1 is obsolete| | --- Comment #198 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143286&action=edit Bug 31378: Use base URLs for redirect uri Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143235|0 |1 is obsolete| | --- Comment #199 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143287&action=edit Bug 31378: (follow-up) catch startup error when missing Oauth provider table In theory, this shouldn't come up with a package install, but it could happen with other installations, so best to let it get to the web installer. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143236|0 |1 is obsolete| | --- Comment #200 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143288&action=edit Bug 31378: (QA follow-up) Tidy tests This patch perltidys the tests added lately. It also removes some commented debugging lines. Note: There's an attempt to write tests on the full auth workflow that is commented out but left there on purpose for now. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #201 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Cook from comment #133)
Agustín, how are you testing this during development?
In my docker-compose.yml, I use the following:
keycloak: image: jboss/keycloak networks: - kohanet environment: KEYCLOAK_USER: <username> KEYCLOAK_PASSWORD: <password> ports: - "8082:8080"
If you are interested in using Keycloak for testing, I can give a few more instructions on how to set up the realm, the client, the user, and where to find the details for the Koha configuration.
I've just added an --sso option switch to the 'ktd' command, using the examples you provided (with minor tweaks). Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #202 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #201)
I've just added an --sso option switch to the 'ktd' command, using the examples you provided (with minor tweaks).
I use a bit of a custom setup, but I'll include your docker-compose.sso.yml :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #203 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #202)
(In reply to Tomás Cohen Arazi from comment #201)
I've just added an --sso option switch to the 'ktd' command, using the examples you provided (with minor tweaks).
I use a bit of a custom setup, but I'll include your docker-compose.sso.yml :D
Looks like the docker-compose.sso.yml still needs some work, but I've emailed about fixing that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #204 from David Cook <dcook@prosentient.com.au> --- Test plan 1: 0. Apply patches 1. apt install libmojolicious-plugin-oauth2-perl 2. koha-upgrade-schema kohadev 3. restart_all Test plan 2a (Quarkus Keycloak): 1. Go to http://<workstation_ip>:8082/ 2. Click "Administration Console" 3. Login to master realm 4. Click on dropdown menu that says "master" 5. Click "Create Realm" 6. Type "test" into "Realm name" and click "Create" 7. Click "Clients" 8. Click "Create client" 9. Type "test" into "Client ID" 10. Click "Next" 11. Set "Client authentication" to "On" 12. Click "Save" 13. Add "Valid redirect URIs" of "http://localhost:8080/*" and "http://localhost:8081/*" 14. Click "Credentials" tab and note the "Client secret" 15. Click "Advanced" tab and turn "Exclude Session State From Authentication Response" to "On" then click "Save" 16. Click "Users" on left nav 17. Click "Create new user" 18. Type "kohadev" into "Username" 19. Type "kohadev@koha-community.org" into Email" 20. Type "Firstname" into "First name" 21. Type "Lastname" into "Last name" 22. Click "Create" 23. Click "Credentials" tab and click "Set password" 24. Choose a password, turn off "Temporary", and click "Save" 25. Click "Realm settings" from the left nav 26. Click "OpenID Endpoint Configuration" at the bottom of the page Test plan 2b: 1. Go to http://localhost:8081/cgi-bin/koha/admin/admin-home.pl 2. Click on "Identity providers" 3. Click "New identity provider" 4a. Type "test" into "Code" 4b. Type "Test" into "Description" 4c. Choose "OIDC" for "Protocol" 4d. Click "Add default OIDC configuration" 4e. Click "Add default OIDC mapping" 4f. Update "Configuration" to match Keycloak details for "key", "secret", and "well_known_url" 5. Click on "Manage Domains" 6. Click "Edit" on the default domains 7. Set "Allow staff" and allow update on login and autoregister and click "Submit" 8. koha-plack --restart kohadev 9. Update OPACBaseURL and staffClientBaseURL to http://localhost:8080 and http://localhost:8081 respectively Test plan 3: 1. In an Incognito window or different browser, go to http://localhost:8080, and try logging in with a user that doesn't exist in Koha -- I got the following error: There was an error authenticating to external identity provider DBIC result _type isn't of the _type Category at /usr/share/perl5/DBIx/Class/Storage/BlockRunner.pm line 130. Looks like auto register doesn't work still... I changed the email address for the "koha" user to "kohadev@koha-community.org" at http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 Login works, but it doesn't update the user details on login either. Going to have to fail this again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #205 from David Cook <dcook@prosentient.com.au> --- When I add a Domain rule that forbids login for staff interface or OPAC, it says "No configuration found for your email domain". I think you could just leave it as "There was an error authenticating to external identity provider". But that's just a comment and not a blocker. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #206 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #204)
I got the following error:
There was an error authenticating to external identity provider
DBIC result _type isn't of the _type Category at /usr/share/perl5/DBIx/Class/Storage/BlockRunner.pm line 130.
Looks like auto register doesn't work still...
It looks like I had forgotten to provide "Default library" and "Default category". When I do provide "Default library" and "Default category", it does auto register a new patron! Yay! If I provide a "Default category" but no "Default library", then I get this error: "There was an error authenticating to external identity provider Broken FK constraint" -- I think for these two scenarios, you just shouldn't show the error on the Web UI. Log it to the log files and leave it at that. It's enough to tell the end user that "There was an error authentication to external identity provider. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #207 from David Cook <dcook@prosentient.com.au> --- I've double-checked that my ID token and UserInfo responses include "given_name" and "family_name" and they do. I've noticed with the auto register that it isn't populating the "firstname" and "surname" fields. That's probably why the update on login isn't working either. -- So I think fixes required are: 1) Hide overly revealing error messages in Web UI 2) Fix mapping so that auto-register "update on login" works and auto register includes mappings beyond just email. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #208 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #207)
So I think fixes required are:
1) Hide overly revealing error messages in Web UI 2) Fix mapping so that auto-register "update on login" works and auto register includes mappings beyond just email.
I notice in the help text that it says "If you plan to use auto register feature, either userid or cardnumber must be present in this mapping". That doesn't appear to be true in my testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #209 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Cook from comment #208)
(In reply to David Cook from comment #207)
So I think fixes required are:
1) Hide overly revealing error messages in Web UI 2) Fix mapping so that auto-register "update on login" works and auto register includes mappings beyond just email.
I notice in the help text that it says "If you plan to use auto register feature, either userid or cardnumber must be present in this mapping".
That doesn't appear to be true in my testing.
Any NOT NULL attribute on the borrowers table needs to be mapped for auto-register. I don't really understand this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32133 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32133 [Bug 32133] Streamline OIDC error messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143266|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143267|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143268|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143269|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143270|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143271|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143272|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143273|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143274|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143275|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143277|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143278|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143279|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143280|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143281|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143282|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143283|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143284|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143285|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143286|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143287|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143288|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #210 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143396&action=edit Bug 31378: DB changes Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #211 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143397&action=edit Bug 31378: DBIC updates [DO NOT PUSH] Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #212 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143398&action=edit Bug 31378: Add dependencies Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #213 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143399&action=edit Bug 31378: Add Koha::Auth::Provider::Domain(s) class(es) Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #214 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143400&action=edit Bug 31378: Add Koha::Auth::Provider(s) class(es) Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #215 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143401&action=edit Bug 31378: Add Koha::Auth::Client* modules Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #216 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143402&action=edit Bug 31378: Add Auth mojo plugin Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #217 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143403&action=edit Bug 31378: Add API routes Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #218 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143404&action=edit Bug 31378: Add auth providers template plugin Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #219 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143405&action=edit Bug 31378: Add the API-based auth mechanism to C4::Auth::check_api_auth Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #220 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143406&action=edit Bug 31378: Add OPAC support for authentication providers Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #221 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143407&action=edit Bug 31378: Add STAFF support for authentication providers Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #222 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143408&action=edit Bug 31378: Add accessor methods for JSON attributes Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #223 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143409&action=edit Bug 31378: Add manage_authentication_providers permission Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #224 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143410&action=edit Bug 31378: Add 'parameter' parameter to Koha::Exceptions::MissingParameter Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #225 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143411&action=edit Bug 31378: Add authentication provider endpoints This patch adds routes for handling authentication providers to the REST API. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_providers.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #226 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143412&action=edit Bug 31378: Add an administration interface for authentication sources Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #227 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143413&action=edit Bug 31378: Rename Auth Provider to Identity Provider and add Client.t tests Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #228 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143414&action=edit Bug 31378: (follow-up) Fix QA concerns Several FIXME comments added on the report addressed here. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #229 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143415&action=edit Bug 31378: Use base URLs for redirect uri Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #230 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143416&action=edit Bug 31378: (follow-up) catch startup error when missing Oauth provider table In theory, this shouldn't come up with a package install, but it could happen with other installations, so best to let it get to the web installer. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #231 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143417&action=edit Bug 31378: (QA follow-up) Tidy tests This patch perltidys the tests added lately. It also removes some commented debugging lines. Note: There's an attempt to write tests on the full auth workflow that is commented out but left there on purpose for now. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #232 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143418&action=edit Bug 31378: Add domain settings to IdP add page This patch introduces a small form for an initial domain configuration to the 'New identity provider' page, to avoid confusion on testers about required settings for things to work. To test: 1. Apply this patch 2. Verify you are now offered a configuration section for domain settings. Fields like 'Default category' and 'Default library' are mandatory. 3. Choosing some values makes them get stored on 'Submit' Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143396|0 |1 is obsolete| | --- Comment #233 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143420&action=edit Bug 31378: DB changes Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143397|0 |1 is obsolete| | --- Comment #234 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143421&action=edit Bug 31378: DBIC updates [DO NOT PUSH] Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143398|0 |1 is obsolete| | --- Comment #235 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143422&action=edit Bug 31378: Add dependencies Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143399|0 |1 is obsolete| | --- Comment #236 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143423&action=edit Bug 31378: Add Koha::Auth::Provider::Domain(s) class(es) Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143400|0 |1 is obsolete| | --- Comment #237 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143424&action=edit Bug 31378: Add Koha::Auth::Provider(s) class(es) Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143401|0 |1 is obsolete| | --- Comment #238 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143425&action=edit Bug 31378: Add Koha::Auth::Client* modules Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143402|0 |1 is obsolete| | --- Comment #239 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143426&action=edit Bug 31378: Add Auth mojo plugin Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143403|0 |1 is obsolete| | --- Comment #240 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143427&action=edit Bug 31378: Add API routes Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143404|0 |1 is obsolete| | --- Comment #241 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143428&action=edit Bug 31378: Add auth providers template plugin Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143405|0 |1 is obsolete| | --- Comment #242 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143429&action=edit Bug 31378: Add the API-based auth mechanism to C4::Auth::check_api_auth Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143406|0 |1 is obsolete| | --- Comment #243 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143430&action=edit Bug 31378: Add OPAC support for authentication providers Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143407|0 |1 is obsolete| | --- Comment #244 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143431&action=edit Bug 31378: Add STAFF support for authentication providers Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143408|0 |1 is obsolete| | --- Comment #245 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143432&action=edit Bug 31378: Add accessor methods for JSON attributes Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143409|0 |1 is obsolete| | --- Comment #246 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143433&action=edit Bug 31378: Add manage_authentication_providers permission Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143410|0 |1 is obsolete| | --- Comment #247 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143434&action=edit Bug 31378: Add 'parameter' parameter to Koha::Exceptions::MissingParameter Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143411|0 |1 is obsolete| | --- Comment #248 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143435&action=edit Bug 31378: Add authentication provider endpoints This patch adds routes for handling authentication providers to the REST API. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_providers.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143412|0 |1 is obsolete| | --- Comment #249 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143436&action=edit Bug 31378: Add an administration interface for authentication sources Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143413|0 |1 is obsolete| | --- Comment #250 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143437&action=edit Bug 31378: Rename Auth Provider to Identity Provider and add Client.t tests Signed-off-by: Lukasz Koszyk <lukasz.koszyk@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143414|0 |1 is obsolete| | --- Comment #251 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143438&action=edit Bug 31378: (follow-up) Fix QA concerns Several FIXME comments added on the report addressed here. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143415|0 |1 is obsolete| | --- Comment #252 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143439&action=edit Bug 31378: Use base URLs for redirect uri Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143416|0 |1 is obsolete| | --- Comment #253 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143440&action=edit Bug 31378: (follow-up) catch startup error when missing Oauth provider table In theory, this shouldn't come up with a package install, but it could happen with other installations, so best to let it get to the web installer. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143417|0 |1 is obsolete| | --- Comment #254 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143441&action=edit Bug 31378: (QA follow-up) Tidy tests This patch perltidys the tests added lately. It also removes some commented debugging lines. Note: There's an attempt to write tests on the full auth workflow that is commented out but left there on purpose for now. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143418|0 |1 is obsolete| | --- Comment #255 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143442&action=edit Bug 31378: Add domain settings to IdP add page This patch introduces a small form for an initial domain configuration to the 'New identity provider' page, to avoid confusion on testers about required settings for things to work. To test: 1. Apply this patch 2. Verify you are now offered a configuration section for domain settings. Fields like 'Default category' and 'Default library' are mandatory. 3. Choosing some values makes them get stored on 'Submit' Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #256 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143443&action=edit Bug 31378: DBIC Build Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|dcook@prosentient.com.au |testopia@bugs.koha-communit | |y.org Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #257 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://gitlab.com/thekesol | |utions/Koha/-/commits/oauth | |_client | Keywords|rel_22_11_candidate |release-notes-needed --- Comment #258 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Thanks everyone. Any issues you might find, please file follow-up bugs. Fixes/enhancements are welcome of course. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #259 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143450&action=edit Bug 31378: (follow-up) MySQL 8 doens't allow default for longtext Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #260 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #209)
I notice in the help text that it says "If you plan to use auto register feature, either userid or cardnumber must be present in this mapping".
That doesn't appear to be true in my testing.
Any NOT NULL attribute on the borrowers table needs to be mapped for auto-register. I don't really understand this one.
Both userid and cardnumber can be null though. Auto-register works without them being mapped, although perhaps it shouldn't. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #261 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #258)
Thanks everyone. Any issues you might find, please file follow-up bugs. Fixes/enhancements are welcome of course.
Sounds good. I'll give it another test this morning, and open follow-up bugs for any issues I find. Glad to see this one in master in any case! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32138 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32138 [Bug 32138] OIDC client uses backwards default mapping -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32139 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32139 [Bug 32139] "Update on login" setting not set when creating domain from new IdP page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32140 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32140 [Bug 32140] Sessions created using the OIDC/OAuth2 client use an "api" interface rather than "intranet" or "opac" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #262 from David Cook <dcook@prosentient.com.au> --- I've raised bug 32138 and bug 32139 as follow-ups, but they just relate to some configuration-related fixes. They should be easy to fix, so I'll write patches for them shortly. When they're fixed, I think that I'll be happy enough with this feature. (I'll probably raise 1 more follow-up soon but it's a minor UI tweak.) I also raised bug 32140 because I'm a bit concerned that the "interface" is set to "api" rather than the relevant "intranet" or "opac", but I haven't observed any obvious problems with that yet, so... I'm not making it a priority right now. -- Thanks again to Agustin and Tomas and everyone else for making this happen. I've carried a local customization to enable OIDC auth in Koha since 2014, so I'll be glad to put that to rest, and just focus on helping make this core OIDC client the best it can be. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32141 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141 [Bug 32141] Identity provider textboxes too small on edit pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #263 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Error while loading /etc/koha/plack.psgi: Can't load application from file "/usr/share/koha/api/v1/app.pl": Can't locate Mojolicious/Plugin/OAuth2.pm in @INC Should we mark this as dependency for Mason please? apt-get install libmojolicious-plugin-oauth2-perl apt-get install libmojolicious-plugin-renderfile-perl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #264 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Hola, Marcel! (In reply to Marcel de Rooy from comment #263)
Error while loading /etc/koha/plack.psgi: Can't load application from file "/usr/share/koha/api/v1/app.pl": Can't locate Mojolicious/Plugin/OAuth2.pm in @INC
Should we mark this as dependency for Mason please?
apt-get install libmojolicious-plugin-oauth2-perl apt-get install libmojolicious-plugin-renderfile-perl
Dependencies are packaged (by Mason) and already present on the latest KTD images. Thanks for reporting, I will mention it on the list for other devs to be aware! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #265 from David Cook <dcook@prosentient.com.au> --- (In reply to Marcel de Rooy from comment #263)
Error while loading /etc/koha/plack.psgi: Can't load application from file "/usr/share/koha/api/v1/app.pl": Can't locate Mojolicious/Plugin/OAuth2.pm in @INC
Should we mark this as dependency for Mason please?
apt-get install libmojolicious-plugin-oauth2-perl apt-get install libmojolicious-plugin-renderfile-perl
I can see 'Mojolicious::Plugin::RenderFile' in cpanfile, but I can't see 'Mojolicious::Plugin::OAuth2'. I think cpanfile might need an update? I think debian/control gets updated at release time... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #266 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Cook from comment #265)
(In reply to Marcel de Rooy from comment #263)
Error while loading /etc/koha/plack.psgi: Can't load application from file "/usr/share/koha/api/v1/app.pl": Can't locate Mojolicious/Plugin/OAuth2.pm in @INC
Should we mark this as dependency for Mason please?
apt-get install libmojolicious-plugin-oauth2-perl apt-get install libmojolicious-plugin-renderfile-perl
I can see 'Mojolicious::Plugin::RenderFile' in cpanfile, but I can't see 'Mojolicious::Plugin::OAuth2'.
The third patch introduced it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #267 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #266)
The third patch introduced it.
Ahhh, I see it now. I expected it to be in the usual alphabetical order, but I do see it now. All good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shi-yao.wang@inLibro.com --- Comment #270 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 30988 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | Text to go in the| |This feature introduces a release notes| |way to integrate Koha with | |any OAuth2/OIDC identity | |provider. | | | |It also prepares | |the ground for later adding | |more protocol and | |prioritizing authentication | |methods/identity providers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This feature introduces a |This feature introduces a release notes|way to integrate Koha with |way to integrate Koha with |any OAuth2/OIDC identity |any OAuth2/OIDC identity |provider. |provider. | | |It also prepares |It also prepares |the ground for later adding |the ground for later adding |more protocol and |more protocols and |prioritizing authentication |prioritizing authentication |methods/identity providers. |methods/identity providers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mark.jaroski@gmail.com --- Comment #271 from David Cook <dcook@prosentient.com.au> --- *** Bug 28420 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10988 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #272 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144071&action=edit Bug 31378: (QA follow-up) Defer store until JSON fields are populated Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 --- Comment #273 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144175&action=edit Bug 31378: Tests shouldn't remove all patrons Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32354 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354 [Bug 32354] Handle session_state param given by OAuth identity provider -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33517 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33517 [Bug 33517] Add support for extended attributes mapping on IdP config -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33518 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33518 [Bug 33518] Inconsistent breadcrumbs in IdP pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #274 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Hello everyone! This is a bit technical for me, but I attempted to add the information to the manual. Would any of you who worked on this have the time to read what I wrote and let me know if I mangled anything? (It's not very long) https://gitlab.com/koha-community/koha-manual/-/merge_requests/670 Thanks! Caroline -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/670 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 hebah@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33790 [Bug 33790] identity_providers.pl does not have Help link to manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33859 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33859 [Bug 33859] Use the phrase 'Identity providers' instead of 'Authentication providers' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34164 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34164 [Bug 34164] OAuth2/OIDC should redirect to page that initiated login -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33699 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33699 [Bug 33699] Typo in identity_provider_domains.tt (presedence) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35617 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35617 [Bug 35617] Make phone number as match point in in Identity providers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40596 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40596 [Bug 40596] Migrate CAS and Shibboleth into the identity providers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40882 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40882 [Bug 40882] Identity provider errors are not translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39224 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39224 [Bug 39224] Migrate SAML/Shibboleth configuration into Identity Providers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|40596 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40596 [Bug 40596] Migrate CAS configuration into Identity Providers -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org