https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39046 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177585&action=edit Bug 39046: Use Bootstrap badge to indicate late transfers This patch removes the error class from the table of late transfers. Instead, the days late status is shown as a Bootstrap badge. The patch also adds pluralization to the string so that it adapts based on the number of late transfers. To test you would ideally have multiple pending transfers to your library, some late and some not. This will presumably require manually updated your database to change the date of pending transfers. - Make at least one transfer multiple days late by changing the `datesent` value to a date late enough to exceed the number of days defined in the TransfersMaxDaysWarning system preference. - Make at least one transfer only one day late. - When you go to Circulation -> Transfers to receive you should see badge-style labels on the transfers which are late. - The text of the labels should be correct according to the number: "1 day late" or "XX days late" Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39046 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Is it directly related to bug 38664? (or it's dependencies that did cleanup) Or is the "Depends on 38664" just because it's a patch that can only directly be applied on top of 38664? (as likely most new patches) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39046 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177949|0 |1 is obsolete| | --- Comment #5 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 178479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178479&action=edit Bug 39046: Use Bootstrap badge to indicate late transfers This patch removes the error class from the table of late transfers. Instead, the days late status is shown as a Bootstrap badge. The patch also adds pluralization to the string so that it adapts based on the number of late transfers. To test you would ideally have multiple pending transfers to your library, some late and some not. This will presumably require manually updated your database to change the date of pending transfers. - Make at least one transfer multiple days late by changing the `datesent` value to a date late enough to exceed the number of days defined in the TransfersMaxDaysWarning system preference. - Make at least one transfer only one day late. - When you go to Circulation -> Transfers to receive you should see badge-style labels on the transfers which are late. - The text of the labels should be correct according to the number: "1 day late" or "XX days late" Sponsored-by: Athens County Public Libraries Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39046 --- Comment #6 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- A small notice: Above the table of transfers is the info text that says "Transfers are considered late after x days.". In this sentence the words "considered late" are red which implies that something is colored red underneath, which no longer applies after this change. I think this is not a show stopper but could be fixed sometimes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39046 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178479|0 |1 is obsolete| | --- Comment #7 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180849&action=edit Bug 39046: Use Bootstrap badge to indicate late transfers This patch removes the error class from the table of late transfers. Instead, the days late status is shown as a Bootstrap badge. The patch also adds pluralization to the string so that it adapts based on the number of late transfers. To test you would ideally have multiple pending transfers to your library, some late and some not. This will presumably require manually updated your database to change the date of pending transfers. - Make at least one transfer multiple days late by changing the `datesent` value to a date late enough to exceed the number of days defined in the TransfersMaxDaysWarning system preference. - Make at least one transfer only one day late. - When you go to Circulation -> Transfers to receive you should see badge-style labels on the transfers which are late. - The text of the labels should be correct according to the number: "1 day late" or "XX days late" Sponsored-by: Athens County Public Libraries Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39046 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.