[Bug 39356] New: Accessibility 1.3.1: There are pages where heading ranks are skipped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 Bug ID: 39356 Summary: Accessibility 1.3.1: There are pages where heading ranks are skipped Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Accessibility Assignee: koha-bugs@lists.koha-community.org Reporter: nina.martinez@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, oleonard@myacpl.org "Skipping heading ranks can be confusing and should be avoided where possible: Make sure that a <h2> is not followed directly by an <h4>, for example. It is ok to skip ranks when closing subsections, for instance, a <h2> beginning a new section, can follow an <h4> as it closes the previous section." For example : I found in Your summary account page in suspend Hold section a <h1> followed directly by an <h6>. https://www.w3.org/WAI/tutorials/page-structure/headings/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 nina <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 --- Comment #1 from nina <nina.martinez@biblibre.com> --- (In reply to nina from comment #0)
"Skipping heading ranks can be confusing and should be avoided where possible: Make sure that a <h2> is not followed directly by an <h4>, for example. It is ok to skip ranks when closing subsections, for instance, a <h2> beginning a new section, can follow an <h4> as it closes the previous section."
For example, I found that on the 'Your Summary Account' page, in the 'Suspend >Hold' section, an <h1> tag is directly followed by an <h6> tag.
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 nina <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |nina.martinez@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 --- Comment #2 from nina <nina.martinez@biblibre.com> --- Created attachment 179465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179465&action=edit Bug39356 : Change heading ranks when ranks are skipped Test plan : - Check all headings on the pages (you can use tools like HeadingsMap ) - Verify that no heading ranks are skipped - If it is the case, the test succeeds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 nina <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 --- Comment #3 from nina <nina.martinez@biblibre.com> --- Created attachment 179473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179473&action=edit Bug 39356 - Change heading ranks when ranks are skipped Test plan: 1- Check all headings on the pages (you can use tools like HeadingsMap) 2- Verify that no heading ranks are skipped 3- If it's the case, the test succeeds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 nina <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 nina <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] [OMNIBUS] Accessibility improvements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I get a sha1 error when trying to apply this patch. I also noticed there is an extra character in opac-main.tt https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179465&action=diff#a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt_sec1 I would help testing to know which pages we should be looking at. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179465|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 179928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179928&action=edit Bug 39356: Change heading ranks when ranks are skipped Test plan: 1- Check all headings on the pages (you can use tools like HeadingsMap) 2- Verify that no heading ranks are skipped 3- If it's the case, the test succeeds Pages to check: - opac-main.pl - opac-curbside-pickups.pl - opac-memberentry.pl - opac-recalls.pl - opac-user.pl - opac-details.pl (shelf browser, the modal that open after a click on "Cite" in the sidebar) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179473|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Caroline Cyr La Rose from comment #4)
I get a sha1 error when trying to apply this patch.
I also noticed there is an extra character in opac-main.tt https://bugs.koha-community.org/bugzilla3/attachment. cgi?id=179465&action=diff#a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac- main.tt_sec1
I would help testing to know which pages we should be looking at. :)
This was caused by the first patch not being obsoleted, sorry about that! Submitted new patch with the list of pages to check -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |e.betemps@gmail.com --- Comment #7 from Emmanuel Bétemps <e.betemps@gmail.com> --- It's ok with all the pages but one : opac-details.pl I use the HeadingsMap tool, thanks for the tip ! if I click on a record (to get its details), I just get a 2, without any 1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 nina <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 --- Comment #8 from nina <nina.martinez@biblibre.com> --- (In reply to Emmanuel Bétemps from comment #7)
It's ok with all the pages but one : opac-details.pl
I use the HeadingsMap tool, thanks for the tip ! if I click on a record (to get its details), I just get a 2, without any 1
This is due to the xslt, normally there are a heading 1 for record title on the details page. Maybe we can solve this problem in an other bug ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 nina <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179928|0 |1 is obsolete| | --- Comment #9 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 180063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180063&action=edit Bug 39356: Change heading ranks when ranks are skipped Test plan: 1- Check all headings on the pages (you can use tools like HeadingsMap) 2- Verify that no heading ranks are skipped 3- If it's the case, the test succeeds Pages to check: - opac-main.pl - opac-curbside-pickups.pl - opac-memberentry.pl - opac-recalls.pl - opac-user.pl - opac-details.pl (shelf browser, the modal that open after a click on "Cite" in the sidebar) Signed-off-by: Emmanuel <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@openfifth.co.uk --- Comment #10 from Andrew Auld <andrew.auld@openfifth.co.uk> --- For the test plan, it would be useful to include what system preferences need to be turned on to allow access to pages that you need to be tested. Many people will know, but some will not and it is always good to give as much information as possible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 --- Comment #11 from Andrew Auld <andrew.auld@openfifth.co.uk> --- Also tested and signed off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180063|0 |1 is obsolete| | --- Comment #12 from Andrew Auld <andrew.auld@openfifth.co.uk> --- Created attachment 180224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180224&action=edit Bug 39356: Change heading ranks when ranks are skipped Test plan: 1- Check all headings on the pages (you can use tools like HeadingsMap) 2- Verify that no heading ranks are skipped 3- If it's the case, the test succeeds Pages to check: - opac-main.pl - opac-curbside-pickups.pl - opac-memberentry.pl - opac-recalls.pl - opac-user.pl - opac-details.pl (shelf browser, the modal that open after a click on "Cite" in the sidebar) Signed-off-by: Emmanuel <e.betemps@gmail.com> Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180224|0 |1 is obsolete| | --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180269&action=edit Bug 39356: Change heading ranks when ranks are skipped Test plan: 1- Check all headings on the pages (you can use tools like HeadingsMap) 2- Verify that no heading ranks are skipped 3- If it's the case, the test succeeds Pages to check: - opac-main.pl - opac-curbside-pickups.pl - opac-memberentry.pl - opac-recalls.pl - opac-user.pl - opac-details.pl (shelf browser, the modal that open after a click on "Cite" in the sidebar) Signed-off-by: Emmanuel <e.betemps@gmail.com> Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |This patch fixes some released in| |accessibility issues on | |OPAC pages where heading | |ranks are missing or | |skipped. The patch adds | |headings where they are | |missing or changes the | |ranks in the cases where | |they were incorrect. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|This patch fixes some |This fixes some released in|accessibility issues on |accessibility issues on |OPAC pages where heading |OPAC pages where heading |ranks are missing or |levels are missing or |skipped. The patch adds |skipped. It adds headings |headings where they are |where they are missing, or |missing or changes the |changes the heading levels |ranks in the cases where |in the cases where they |they were incorrect. |were incorrect. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Accessibility 1.3.1: There |Accessibility 1.3.1: There |are pages where heading |are pages where heading |ranks are skipped |levels are skipped -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|This fixes some |This fixes some released in|accessibility issues on |accessibility issues on |OPAC pages where heading |OPAC pages where heading |levels are missing or |levels are missing or |skipped. It adds headings |skipped. It adds headings |where they are missing, or |where they are |changes the heading levels |missing,25.05.00, or |in the cases where they |changes the heading levels |were incorrect. |in the cases where they | |were incorrect. Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|This fixes some |25.05.00 released in|accessibility issues on | |OPAC pages where heading | |levels are missing or | |skipped. It adds headings | |where they are | |missing,25.05.00, or | |changes the heading levels | |in the cases where they | |were incorrect. | Text to go in the| |This fixes some release notes| |accessibility issues on | |OPAC pages where heading | |levels are missing or | |skipped. It adds headings | |where they are missing, or | |changes the heading levels | |in the cases where they | |were incorrect. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39356 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org