[Bug 26065] New: Move translatable strings out of marc_modification_templates.tt and into marc_modification_templates.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26065 Bug ID: 26065 Summary: Move translatable strings out of marc_modification_templates.tt and into marc_modification_templates.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr, testopia@bugs.koha-community.org Depends on: 21156 Strings defined for translation in marc_modification_templates.tt can now be wrapped in the new translation function and put in marc_modification_templates.js. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26065 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26065 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 107430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107430&action=edit Bug 26065: Move translatable strings out of marc_modification_templates.tt and into marc_modification_templates.js This patch removes the <script> block in the MARC modification templates template in which strings are defined for translation purposes. Strings are now in place in the JavaScript file and wrapped in the new __() function. To test, apply the patch and clear your browser cache if necessary. - Perform some actions which will trigger translated strings, for example: - Create a new template - Add an action to the template and then delete it. - The confirmation should appear correctly - Add an action. Select "Copy" as the operation and click "Add action" without filling in any fields. - You should see a message, "Both subfield values should be filled or empty" TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR:
cd misc/translator perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js for translation, e.g.: msgid "Both subfield values should be filled or empty." msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation:
perl translate install fr-FR
- Switch to your newly translated language in the staff client and repeat the test plan above. The translated string should appear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26065 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25694 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25694 [Bug 25694] Add ability to delete a Marc Modification Template when viewing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26065 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26065 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107430|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 107550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107550&action=edit Bug 26065: Move translatable strings out of marc_modification_templates.tt and into marc_modification_templates.js This patch removes the <script> block in the MARC modification templates template in which strings are defined for translation purposes. Strings are now in place in the JavaScript file and wrapped in the new __() function. To test, apply the patch and clear your browser cache if necessary. - Perform some actions which will trigger translated strings, for example: - Create a new template - Add an action to the template and then delete it. - The confirmation should appear correctly - Add an action. Select "Copy" as the operation and click "Add action" without filling in any fields. - You should see a message, "Both subfield values should be filled or empty" TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR:
cd misc/translator perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js for translation, e.g.: msgid "Both subfield values should be filled or empty." msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation:
perl translate install fr-FR
- Switch to your newly translated language in the staff client and repeat the test plan above. The translated string should appear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26065 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Passed QA --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Skipping QA, I will review it myself. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26065 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26065 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26065 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org