[Bug 33056] New: Terminology: change 'fine' to 'charge' when making a payment/writeoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33056 Bug ID: 33056 Summary: Terminology: change 'fine' to 'charge' when making a payment/writeoff Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org In the development meeting of Feb 22, 2023, we decided to change 'fine' to 'charge' when referring to various types of fees ('fine' should be limited to overdue fines). The term should be changed in paycollect.tt, which is the page when paying or writing off a charge in a patron's account. To access this page and all strings: 1. Add a manual fee to a patron's account 1.1. Go to a patron's account > Accounting tab 1.2. Click 'Create manual invoice' 1.3. Enter an amount 1.4. Click 'Save' 2. Pay an individual charge 2.1. Click 'Make a payment' 2.2. Click the 'Pay' button next to an individual charge --> In the browser tab title, it says 'Collect fine payment for ...' --> In the breadcrumbs, the last section is 'Pay an individual fine' --> The heading of the page is 'Pay an individual fine' --> The heading inside the payment tab is 'Pay an individual fine' 2.3. Click 'Cancel' and go back to the 'Make a payment' tab 3. Pay an amount toward all charges 3.1. Click 'Pay amount' --> In the browser tab title, it says 'Collect fine payment for ...' --> In the breadcrumbs, the last section is 'Pay an amount toward all fines' --> The heading of the page is 'Pay an amount toward all fines' --> The heading inside the payment tab is 'Pay an amount toward all fines' 3.2. Click 'Cancel' and go back to the 'Make a payment' tab 4. Pay an amount toward selected charges 4.1. Click 'Pay selected' --> In the browser tab title, it says 'Collect fine payment for ...' --> In the breadcrumbs, the last section is 'Pay an amount toward selected fines' --> The heading of the page is 'Pay an amount toward selected fines' --> The heading inside the payment tab is 'Pay an amount toward selected fines' 4.2. Click 'Cancel' and go back to the 'Make a payment' tab 5. Write off an individual charge 5.1. Click the 'Write off' button next to an individual charge --> In the browser tab title, it says 'Collect fine payment for ...' --> In the breadcrumbs, the last section is 'Write off an individual fine' --> The heading of the page is 'Write off an individual fine' --> The heading inside the payment tab is 'Write off an individual fine' 5.2. Click 'Cancel' and go back to the 'Make a payment' tab 6. Write off selected charges 6.1. Click 'Writeoff selected' --> In the browser tab title, it says 'Write off an amount for ...' --> In the breadcrumbs, the last section is 'Write off an amount toward selected fines' --> The heading of the page is 'Write off an amount toward selected fines' --> The heading inside the payment tab is 'Write off an amount toward selected fines' 6.2. Click 'Cancel' and go back to the 'Make a payment' tab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33056 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33056 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de QA Contact|testopia@bugs.koha-communit | |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33056 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33058 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33056 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33056 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 147740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147740&action=edit Bug 33056: Terminology: change 'fine' to 'charge'when making a payment or writeoff In the development meeting of Feb 22, 2023, we decided to change 'fine' to 'charge' when referring to various types of fees ('fine' should be limited to overdue fines). To test: 0. Go to patron's account accounting tab, Make a payment section --> It will read: X has no outstanding fines. 0.1 Create a manual invoice --> Use "Write off all" button, verify confirmation message says 'fines' 1. Add a manual fee to a patron's account 1.1. Go to a patron's account > Accounting tab 1.2. Click 'Create manual invoice' 1.3. Enter an amount 1.4. Click 'Save' 2. Pay an individual charge 2.1. Click 'Make a payment' 2.2. Click the 'Pay' button next to an individual charge --> In the browser tab title, it says 'Collect fine payment for ...' --> In the breadcrumbs, the last section is 'Pay an individual fine' --> The heading of the page is 'Pay an individual fine' --> The heading inside the payment tab is 'Pay an individual fine' 2.3. Click 'Cancel' and go back to the 'Make a payment' tab 3. Pay an amount toward all charges 3.1. Click 'Pay amount' --> In the browser tab title, it says 'Collect fine payment for ...' --> In the breadcrumbs, the last section is 'Pay an amount toward all fines' --> The heading of the page is 'Pay an amount toward all fines' --> The heading inside the payment tab is 'Pay an amount toward all fines' 3.2. Click 'Cancel' and go back to the 'Make a payment' tab 4. Pay an amount toward selected charges 4.1. Click 'Pay selected' --> In the browser tab title, it says 'Collect fine payment for ...' --> In the breadcrumbs, the last section is 'Pay an amount toward selected fines' --> The heading of the page is 'Pay an amount toward selected fines' --> The heading inside the payment tab is 'Pay an amount toward selected fines' 4.2. Click 'Cancel' and go back to the 'Make a payment' tab 5. Write off an individual charge 5.1. Click the 'Write off' button next to an individual charge --> In the browser tab title, it says 'Collect fine payment for ...' --> In the breadcrumbs, the last section is 'Write off an individual fine' --> The heading of the page is 'Write off an individual fine' --> The heading inside the payment tab is 'Write off an individual fine' 5.2. Click 'Cancel' and go back to the 'Make a payment' tab 6. Write off selected charges 6.1. Click 'Writeoff selected' --> In the browser tab title, it says 'Write off an amount for ...' --> In the breadcrumbs, the last section is 'Write off an amount toward selected fines' --> The heading of the page is 'Write off an amount toward selected fines' --> The heading inside the payment tab is 'Write off an amount toward selected fines' 6.2. Click 'Cancel' and go back to the 'Make a payment' tab 7. Apply patch and repeat --> All fines should now be charges. https://bugs.koha-community.org/show_bug.cgi?id=33058 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33056 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch on the right bug now :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33056 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33056 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147740|0 |1 is obsolete| | --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 147742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147742&action=edit Bug 33056: Terminology: change 'fine' to 'charge'when making a payment or writeoff In the development meeting of Feb 22, 2023, we decided to change 'fine' to 'charge' when referring to various types of fees ('fine' should be limited to overdue fines). To test: 0. Go to patron's account accounting tab, Make a payment section --> It will read: X has no outstanding fines. 0.1 Create a manual invoice --> Use "Write off all" button, verify confirmation message says 'fines' 1. Add a manual fee to a patron's account 1.1. Go to a patron's account > Accounting tab 1.2. Click 'Create manual invoice' 1.3. Enter an amount 1.4. Click 'Save' 2. Pay an individual charge 2.1. Click 'Make a payment' 2.2. Click the 'Pay' button next to an individual charge --> In the browser tab title, it says 'Collect fine payment for ...' --> In the breadcrumbs, the last section is 'Pay an individual fine' --> The heading of the page is 'Pay an individual fine' --> The heading inside the payment tab is 'Pay an individual fine' 2.3. Click 'Cancel' and go back to the 'Make a payment' tab 3. Pay an amount toward all charges 3.1. Click 'Pay amount' --> In the browser tab title, it says 'Collect fine payment for ...' --> In the breadcrumbs, the last section is 'Pay an amount toward all fines' --> The heading of the page is 'Pay an amount toward all fines' --> The heading inside the payment tab is 'Pay an amount toward all fines' 3.2. Click 'Cancel' and go back to the 'Make a payment' tab 4. Pay an amount toward selected charges 4.1. Click 'Pay selected' --> In the browser tab title, it says 'Collect fine payment for ...' --> In the breadcrumbs, the last section is 'Pay an amount toward selected fines' --> The heading of the page is 'Pay an amount toward selected fines' --> The heading inside the payment tab is 'Pay an amount toward selected fines' 4.2. Click 'Cancel' and go back to the 'Make a payment' tab 5. Write off an individual charge 5.1. Click the 'Write off' button next to an individual charge --> In the browser tab title, it says 'Collect fine payment for ...' --> In the breadcrumbs, the last section is 'Write off an individual fine' --> The heading of the page is 'Write off an individual fine' --> The heading inside the payment tab is 'Write off an individual fine' 5.2. Click 'Cancel' and go back to the 'Make a payment' tab 6. Write off selected charges 6.1. Click 'Writeoff selected' --> In the browser tab title, it says 'Write off an amount for ...' --> In the breadcrumbs, the last section is 'Write off an amount toward selected fines' --> The heading of the page is 'Write off an amount toward selected fines' --> The heading inside the payment tab is 'Write off an amount toward selected fines' 6.2. Click 'Cancel' and go back to the 'Make a payment' tab 7. Apply patch and repeat --> All fines should now be charges. https://bugs.koha-community.org/show_bug.cgi?id=33058 Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33056 --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I assumed the patch didn't change when it was attached to this bug report from bug 33058. I had already tested and signed it off right away -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33056 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147742|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148254&action=edit Bug 33056: Terminology: change 'fine' to 'charge'when making a payment or writeoff In the development meeting of Feb 22, 2023, we decided to change 'fine' to 'charge' when referring to various types of fees ('fine' should be limited to overdue fines). To test: 0. Go to patron's account accounting tab, Make a payment section --> It will read: X has no outstanding fines. 0.1 Create a manual invoice --> Use "Write off all" button, verify confirmation message says 'fines' 1. Add a manual fee to a patron's account 1.1. Go to a patron's account > Accounting tab 1.2. Click 'Create manual invoice' 1.3. Enter an amount 1.4. Click 'Save' 2. Pay an individual charge 2.1. Click 'Make a payment' 2.2. Click the 'Pay' button next to an individual charge --> In the browser tab title, it says 'Collect fine payment for ...' --> In the breadcrumbs, the last section is 'Pay an individual fine' --> The heading of the page is 'Pay an individual fine' --> The heading inside the payment tab is 'Pay an individual fine' 2.3. Click 'Cancel' and go back to the 'Make a payment' tab 3. Pay an amount toward all charges 3.1. Click 'Pay amount' --> In the browser tab title, it says 'Collect fine payment for ...' --> In the breadcrumbs, the last section is 'Pay an amount toward all fines' --> The heading of the page is 'Pay an amount toward all fines' --> The heading inside the payment tab is 'Pay an amount toward all fines' 3.2. Click 'Cancel' and go back to the 'Make a payment' tab 4. Pay an amount toward selected charges 4.1. Click 'Pay selected' --> In the browser tab title, it says 'Collect fine payment for ...' --> In the breadcrumbs, the last section is 'Pay an amount toward selected fines' --> The heading of the page is 'Pay an amount toward selected fines' --> The heading inside the payment tab is 'Pay an amount toward selected fines' 4.2. Click 'Cancel' and go back to the 'Make a payment' tab 5. Write off an individual charge 5.1. Click the 'Write off' button next to an individual charge --> In the browser tab title, it says 'Collect fine payment for ...' --> In the breadcrumbs, the last section is 'Write off an individual fine' --> The heading of the page is 'Write off an individual fine' --> The heading inside the payment tab is 'Write off an individual fine' 5.2. Click 'Cancel' and go back to the 'Make a payment' tab 6. Write off selected charges 6.1. Click 'Writeoff selected' --> In the browser tab title, it says 'Write off an amount for ...' --> In the breadcrumbs, the last section is 'Write off an amount toward selected fines' --> The heading of the page is 'Write off an amount toward selected fines' --> The heading inside the payment tab is 'Write off an amount toward selected fines' 6.2. Click 'Cancel' and go back to the 'Make a payment' tab 7. Apply patch and repeat --> All fines should now be charges. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33056 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize@ptfs-europe | |.com CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Woop, Woop.. we're getting there with these now. Great work PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33056 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33056 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33056 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33056 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33056 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org