https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33058 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33058 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33058 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 147264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147264&action=edit Bug 33056: Terminology: change 'fine' to 'charge'when making a payment or writeoff In the development meeting of Feb 22, 2023, we decided to change 'fine' to 'charge' when referring to various types of fees ('fine' should be limited to overdue fines). To test: 0. Go to patron's account accounting tab, Make a payment section --> It will read: X has no outstanding fines. 0.1 Create a manual invoice --> Use "Write off all" button, verify confirmation message says 'fines' 1. Add a manual fee to a patron's account 1.1. Go to a patron's account > Accounting tab 1.2. Click 'Create manual invoice' 1.3. Enter an amount 1.4. Click 'Save' 2. Pay an individual charge 2.1. Click 'Make a payment' 2.2. Click the 'Pay' button next to an individual charge --> In the browser tab title, it says 'Collect fine payment for ...' --> In the breadcrumbs, the last section is 'Pay an individual fine' --> The heading of the page is 'Pay an individual fine' --> The heading inside the payment tab is 'Pay an individual fine' 2.3. Click 'Cancel' and go back to the 'Make a payment' tab 3. Pay an amount toward all charges 3.1. Click 'Pay amount' --> In the browser tab title, it says 'Collect fine payment for ...' --> In the breadcrumbs, the last section is 'Pay an amount toward all fines' --> The heading of the page is 'Pay an amount toward all fines' --> The heading inside the payment tab is 'Pay an amount toward all fines' 3.2. Click 'Cancel' and go back to the 'Make a payment' tab 4. Pay an amount toward selected charges 4.1. Click 'Pay selected' --> In the browser tab title, it says 'Collect fine payment for ...' --> In the breadcrumbs, the last section is 'Pay an amount toward selected fines' --> The heading of the page is 'Pay an amount toward selected fines' --> The heading inside the payment tab is 'Pay an amount toward selected fines' 4.2. Click 'Cancel' and go back to the 'Make a payment' tab 5. Write off an individual charge 5.1. Click the 'Write off' button next to an individual charge --> In the browser tab title, it says 'Collect fine payment for ...' --> In the breadcrumbs, the last section is 'Write off an individual fine' --> The heading of the page is 'Write off an individual fine' --> The heading inside the payment tab is 'Write off an individual fine' 5.2. Click 'Cancel' and go back to the 'Make a payment' tab 6. Write off selected charges 6.1. Click 'Writeoff selected' --> In the browser tab title, it says 'Write off an amount for ...' --> In the breadcrumbs, the last section is 'Write off an amount toward selected fines' --> The heading of the page is 'Write off an amount toward selected fines' --> The heading inside the payment tab is 'Write off an amount toward selected fines' 6.2. Click 'Cancel' and go back to the 'Make a payment' tab 7. Apply patch and repeat --> All fines should now be charges. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33058 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Are both patches supposed to be on this bug report? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33058 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147262|0 |1 is obsolete| | --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 147737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147737&action=edit Bug 33058: Update "fines" to "charges" for viewing a guarantees charges Charges includes fines and fees, while fines are mostly negative. Changing this according to our terminology guidelines. To test: * Make sure the patron category of your patron is set to be 'can be guarantee' in administration * Set AllowStaffToSetFinesVisibilityForGuarantor and AllowPatronToSetFinesVisibilityForGuarantor to allow * Set OpacPrivacy to allow * Edit your patron, give it a guarantor and look at the "Show fines to guarantors setting" and hint * Save and look at the label of the field on the details tab * Go to the OPAC and log in * Check the Privavy tab for the option to allow the guarantee to see your charges * Apply patch. Verify: * System preference descriptions changes * Option and label names have changed in all steps above Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33058 --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I tried to sign off the second patch and attach it to the other bug report, but it told me that was illegal :) But I looked at all the strings and it was ok -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33058 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147264|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33058 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147737|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148232&action=edit Bug 33058: Update "fines" to "charges" for viewing a guarantees charges Charges includes fines and fees, while fines are mostly negative. Changing this according to our terminology guidelines. To test: * Make sure the patron category of your patron is set to be 'can be guarantee' in administration * Set AllowStaffToSetFinesVisibilityForGuarantor and AllowPatronToSetFinesVisibilityForGuarantor to allow * Set OpacPrivacy to allow * Edit your patron, give it a guarantor and look at the "Show fines to guarantors setting" and hint * Save and look at the label of the field on the details tab * Go to the OPAC and log in * Check the Privavy tab for the option to allow the guarantee to see your charges * Apply patch. Verify: * System preference descriptions changes * Option and label names have changed in all steps above Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33058 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33058 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33058 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.