[Bug 29311] New: Do not allow editing of bibliographic information when entering suggestion from existing bibs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Bug ID: 29311 Summary: Do not allow editing of bibliographic information when entering suggestion from existing bibs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When a patron makes a suggestion from an existing bib, the patron is allowed to edit the bibliographic information in the suggestion. This leads to confusion, since the suggestion is still tied to the original bib. To recreate: - find a record in the OPAC - click Suggest for Purchase - delete the title, author, ISBN, etc that have been pre-populated from the original bib - fill out a suggestion for an entirely different book - submit - go to your purchase suggestion in your account on the OPAC. See the title you entered, observe it links to the bib you started from - go over to the staff side and Accept your suggestion - put your suggestion into a basket - observe your order is for the original bib but your suggestion still shows the new title The simplest answer I see here is to just not allowing editing of those fields when making a suggestion from an existing title. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14963 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 [Bug 14963] Add the ability to suggest purchase from existing titles -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29416 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremy.breuillard@biblibre. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 --- Comment #1 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- Created attachment 133120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133120&action=edit Bug 29311: Do not allow editing of bibliographic information when entering suggestion from existing bibs This patch changes the behavior of the suggestion form in OPAC. The suggestion form for an existing record has its total of inputs limited, otherwise the inputs are all available. Test plan: 1)OPAC: Login to your OPAC account 2)Choose a record and get onto its details page 3)Click 'suggest for purchase' 4)Notice: all the fields can be modified 5)Apply patch 6)Repeat 2) and 3) or refresh 7)You see that the fields about bibliographic informations are disabled now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jeremy.breuillard@biblibre. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133120|0 |1 is obsolete| | --- Comment #2 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 134531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134531&action=edit Bug 29311: Do not allow editing of bibliographic information when entering suggestion from existing bibs This patch changes the behavior of the suggestion form in OPAC. The suggestion form for an existing record has its total of inputs limited, otherwise the inputs are all available. Test plan: 1)OPAC: Login to your OPAC account 2)Choose a record and get onto its details page 3)Click 'suggest for purchase' 4)Notice: all the fields can be modified 5)Apply patch 6)Repeat 2) and 3) or refresh 7)You see that the fields about bibliographic informations are disabled now Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #3 from Séverine Queune <severine.queune@bulac.fr> --- Thank you Jérémy, everything seems to work as expected, I didn't notice strange behaviours Maybe just a tiny modification could be done when using OPACSuggestionMandatoryFields syspref : as field can't be modified, could the 'Required' mention be hidden ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jeremy, Why do we not disable the form fields in the template instead of relying on the JavaScript do do it? And I think that would also work with Severine's request, as we then could and shoudl remove the class="required" in the form. + [% IF ( biblionumber ) %] + <label for="publishercode" class="required">Publisher:</label> + [% publishercode | html %] + [% ELSIF ( publishercode_required ) %] I feel like class="required" should be removed here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED CC| |julian.maurice@biblibre.com Assignee|jeremy.breuillard@biblibre. |julian.maurice@biblibre.com |com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28844 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134531|0 |1 is obsolete| | --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 146849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146849&action=edit Bug 29311: Forbid editing biblio info when creating suggestion for biblio When creating a suggestion for an existing biblio, biblio info like title or author should not be editable. Test plan: 1. Enable system preference 'suggestion' 2. Log in at OPAC 3. Go to a biblio record detail page 4. Click 'suggest for purchase' 5. Notice that all fields can be modified (title, author, ...) 6. Apply patch 7. Repeat steps 2 and 3 or refresh the page 8. Verify that the biblio fields cannot be modified now. The only fields that should be editable are: quantity, item type, library, reason for suggestion, and notes Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Katrin Fischer from comment #5)
Why do we not disable the form fields in the template instead of relying on the JavaScript do do it?
You're right. The javascript code was completely unnecessary. It was probably the remains of the first version of this patch :)
And I think that would also work with Severine's request, as we then could and shoudl remove the class="required" in the form.
Lazy copy/paste. Fixed in the latest patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146849|0 |1 is obsolete| | --- Comment #8 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 148776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148776&action=edit Bug 29311: Forbid editing biblio info when creating suggestion for biblio When creating a suggestion for an existing biblio, biblio info like title or author should not be editable. Test plan: 1. Enable system preference 'suggestion' 2. Log in at OPAC 3. Go to a biblio record detail page 4. Click 'suggest for purchase' 5. Notice that all fields can be modified (title, author, ...) 6. Apply patch 7. Repeat steps 2 and 3 or refresh the page 8. Verify that the biblio fields cannot be modified now. The only fields that should be editable are: quantity, item type, library, reason for suggestion, and notes Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148776|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148922&action=edit Bug 29311: Forbid editing biblio info when creating suggestion for biblio When creating a suggestion for an existing biblio, biblio info like title or author should not be editable. Test plan: 1. Enable system preference 'suggestion' 2. Log in at OPAC 3. Go to a biblio record detail page 4. Click 'suggest for purchase' 5. Notice that all fields can be modified (title, author, ...) 6. Apply patch 7. Repeat steps 2 and 3 or refresh the page 8. Verify that the biblio fields cannot be modified now. The only fields that should be editable are: quantity, item type, library, reason for suggestion, and notes Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148923&action=edit Bug 29311: (QA follow-up) Fix an existing spelling typo -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148924&action=edit Bug 29311: (QA follow-up) Fix filter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like this breaks a selenium test: t/db_dependent/selenium/regressions.t .. 7/8 STRACE: /usr/share/perl5/Try/Tiny.pm:123 in Selenium::Remote::Driver::catch {...} /usr/share/perl5/Selenium/Remote/Driver.pm:361 in Try::Tiny::try (eval 549):1 in Selenium::Remote::Driver::__ANON__ (eval 551):2 in Selenium::Remote::Driver::__ANON__ /usr/share/perl5/Selenium/Remote/Driver.pm:1340 in Selenium::Remote::Driver::_execute_command /usr/share/perl5/Selenium/Remote/Driver.pm:1340 in (eval) t/db_dependent/selenium/regressions.t:358 in Selenium::Remote::Driver::find_element /usr/share/perl/5.32/Test/Builder.pm:334 in main::__ANON__ /usr/share/perl/5.32/Test/Builder.pm:334 in (eval) /usr/share/perl/5.32/Test/More.pm:809 in Test::Builder::subtest t/db_dependent/selenium/regressions.t:372 in Test::More::subtest # No tests run! t/db_dependent/selenium/regressions.t .. 8/8 # Failed test 'No tests run for subtest "OPAC - Suggest for purchase"' # at t/db_dependent/selenium/regressions.t line 372. Error while executing command: no such element: Unable to locate element: //input[@id="title"] at /usr/share/perl5/Selenium/Remote/Driver.pm line 411. at /usr/share/perl5/Selenium/Remote/Driver.pm line 356. # Looks like your test exited with 11 just after 8. The test looks for an input field, but with this patch applied, there is no longer any input, just this: <label>Title:</label> <a href="/cgi-bin/koha/opac-detail.pl?biblionumber=1">E Street shuffle :</a> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149391&action=edit Bug 29311: (follow-up) Add id to span elements The input fields in the form have ids, these are useful for styling, but also for the Selenium tests. This patch adds the ids from the former inputs to the now spans. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149392&action=edit Bug 29311: (follow-up) Fix t/db_dependent/selenium/regressions.t The test was checking for the value of an input field. But with this patch set, there is no longer an input, but a link element with the title. This adjusts the patch to look for the correct element. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | CC| |jonathan.druart+koha@gmail. | |com --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Last two patches pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 --- Comment #17 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.13 released in| | --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05,22.05.13 |23.05.00,22.11.05,22.05.13, released in| |21.11.21 CC| |arthur.suzuki@biblibre.com --- Comment #19 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11 for 21.11.21 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org