[Bug 27513] New: Add description to Reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Bug ID: 27513 Summary: Add description to Reports page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: christofer.zorn@ajaxlibrary.ca QA Contact: testopia@bugs.koha-community.org Hello! Is it possible to add the report Notes field (which appears on the Edit and results page) to the parameters page? As an Admin, I can see the details of the notes and remember what the report does and why, but for the normal user, there might be beneficial notes or reminders that can be put there (i.e. This report runs for the last month, or last two years). Not a huge change, but could be helpful. Thanks Christofer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- +1 You might also make notes on how to use the form fields in the notes and it would be helpful to see those earlier. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add description to Reports |Add description to reports |page |page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |philip.orr@lmscloud.de |ity.org | CC| |philip.orr@lmscloud.de --- Comment #2 from Philip Orr <philip.orr@lmscloud.de> --- Looks like the template file for the Report parameters page actually already had TT code to display the notes field, it just wasn't getting the TT variable 'notes' from guided_reports.pl. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 --- Comment #3 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 149012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149012&action=edit Bug 27513: Add notes to variables for report parameters template This patch adds the TT variable 'notes' to the variables that guided_reports.pl passes to the template guided_reports_start.tt during SQL parameters entry in the phase 'Run this report'. To test: 1. apply the patch 2. navigate to Reports -> Guided Reports -> Create from SQL 3. create an SQL report that includes at least one parameter, e.g.: SELECT barcode FROM items WHERE homebranch=<<Select library|branches>> the actual SQL and name of the report doesn't matter much, just make sure that you also put a note e.g. "Test text for display" in the field "Notes:" before you save the report. 4. run the report 5. the note you entered should now be displayed below the heading "Enter parameters for report..." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149012|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 149068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149068&action=edit Bug 27513: Add notes to variables for report parameters template This patch adds the TT variable 'notes' to the variables that guided_reports.pl passes to the template guided_reports_start.tt during SQL parameters entry in the phase 'Run this report'. To test: 1. apply the patch 2. navigate to Reports -> Guided Reports -> Create from SQL 3. create an SQL report that includes at least one parameter, e.g.: SELECT barcode FROM items WHERE homebranch=<<Select library|branches>> the actual SQL and name of the report doesn't matter much, just make sure that you also put a note e.g. "Test text for display" in the field "Notes:" before you save the report. 4. run the report 5. the note you entered should now be displayed below the heading "Enter parameters for report..." Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Not related to this bug, but on the reports results page, the text for 'Notes:' and 'Total number of results:' aren't aligned with the labels (the text is slightly higher than the labels). Not sure whether there is already a bug for this or not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Simple fix that works as described, no issues from the QA scripts. Like David mentions, the display is a bit weird. The notes are also lacking a label, "Notes: ", when entering parameters. I think we can address that all in another bug. This gets the notes on the page so we should move it along! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149068|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 149149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149149&action=edit Bug 27513: Add notes to variables for report parameters template This patch adds the TT variable 'notes' to the variables that guided_reports.pl passes to the template guided_reports_start.tt during SQL parameters entry in the phase 'Run this report'. To test: 1. apply the patch 2. navigate to Reports -> Guided Reports -> Create from SQL 3. create an SQL report that includes at least one parameter, e.g.: SELECT barcode FROM items WHERE homebranch=<<Select library|branches>> the actual SQL and name of the report doesn't matter much, just make sure that you also put a note e.g. "Test text for display" in the field "Notes:" before you save the report. 4. run the report 5. the note you entered should now be displayed below the heading "Enter parameters for report..." Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara@ptfs-europe.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 --- Comment #9 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.13 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #11 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Minor, won't backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05,22.05.13 |23.05.00,22.11.05,22.05.13, released in| |21.11.21 --- Comment #12 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- actually minors should also be backported for oldstable : try and backport regardless of severity. Applied to 21.11 for 21.11.21 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org