[Bug 7934] New: Separate po file for help pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 Priority: P5 - low Change sponsored?: --- Bug ID: 7934 Assignee: frederic@tamil.fr Summary: Separate po file for help pages QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: katrin.fischer@bsz-bw.de Hardware: All Status: NEW Version: master Component: I18N/L10N Product: Koha I propose to split the help files out of the po file for the staff interface. It would allow to prioritise while working on translations and reduce the size of our biggest po file. A possible workflow for translators then could be: 1) Translate the OPAC, because patrons come first :) 2) Translate the staff interface, so staff can start using Koha and all buttons and links have their correct translated names 3) Translate help files while being able to look at the translated interfaces for the right names of elements -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7939 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #1 from Magnus Enger <magnus@enger.priv.no> --- This sounds like an excellent idea! And it reminded me of another old idea which is now Bug 7939 - Separate po files for different MARC dialects. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge@regionhalland. | |se --- Comment #2 from Viktor Sarge <viktor.sarge@regionhalland.se> --- This sounds like a great idea - how much work is it, and who needs to have a say in this? We will start a paid transation this winter and it would be great to be able to secure that the interface is translated first. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 23314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23314&action=edit Bug 7934 - Separate po file for help pages This patch modifies LangInstaller.pm to enable separation of translation for Staff UI and Staff Help files. It's a move that make sense, Help strings accounts for 44% of total word count for Staff, and as stated on Comment #1, it could enable a different workflow on translation work. It's more a hack than an elegant solution, but it works. Feel free to suggest another approach. To test: We need to test complete functionality, i.e. create and update translation files and install translation, and verify that no string is missing. 1) Before applying the patch, we need some data from staff file. Pick your language, say de_DE, and cd misc/translator/ perl translate update de-DE msginit -i po/de-DE-i-staff-t-prog-v-3006000.po -o de-old.po --no-translator --no-wrap --locale=de_DE egrep ^msgid de-old.po | sort | tee s-old | wc -l > number-old We have the file s-old with all strings, and the number of strings on number-old 2) Apply the patch 3) New help file is called de-DE-staff-help.po, so create one cp'ing old staff on new help cp po/de-DE-i-staff-t-prog-v-3006000.po po/de-DE-staff-help.po 4) Make a new update, and analize perl translate update de-DE msginit -i po/de-DE-i-staff-t-prog-v-3006000.po -o de-new.po --no-translator --no-wrap --locale=de_DE msginit -i po/de-DE-staff-help.po -o de-help.po --no-translator --no-wrap --locale=de_DE egrep ^msgid de-new.po | sort | tee s-new | wc -l > number-new egrep ^msgid de-help.po | sort | tee s-help | wc -l > number-help cat s-new s-help | sort | uniq | tee s-all | wc -l > number-all cat s-new s-help | sort | uniq -d | tee s-dup | wc -l > number-dup Ideally what we need to found is: diff s-old s-all = zero lines (old strings vs new strings) In my test I got one line, but it's a false positive (the string "• " is present on new staff) On numbers, number-old - number-new - nummber-help + number-dup = 0 or number-old - number-all = 0 (in my test again I have 1 as result, same string. Also there are 137 repeated lines between new staff and help) All this tells me that all string to translate are preserved 5) Install translation perl translate install de-DE Enable language on staff, and check that help files are translated 6) Finally, create translation files rm po/de-DE-* perl translate create de-DE verify that all files are created. Tests of 4) can be repeated. 7) Verify that no strings from help are present on staff UI file egrep help po/de-DE-i-staff-t-prog-v-3006000.po Only results came from help-top and bottom, and a few "help" on staff strings -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23314|0 |1 is obsolete| | --- Comment #4 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 23358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23358&action=edit Bug 7934 - Separate po file for help pages This patch modifies LangInstaller.pm to enable separation of translation for Staff UI and Staff Help files. It's a move that make sense, Help strings accounts for 44% of total word count for Staff, and as stated on Comment #1, it could enable a different workflow on translation work. It's more a hack than an elegant solution, but it works. Feel free to suggest another approach. To test: We need to test complete functionality, i.e. create and update translation files and install translation, and verify that no string is missing. 1) Before applying the patch, we need some data from staff file. Pick your language, say de_DE, and cd misc/translator/ perl translate update de-DE msginit -i po/de-DE-i-staff-t-prog-v-3006000.po -o de-old.po --no-translator --no-wrap --locale=de_DE egrep ^msgid de-old.po | sort | tee s-old | wc -l > number-old We have the file s-old with all strings, and the number of strings on number-old 2) Apply the patch 3) New help file is called de-DE-staff-help.po, so create one cp'ing old staff on new help cp po/de-DE-i-staff-t-prog-v-3006000.po po/de-DE-staff-help.po 4) Make a new update, and analize perl translate update de-DE msginit -i po/de-DE-i-staff-t-prog-v-3006000.po -o de-new.po --no-translator --no-wrap --locale=de_DE msginit -i po/de-DE-staff-help.po -o de-help.po --no-translator --no-wrap --locale=de_DE egrep ^msgid de-new.po | sort | tee s-new | wc -l > number-new egrep ^msgid de-help.po | sort | tee s-help | wc -l > number-help cat s-new s-help | sort | uniq | tee s-all | wc -l > number-all cat s-new s-help | sort | uniq -d | tee s-dup | wc -l > number-dup Ideally what we need to found is: diff s-old s-all = zero lines (old strings vs new strings) In my test I got one line, but it's a false positive (the string "• " is present on new staff) On numbers, number-old - number-new - nummber-help + number-dup = 0 or number-old - number-all = 0 (in my test again I have 1 as result, same string. Also there are 137 repeated lines between new staff and help) All this tells me that all string to translate are preserved 5) Install translation perl translate install de-DE Enable language on staff, and check that help files are translated 6) Finally, create translation files rm po/de-DE-* perl translate create de-DE verify that all files are created. Tests of 4) can be repeated. 7) Verify that no strings from help are present on staff UI file egrep help po/de-DE-i-staff-t-prog-v-3006000.po Only results came from help-top and bottom, and a few "help" on staff strings Signed-off-by: Fridolyn SOMERS <fridolyn.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Tested with fr-FR, works fine. I had same false alert with string "• ". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23358|Bug 7934 - Separate po file |[SIGNED-OFF]Bug 7934 - description|for help pages |Separate po file for help | |pages -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23556&action=edit [PASSED QA] Bug 7934 - Separate po file for help pages This patch modifies LangInstaller.pm to enable separation of translation for Staff UI and Staff Help files. It's a move that make sense, Help strings accounts for 44% of total word count for Staff, and as stated on Comment #1, it could enable a different workflow on translation work. It's more a hack than an elegant solution, but it works. Feel free to suggest another approach. To test: We need to test complete functionality, i.e. create and update translation files and install translation, and verify that no string is missing. 1) Before applying the patch, we need some data from staff file. Pick your language, say de_DE, and cd misc/translator/ perl translate update de-DE msginit -i po/de-DE-i-staff-t-prog-v-3006000.po -o de-old.po --no-translator --no-wrap --locale=de_DE egrep ^msgid de-old.po | sort | tee s-old | wc -l > number-old We have the file s-old with all strings, and the number of strings on number-old 2) Apply the patch 3) New help file is called de-DE-staff-help.po, so create one cp'ing old staff on new help cp po/de-DE-i-staff-t-prog-v-3006000.po po/de-DE-staff-help.po 4) Make a new update, and analize perl translate update de-DE msginit -i po/de-DE-i-staff-t-prog-v-3006000.po -o de-new.po --no-translator --no-wrap --locale=de_DE msginit -i po/de-DE-staff-help.po -o de-help.po --no-translator --no-wrap --locale=de_DE egrep ^msgid de-new.po | sort | tee s-new | wc -l > number-new egrep ^msgid de-help.po | sort | tee s-help | wc -l > number-help cat s-new s-help | sort | uniq | tee s-all | wc -l > number-all cat s-new s-help | sort | uniq -d | tee s-dup | wc -l > number-dup Ideally what we need to found is: diff s-old s-all = zero lines (old strings vs new strings) In my test I got one line, but it's a false positive (the string "• " is present on new staff) On numbers, number-old - number-new - nummber-help + number-dup = 0 or number-old - number-all = 0 (in my test again I have 1 as result, same string. Also there are 137 repeated lines between new staff and help) All this tells me that all string to translate are preserved 5) Install translation perl translate install de-DE Enable language on staff, and check that help files are translated 6) Finally, create translation files rm po/de-DE-* perl translate create de-DE verify that all files are created. Tests of 4) can be repeated. 7) Verify that no strings from help are present on staff UI file egrep help po/de-DE-i-staff-t-prog-v-3006000.po Only results came from help-top and bottom, and a few "help" on staff strings Signed-off-by: Fridolyn SOMERS <fridolyn.somers@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested according to test plan. Checked various pages in OPAC, staff and intranet, translation was ok. Passes QA script and tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23358|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|frederic@tamil.fr |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- This patch introduces a regression. See bug 11571. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11571 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #9 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- I've choosen to not backport this to 3.14.x to not impact the translators behaviors. This translation change is now in 3.16. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org