[Bug 11571] New: Bug 7934 introduces a regression in the translate script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571 Bug ID: 11571 Summary: Bug 7934 introduces a regression in the translate script Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Bug 7934 breaks the -f option introduced by bug 9161. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24459&action=edit Bug 11571: FIX regression introduced by bug 7934 Bug 7934 breaks the -f option introduced by bug 9161. While the generation of the command tmpl_process3.pl, a space is missing if the -x option is given. The tmpl_process3.pl is called like: /home/koha/src/misc/translator/tmpl_process3.pl -q update -i /home/koha/src/koha-tmpl/intranet-tmpl/prog/en/ -s /home/koha/src/misc/translator/po/fr-FR-i-staff-t-prog-v-3006000.po -r -x 'help'-f pay.tt Test plan: - ./translate update fr-FR -f pay.tt - put a warn at LangInstaller.pm line 375. - note the execution time and the output. The options in the command contain "-x 'help'-f pay.tt" The -f param is not passed to the script. - apply this patch and verify the output and the execution time is not correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m Depends on| |7934 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24459|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24484&action=edit Bug 11571: FIX regression introduced by bug 7934 Bug 7934 breaks the -f option introduced by bug 9161. While the generation of the command tmpl_process3.pl, a space is missing if the -x option is given. The tmpl_process3.pl is called like: /home/koha/src/misc/translator/tmpl_process3.pl -q update -i /home/koha/src/koha-tmpl/intranet-tmpl/prog/en/ -s /home/koha/src/misc/translator/po/fr-FR-i-staff-t-prog-v-3006000.po -r -x 'help'-f pay.tt Test plan: - ./translate update fr-FR -f pay.tt - put a warn at LangInstaller.pm line 375. - note the execution time and the output. The options in the command contain "-x 'help'-f pay.tt" The -f param is not passed to the script. - apply this patch and verify the output and the execution time is now correct. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Second patch replaces 'not' with 'now' in the commit message... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Since it is a regression, easier to test and makes me waste a lot of time (on testing translation), I consider this bug as major. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- s/easier/easy -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24484|0 |1 is obsolete| | --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24706 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24706&action=edit [SIGNED OFF] Bug 11571 - FIX regression introduced by bug 7934 Bug 7934 breaks the -f option introduced in bug 9161. While the generation of the command tmpl_process3.pl, a space is missing if the -x option is given. The tmpl_process3.pl is called like: /home/koha/src/misc/translator/tmpl_process3.pl -q update -i /home/koha/src/koha-tmpl/intranet-tmpl/prog/en/ -s /home/koha/src/misc/translator/po/fr-FR-i-staff-t-prog-v-3006000.po -r -x 'help'-f pay.tt Revised test plan: 1) cd ./misc/translator 2) put a warn at LangInstaller.pm line 375. 3) time ./translate update fr-FR -f pay.tt -- note the execution time and the output. The options in the command contain "-x 'help'-f pay.tt" The -f param is not passed to the script. The execution time is strangely long. 5) git reset --hard origin/master 6) apply this patch 7) put a warn at LangInstaller.pm line 375. 8) time ./translate update fr-FR -f pay.tt -- verify the output and the execution time is now corrected. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> ---
-- verify the output and the execution time is now corrected. s/is/are ...
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24706|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 24729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24729&action=edit [PASSED QA] Bug 11571 - FIX regression introduced by bug 7934 Bug 7934 breaks the -f option introduced in bug 9161. While the generation of the command tmpl_process3.pl, a space is missing if the -x option is given. The tmpl_process3.pl is called like: /home/koha/src/misc/translator/tmpl_process3.pl -q update -i /home/koha/src/koha-tmpl/intranet-tmpl/prog/en/ -s /home/koha/src/misc/translator/po/fr-FR-i-staff-t-prog-v-3006000.po -r -x 'help'-f pay.tt Revised test plan: 1) cd ./misc/translator 2) put a warn at LangInstaller.pm line 375. 3) time ./translate update fr-FR -f pay.tt -- note the execution time and the output. The options in the command contain "-x 'help'-f pay.tt" The -f param is not passed to the script. The execution time is strangely long. 5) git reset --hard origin/master 6) apply this patch 7) put a warn at LangInstaller.pm line 375. 8) time ./translate update fr-FR -f pay.tt -- verify the output and the execution time is now corrected. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571 Bug 11571 depends on bug 7934, which changed state. Bug 7934 Summary: Separate po file for help pages http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11571 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #10 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- I've choosen to not backport Bug 7934 to 3.14.x so this this resolved. This is now in 3.16.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org