[Bug 19983] New: Switch single-column templates to Bootstrap grid: Authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 Bug ID: 19983 Summary: Switch single-column templates to Bootstrap grid: Authorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 19785, 19786 Blocks: 19980 There are several single-column templates in the Authorities module which can be updated to use Bootstrap: authorities-home.tt authorities.tt blinddetail-biblio-search.tt detail.tt merge.tt searchresultlist.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 [Bug 19785] Move template JavaScript to the footer: Authorities, part 1 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19786 [Bug 19786] Move template JavaScript to the footer: Authorities, part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70693&action=edit Bug 19983: Switch single-column templates to Bootstrap grid: Authorities This patch updates several single-column Authorities module templates to use the Bootstrap grid. - authorities-home - The home page of the Authorities module. - authorities.tt - The authority add/edit page. - blinddetail-biblio-search.tt - Not really testable -- It's the small popup window which appears during the process of linking an authority to a MARC record. - detail.tt - The authority detail page. Search for an authority record and click on the "details" link in the search results. - merge.tt - From a list of authority search results, select "Merge" from the Actions menu of two authority records. Test both the initial selection screen and the source/destination merging view. - searchresultlist.tt - The authority search results page. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely@hotmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Patch does not apply fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- This applies cleanly for me (after some auto-merging). Can you try again? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70693|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 72510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72510&action=edit Bug 19983: Switch single-column templates to Bootstrap grid: Authorities This patch updates several single-column Authorities module templates to use the Bootstrap grid. - authorities-home - The home page of the Authorities module. - authorities.tt - The authority add/edit page. - blinddetail-biblio-search.tt - Not really testable -- It's the small popup window which appears during the process of linking an authority to a MARC record. - detail.tt - The authority detail page. Search for an authority record and click on the "details" link in the search results. - merge.tt - From a list of authority search results, select "Merge" from the Actions menu of two authority records. Test both the initial selection screen and the source/destination merging view. - searchresultlist.tt - The authority search results page. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roch.damour@inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Roch D'Amour <roch.damour@inlibro.com> --- Sorry, patch does not apply :( I get: fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Using git-bz with automatic dependency resolution this applies without any trouble for me on master. Did you apply the patch for Bug 19786 first? Thanks for testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72510|0 |1 is obsolete| | --- Comment #7 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 72626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72626&action=edit Bug 19983: Switch single-column templates to Bootstrap grid: Authorities This patch updates several single-column Authorities module templates to use the Bootstrap grid. - authorities-home - The home page of the Authorities module. - authorities.tt - The authority add/edit page. - blinddetail-biblio-search.tt - Not really testable -- It's the small popup window which appears during the process of linking an authority to a MARC record. - detail.tt - The authority detail page. Search for an authority record and click on the "details" link in the search results. - merge.tt - From a list of authority search results, select "Merge" from the Actions menu of two authority records. Test both the initial selection screen and the source/destination merging view. - searchresultlist.tt - The authority search results page. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 Bug 19983 depends on bug 19785, which changed state. Bug 19785 Summary: Move template JavaScript to the footer: Authorities, part 1 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72626|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73245&action=edit Bug 19983: Switch single-column templates to Bootstrap grid: Authorities This patch updates several single-column Authorities module templates to use the Bootstrap grid. - authorities-home - The home page of the Authorities module. - authorities.tt - The authority add/edit page. - blinddetail-biblio-search.tt - Not really testable -- It's the small popup window which appears during the process of linking an authority to a MARC record. - detail.tt - The authority detail page. Search for an authority record and click on the "details" link in the search results. - merge.tt - From a list of authority search results, select "Merge" from the Actions menu of two authority records. Test both the initial selection screen and the source/destination merging view. - searchresultlist.tt - The authority search results page. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 Bug 19983 depends on bug 19786, which changed state. Bug 19786 Summary: Move template JavaScript to the footer: Authorities, part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19786 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org