https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move template JavaScript to |Move template JavaScript to |the footer: UNIMARC editor |the footer: UNIMARC editor |plugins |plugins, part 1 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70069&action=edit Bug 19866: Move template JavaScript to the footer: UNIMARC editor plugins, part 1 This patch updates several UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin.

From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor.

- unimarc_field_100.tt - unimarc_field_100_authorities.tt - unimarc_field_105.tt - unimarc_field_106.tt - unimarc_field_110.tt - unimarc_field_115a.tt - unimarc_field_115b.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|19864 |19968 CC| |mtompset@hotmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19864 [Bug 19864] UNIMARC field 100 plugin broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19968 [Bug 19968] Undefined subroutine &Date::Calc::Today -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Here's a more thorough description of how this patch can be tested even if you don't have a UNIMARC system: - Go to Administration -> MARC frameworks -> Default framework -> MARC structure - For any tag (I like to use 000 because it's the first one), choose Actions -> Subfields. - Edit any subfield you want to configure (choose one that isn't hidden). - Expand the "Other options" panel and select the plugin you want to test under "Plugin." - Save changes. - Open an existing or new MARC record for editing in the standard MARC editor. - Find the tag and subfield you just modified, and look for the small plugin trigger icon next to the form field. - Confirm that clicking this link triggers the correct plugin (the pop-up window should have a heading with the correct plugin name). - Make some changes to the options in the plugin window in a way that you will be able to confirm the changes are transferred to the field in the MARC editor. For instance, choose all the same codes for multiple fields. - Submit your changes in the plugin's pop-up window. The window should close. - Confirm that the values you submitted from the plugin window have been transferred to the correct field in the MARC editor. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70069|0 |1 is obsolete| | --- Comment #3 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 72631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72631&action=edit Bug 19866: Move template JavaScript to the footer: UNIMARC editor plugins, part 1 This patch updates several UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin.

From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor.

- unimarc_field_100.tt - unimarc_field_100_authorities.tt - unimarc_field_105.tt - unimarc_field_106.tt - unimarc_field_110.tt - unimarc_field_115a.tt - unimarc_field_115b.tt Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19868 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868 [Bug 19868] Move template JavaScript to the footer: UNIMARC editor plugins, part 2 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |nick@bywatersolutions.com Resolution|--- |FIXED --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all, enhancement, not backported for stable -- You are receiving this mail because: You are watching all bug changes.