http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15314 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 45464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45464&action=edit Bug 15314 - Use Bootstrap modal for cataloging merge MARC preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the cataloging merge selection page so that the MARC preview is shown in a Boostrap modal. This patch also changes the preview link to be the text "View MARC" so that it is clear what it does. To test: 1. Apply the patch and navigate to Cataloging. 2. Perform a search which will return results from the catalog. 3. Select two records and click the "Merge selected" button to begin the merge process. 4. Test the "View MARC" link for both merge choices and confirm that the correct data is shown each time. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15314 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15314 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #3)

Shouldn't we apply the same change as what you suggest on bug 15327?

There are a few issues which need to be resolved before we can universally use the "viewas=html" paramter for showmarc.pl. I plan to address them in a future patch if you don't mind. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15314 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45473|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45588&action=edit Bug 15314: Use Bootstrap modal for cataloging merge MARC preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the cataloging merge selection page so that the MARC preview is shown in a Boostrap modal. This patch also changes the preview link to be the text "View MARC" so that it is clear what it does. To test: 1. Apply the patch and navigate to Cataloging. 2. Perform a search which will return results from the catalog. 3. Select two records and click the "Merge selected" button to begin the merge process. 4. Test the "View MARC" link for both merge choices and confirm that the correct data is shown each time. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15314 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45588|0 |1 is obsolete| | --- Comment #6 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 46061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46061&action=edit Bug 15314: Use Bootstrap modal for cataloging merge MARC preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the cataloging merge selection page so that the MARC preview is shown in a Boostrap modal. This patch also changes the preview link to be the text "View MARC" so that it is clear what it does. To test: 1. Apply the patch and navigate to Cataloging. 2. Perform a search which will return results from the catalog. 3. Select two records and click the "Merge selected" button to begin the merge process. 4. Test the "View MARC" link for both merge choices and confirm that the correct data is shown each time. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15314 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement CC| |julian.maurice@biblibre.com --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Switching severity to 'enhancement' as the patch does not fix any bug -- You are receiving this mail because: You are watching all bug changes.