[Bug 15313] New: Use Bootstrap modal for z39.50 search MARC and Card preview
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 Bug ID: 15313 Summary: Use Bootstrap modal for z39.50 search MARC and Card preview Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/cataloguing/z3950_search.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 8290 When performing a Z39.50 search in cataloging, the "MARC" and "Card" links should trigger previews in a Bootstrap modal instead of a Greybox modal. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 [Bug 8290] Replace usage of Greybox modals with Bootstrap modals -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 45423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45423&action=edit Bug 15313 - Use Bootstrap modal for z39.50 search MARC and Card preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the cataloging Z39.50 search results page so that "MARC" and "Card" previews are displayed in Bootstrap modals. Because the modal is triggered from a pop-up window, the modal has been reformated to exclude the footer and reduce the size of the modal header. To test: 1. Apply the patch and navigate to Cataloging. 2. Click the "New from Z39.50/SRU button to open the search window. 3. Perform any search which will return results. 4. Test the "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45423|0 |1 is obsolete| | --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 45429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45429&action=edit Bug 15313 - Use Bootstrap modal for z39.50 search MARC and Card preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the cataloging Z39.50 search results page so that "MARC" and "Card" previews are displayed in Bootstrap modals. Because the modal is triggered from a pop-up window, the modal has been reformated to exclude the footer and reduce the size of the modal header. To test: 1. Apply the patch and navigate to Cataloging. 2. Click the "New from Z39.50/SRU button to open the search window. 3. Perform any search which will return results. 4. Test the "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. Signed-off-by: Galen Charlton <gmcharlt@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Whoops, I see a mistake with this patch. I'll resubmit. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45429|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 45445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45445&action=edit Bug 15313 - Use Bootstrap modal for z39.50 search MARC and Card preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the cataloging Z39.50 search results page so that "MARC" and "Card" previews are displayed in Bootstrap modals. Because the modal is triggered from a pop-up window, the modal has been reformated to exclude the footer and reduce the size of the modal header. To test: 1. Apply the patch and navigate to Cataloging. 2. Click the "New from Z39.50/SRU button to open the search window. 3. Perform any search which will return results. 4. Test the visible "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. 5. Click anywhere in the results table to show the hidden menu and test the "MARC" and "Card" links it displays. Corrected: The original patch didn't address the hidden menu which appears if you click in any table cell. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45445|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 45454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45454&action=edit Bug 15313 - Use Bootstrap modal for z39.50 search MARC and Card preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the cataloging Z39.50 search results page so that "MARC" and "Card" previews are displayed in Bootstrap modals. Because the modal is triggered from a pop-up window, the modal has been reformated to exclude the footer and reduce the size of the modal header. To test: 1. Apply the patch and navigate to Cataloging. 2. Click the "New from Z39.50/SRU button to open the search window. 3. Perform any search which will return results. 4. Test the visible "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. 5. Click anywhere in the results table to show the hidden menu and test the "MARC" and "Card" links it displays. Corrected: The original patch didn't address the hidden menu which appears if you click in any table cell. Followed test plan, works as expected (including click in table cell). Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45454|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45586&action=edit Bug 15313 - Use Bootstrap modal for z39.50 search MARC and Card preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the cataloging Z39.50 search results page so that "MARC" and "Card" previews are displayed in Bootstrap modals. Because the modal is triggered from a pop-up window, the modal has been reformated to exclude the footer and reduce the size of the modal header. To test: 1. Apply the patch and navigate to Cataloging. 2. Click the "New from Z39.50/SRU button to open the search window. 3. Perform any search which will return results. 4. Test the visible "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. 5. Click anywhere in the results table to show the hidden menu and test the "MARC" and "Card" links it displays. Corrected: The original patch didn't address the hidden menu which appears if you click in any table cell. Followed test plan, works as expected (including click in table cell). Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45586|0 |1 is obsolete| | --- Comment #7 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 46060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46060&action=edit Bug 15313 - Use Bootstrap modal for z39.50 search MARC and Card preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the cataloging Z39.50 search results page so that "MARC" and "Card" previews are displayed in Bootstrap modals. Because the modal is triggered from a pop-up window, the modal has been reformated to exclude the footer and reduce the size of the modal header. To test: 1. Apply the patch and navigate to Cataloging. 2. Click the "New from Z39.50/SRU button to open the search window. 3. Perform any search which will return results. 4. Test the visible "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. 5. Click anywhere in the results table to show the hidden menu and test the "MARC" and "Card" links it displays. Corrected: The original patch didn't address the hidden menu which appears if you click in any table cell. Followed test plan, works as expected (including click in table cell). Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m --- Comment #8 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement CC| |julian.maurice@biblibre.com --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Switching severity to 'enhancement' as the patch does not fix any bug -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org