[Bug 21133] New: Missing use C4::Account statement in Koha/Patron.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Bug ID: 21133 Summary: Missing use C4::Account statement in Koha/Patron.pm Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77340&action=edit Bug 21133: Add missing use C4::Accounts statement in Koha/Patron.pm It's a follow-up of commit 9c6f634469de4364d71bc0eb7520d04ead61fd00 Bug 16912: Koha::Patrons - Move AddEnrolmentFeeIfNeeded to->add_enrolment_fee_if_needed One of the known issue:
update categories set enrolmentfee=2; The use misc/devel/create_superlibrarian.pl to create a new superlibrarian patron
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21087, 16912 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Should be backported if patches from bug 16912 are there. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 [Bug 16912] Koha::Patrons - Move AddEnrolmentFeeIfNeeded to add_enrolment_fee_if_needed https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21087 [Bug 21087] Patron's password is hashed twice when the object is saved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77340|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 77341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77341&action=edit Bug 21133: Add missing use C4::Accounts statement in Koha/Patron.pm It's a follow-up of commit 9c6f634469de4364d71bc0eb7520d04ead61fd00 Bug 16912: Koha::Patrons - Move AddEnrolmentFeeIfNeeded to->add_enrolment_fee_if_needed One of the known issue:
update categories set enrolmentfee=2; The use misc/devel/create_superlibrarian.pl to create a new superlibrarian patron
Signed-off-by: Victor Grousset <victor.grousset@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |victor.grousset@biblibre.co | |m --- Comment #4 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Fix confirmed. Without the patch I got {UNKNOWN}: Undefined subroutine &C4::Accounts::manualinvoice called at /home/koha/src/Koha/Patron.pm line 864. at /home/koha/src/Koha/Patron.pm line 347 With the patch, it now works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Missing use C4::Account |Missing use C4::Accountz |statement in Koha/Patron.pm |statement in Koha/Patron.pm CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Missing use C4::Accountz |Missing use C4::Accounts |statement in Koha/Patron.pm |statement in Koha/Patron.pm Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77341|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 77344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77344&action=edit Bug 21133: Add missing use C4::Accounts statement in Koha/Patron.pm It's a follow-up of commit 9c6f634469de4364d71bc0eb7520d04ead61fd00 Bug 16912: Koha::Patrons - Move AddEnrolmentFeeIfNeeded to->add_enrolment_fee_if_needed One of the known issue:
update categories set enrolmentfee=2; The use misc/devel/create_superlibrarian.pl to create a new superlibrarian patron
Signed-off-by: Victor Grousset <victor.grousset@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 18.11, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We broke some tests with this patch, it adds circular dependencies. koha_1 | Undefined subroutine &C4::Items::ModZebra called at /kohadevbox/koha/C4/Items.pm line 302. koha_1 | Undefined subroutine &C4::Circulation::GetItem called at /kohadevbox/koha/C4/Circulation.pm line 1290. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am fixing this, in tests. Basically the idea is: 1. Undefined subroutine &C4::Items::ModZebra called at /home/vagrant/kohaclone/C4/Items.pm line 302. => Then use C4::Items before C4::Biblio 2. Undefined subroutine &C4::Circulation::GetItem called at /home/vagrant/kohaclone/C4/Circulation.pm line 1290 => Then use C4::Circulation before C4::Items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77345&action=edit Bug 21133: Fix use statements order Basically the idea is: 1. Undefined subroutine &C4::Items::ModZebra called at /home/vagrant/kohaclone/C4/Items.pm line 302. => Then use C4::Items before C4::Biblio 2. Undefined subroutine &C4::Circulation::GetItem called at /home/vagrant/kohaclone/C4/Circulation.pm line 1290 => Then use C4::Circulation before C4::Items And sometimes these 2 rules do not work... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17539, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17600 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Follow-up pushed as well, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Bug 21133 depends on bug 21087, which changed state. Bug 21087 Summary: Patron's password is hashed twice when the object is saved https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21087 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This one is somewhat of a nightmare to backport. I'm going to hold off and see if there are any side effects in master before attempting a port. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 --- Comment #12 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- (In reply to Martin Renvoize from comment #11)
This one is somewhat of a nightmare to backport. I'm going to hold off and see if there are any side effects in master before attempting a port.
Even just the first patch ? "Add missing use C4::Accounts statement in Koha/Patron.pm" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Victor Grousset/tuxayo from comment #12)
(In reply to Martin Renvoize from comment #11)
This one is somewhat of a nightmare to backport. I'm going to hold off and see if there are any side effects in master before attempting a port.
Even just the first patch ? "Add missing use C4::Accounts statement in Koha/Patron.pm"
Then tests will fail? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Bug 21396 has been pushed to 18.05.x and tests are failing: Undefined subroutine &C4::Items::ModZebra called at /home/vagrant/kohaclone/C4/Items.pm line 302. This error can be fixed with these patches. I have rebased and adjusted them to make them apply on 18.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79889&action=edit Bug 21133: [18.05.x] Fix use statements order Basically the idea is: 1. Undefined subroutine &C4::Items::ModZebra called at /home/vagrant/kohaclone/C4/Items.pm line 302. => Then use C4::Items before C4::Biblio 2. Undefined subroutine &C4::Circulation::GetItem called at /home/vagrant/kohaclone/C4/Circulation.pm line 1290 => Then use C4::Circulation before C4::Items And sometimes these 2 rules do not work... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have *not* run the whole test suite locally to make sure everything was ok. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for the 18.05.x patch, very much appreciated. I have now tested locally and all appears good. Pushed up for 18.05.05, cross fingers the Jenkins god will be appeased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #18 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Patch for 18.05 was easy to rebase on 17.11 Pushed to 17.11.x for 17.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org