https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26745 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 112020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112020&action=edit Bug 26745: Add TT support to 'title' in notices This patch adds support for using TT syntax in the title element of the notices system. Test plan -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26745 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26745 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112020|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 112021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112021&action=edit Bug 26745: Add TT support to 'title' in notices This patch adds support for using TT syntax in the title element of the notices system. Test plan 1/ Edit an easily triggerable email notice such that the title contains some template toolkit markup. Example: Edit the 'CHECKOUT' notice to include [% today %] in the title field. 2/ Trigger the notice (For 'CHECKOUT' that means checking an item out to a user (Preferably with 'email' selected in their advanced messaging preferences for the notice) 3/ Either, navigate to the 'Notices' tab for the user, or run the message queue and inspect the subject line of the recieved email. 4/ Prior to the patch the TT syntax would remain 'as is'.. i.e '[% today %]'. 5/ After the patch, the TT syntax should have been properly replaced. 6/ Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26745 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21898 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26745 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112021|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112136&action=edit Bug 26745: Add TT support to 'title' in notices This patch adds support for using TT syntax in the title element of the notices system. Test plan 1/ Edit an easily triggerable email notice such that the title contains some template toolkit markup. Example: Edit the 'CHECKOUT' notice to include [% today %] in the title field. 2/ Trigger the notice (For 'CHECKOUT' that means checking an item out to a user (Preferably with 'email' selected in their advanced messaging preferences for the notice) 3/ Either, navigate to the 'Notices' tab for the user, or run the message queue and inspect the subject line of the recieved email. 4/ Prior to the patch the TT syntax would remain 'as is'.. i.e '[% today %]'. 5/ After the patch, the TT syntax should have been properly replaced. 6/ Signoff Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26745 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26745 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 112178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112178&action=edit Bug 26745: Add TT support to 'title' in notices This patch adds support for using TT syntax in the title element of the notices system. Test plan 1/ Edit an easily triggerable email notice such that the title contains some template toolkit markup. Example: Edit the 'CHECKOUT' notice to include [% today %] in the title field. 2/ Trigger the notice (For 'CHECKOUT' that means checking an item out to a user (Preferably with 'email' selected in their advanced messaging preferences for the notice) 3/ Either, navigate to the 'Notices' tab for the user, or run the message queue and inspect the subject line of the recieved email. 4/ Prior to the patch the TT syntax would remain 'as is'.. i.e '[% today %]'. 5/ After the patch, the TT syntax should have been properly replaced. 6/ Signoff Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26745 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 112983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112983&action=edit Bug 26745: (QA follow-up) Add Unit Tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26745 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26745 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- A very unintentional side-effect of this patch has been to caught a bug in SendAlerts, see bug 26935. # Failed test 'SendAlerts - claimissue' # at t/db_dependent/Letters.t line 642. C4::Letters::_substitute_tables(): DBI Exception: DBD::mysql::st execute failed: called with 2 bind variables when 1 are needed [for Statement "SELECT * FROM aqbasket WHERE basketno = ?" with ParamValues: 0=53] at /kohadevbox/koha/C4/Letters.pm line 679 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26745 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26745 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.