https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26736 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 111993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111993&action=edit Bug 26736: Compare values of reports log entries This patch adds the ability to compare the log entries for reports in the system log. The user can select two entries in the log search results and view a diff of the two versions. To test, apply the patch and check that the ReportsLog system preference is enabled. If it isn't, enable it and make some changes to saved SQL reports so that you have log entries to test with. This is a trivial patch that simply adds "REPORTS" type log entries to the list of modules which can be selected for comparison. The full test plan is basically the same as that for Bug 26207: - Perform a search for log entries in the "Reports" module. - In the results, each entry for a report update should have a "Compare" checkbox." - Check one of the checkboxes. - The table should now be filtered by the report title. This facilitates meaningful selections for comparison. - You should see a message displayed onscreen, "Showing results for...[report name]" - The "Check none" link in the toolbar above the table should now be enabled. - If youy click the "Compare selected" link in the toolbar at this stage you should get a message, "You must select two entries to compare." - If you uncheck the checkbox the table should return to an unfiltered state. - Check two checkboxes. - The "Compare selected" link in the toolbar should now be enabled. - Next to each of the checkboxes you checked should be a "View comparison" link. - Clicking either of the "View comparison" links or the "Compare selected" link should trigger a modal with the diff view of the two reports log entries. - Try to select a third checkbox. You should get a message, "You can select a maximum of two checkboxes." The box should remain unchecked. - Test that unchecking both checkboxes manually clears the table filter. - Test that the "Check none" link works to uncheck checked boxes and clear the table filter. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26736 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111993|0 |1 is obsolete| | --- Comment #2 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 111998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111998&action=edit Bug 26736: Compare values of reports log entries This patch adds the ability to compare the log entries for reports in the system log. The user can select two entries in the log search results and view a diff of the two versions. To test, apply the patch and check that the ReportsLog system preference is enabled. If it isn't, enable it and make some changes to saved SQL reports so that you have log entries to test with. This is a trivial patch that simply adds "REPORTS" type log entries to the list of modules which can be selected for comparison. The full test plan is basically the same as that for Bug 26207: - Perform a search for log entries in the "Reports" module. - In the results, each entry for a report update should have a "Compare" checkbox." - Check one of the checkboxes. - The table should now be filtered by the report title. This facilitates meaningful selections for comparison. - You should see a message displayed onscreen, "Showing results for...[report name]" - The "Check none" link in the toolbar above the table should now be enabled. - If youy click the "Compare selected" link in the toolbar at this stage you should get a message, "You must select two entries to compare." - If you uncheck the checkbox the table should return to an unfiltered state. - Check two checkboxes. - The "Compare selected" link in the toolbar should now be enabled. - Next to each of the checkboxes you checked should be a "View comparison" link. - Clicking either of the "View comparison" links or the "Compare selected" link should trigger a modal with the diff view of the two reports log entries. - Try to select a third checkbox. You should get a message, "You can select a maximum of two checkboxes." The box should remain unchecked. - Test that unchecking both checkboxes manually clears the table filter. - Test that the "Check none" link works to uncheck checked boxes and clear the table filter. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26736 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26736 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26736 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26736 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.