[Bug 42842] New: Remove materialized patron data from tmp_holdsqueue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42842 Bug ID: 42842 Summary: Remove materialized patron data from tmp_holdsqueue Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 42503 Target Milestone: --- Since bug 42503 converted the holds queue page to be API-driven, the materialized patron fields in tmp_holdsqueue (surname, firstname, phone, cardnumber) are no longer used. The page now embeds patron data via the borrowernumber FK through the REST API. These columns should be removed because: 1. They are dead code â nothing reads them after bug 42503 2. They leave patron PII (name, phone, card number) in an unaudited table that is not subject to patron data cleanup/anonymization routines 3. Privacy concern: tmp_holdsqueue is rebuilt periodically but retains patron information between rebuilds, and this data is not covered by GDPR/privacy cleanup tools The fix should: - Remove surname, firstname, phone, cardnumber columns from tmp_holdsqueue - Stop populating them in C4::HoldsQueue::CreatePicklistFromItemMap - Update Koha::Schema::Result::TmpHoldsqueue - Remove the undef mappings in Koha::Hold::HoldsQueueItem::to_api_mapping Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 [Bug 42503] Render the holds queue using the REST API -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42842 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, katrin.fischer@bsz-bw.de, | |martin.renvoize@openfifth.c | |o.uk, tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42842 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42842 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 200388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200388&action=edit Bug 42842: Remove materialized patron data from tmp_holdsqueue Since bug 42503, the holds queue page is API-driven and patron data is embedded via the borrowernumber FK. The materialized surname, firstname, phone, and cardnumber columns are no longer read by any code path. Removing them because: - Dead code: nothing reads these columns - Privacy: patron PII was stored in an unaudited table not covered by GDPR/anonymization cleanup tools - Data integrity: values could become stale between queue rebuilds Changes: - Atomicupdate drops the four columns - C4::HoldsQueue::CreatePicklistFromItemMap no longer fetches/inserts patron fields - Koha::Hold::HoldsQueueItem to_api_mapping cleaned up - Tests adjusted to use borrowernumber instead of cardnumber Test plan: 1. Apply all patches 2. Run updatedatabase 3. Verify tmp_holdsqueue no longer has surname/firstname/phone/cardnumber 4. Run: perl misc/cronjobs/holds/build_holds_queue.pl 5. Verify the holds queue page still shows patron info (via API embed) 6. prove t/db_dependent/HoldsQueue/materialized_descriptions.t 7. prove t/db_dependent/api/v1/holds_queue.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42842 --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 200389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200389&action=edit [DO NOT PUSH] Bug 42842: Update DBIC schema This is for testers only. The release manager will regenerate the schema files after pushing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42842 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42842 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200388|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42842 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 200437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200437&action=edit Bug 42842: Remove materialized patron data from tmp_holdsqueue Since bug 42503, the holds queue page is API-driven and patron data is embedded via the borrowernumber FK. The materialized surname, firstname, phone, and cardnumber columns are no longer read by any code path. Removing them because: - Dead code: nothing reads these columns - Privacy: patron PII was stored in an unaudited table not covered by GDPR/anonymization cleanup tools - Data integrity: values could become stale between queue rebuilds Changes: - Atomicupdate drops the four columns - C4::HoldsQueue::CreatePicklistFromItemMap no longer fetches/inserts patron fields - Koha::Hold::HoldsQueueItem to_api_mapping cleaned up - Tests adjusted to use borrowernumber instead of cardnumber Test plan: 1. Apply all patches 2. Run updatedatabase 3. Verify tmp_holdsqueue no longer has surname/firstname/phone/cardnumber 4. Run: perl misc/cronjobs/holds/build_holds_queue.pl 5. Verify the holds queue page still shows patron info (via API embed) 6. prove t/db_dependent/HoldsQueue/materialized_descriptions.t 7. prove t/db_dependent/api/v1/holds_queue.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42842 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 200438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200438&action=edit Bug 42842: Update DBIC schema This is for testers only. The release manager will regenerate the schema files after pushing. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org