[Bug 35854] New: Suggestions generate identical messages when edited
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35854 Bug ID: 35854 Summary: Suggestions generate identical messages when edited Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl To reproduce: - Log in to the OPAC and enter a purchase suggestion - Log in to the staff client and locate the purchase suggestion - Change the status to "Accepted" - Check the notices of the patron that entered the suggestion in the OPAC. Verify there is message with the title "Purchase suggestion accepted" - Now edit the purchase suggestion again, without changing the status - Check the messages of the patron again, and verify there are now to "Purchase suggestion accepted" messages The standard ACCEPTED message reads: Dear koha, You have suggested that the library acquire Test by Johan Theorin. The library has reviewed your suggestion today. The item will be ordered as soon as possible. You will be notified by mail when the order is completed, and again when the item arrives at the library. If you have any questions, please email us at . Thank you, Centerville It might be possible to phrase this another way, so it makes sense to send it out multiple times for the same suggestion even if the status is not changed, but in general I think it will be confusing to generate identical messages for the same suggestion. The suggested fix is to only send messages when the status is changed. Perhaps there are libraries that depend on the current functionality, so we might need a syspref like SuggestionsOnlySendMessagesOnChangedStatus that defaults to off, to keep the current behaviour. Thoughts? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35854 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the notices should only be sent when the status changes. Did editing the suggestion work for you? Because there is bug 34963. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35854 --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- (In reply to Katrin Fischer from comment #1)
Did editing the suggestion work for you? Because there is bug 34963.
I just tested with adding to the title or something like that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35854 S Martin <smartin@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |smartin@lancasterseminary.e | |du --- Comment #3 from S Martin <smartin@lancasterseminary.edu> --- I'm also having this problem. The suggestion accepted message is sent to patrons whenever something in the record is edited. It's also being sent when the suggestion is marked as ordered (the suggestion ordered notice is sent, and the suggestion accepted message is being sent again at the same time.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35854 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I just created bug 36122, I'm not sure if it's the same as this or not. It's similar but affects the NEW_SUGGESTION notice sent for every change in the suggestion when EmailPurchaseSuggestion is enabled instead of the patron notices. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35854 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36122 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35854 Mirjam Vantieghem <mirjam.vantieghem@etf.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirjam.vantieghem@etf.edu --- Comment #5 from Mirjam Vantieghem <mirjam.vantieghem@etf.edu> --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35854 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35854 library@renovationchurch.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |library@renovationchurch.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35854 Amanda Campbell <acampbell@hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acampbell@hmcpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35854 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu --- Comment #6 from Michaela Sieber <michaela.sieber@kit.edu> --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org