https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35854 Bug ID: 35854 Summary: Suggestions generate identical messages when edited Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl To reproduce: - Log in to the OPAC and enter a purchase suggestion - Log in to the staff client and locate the purchase suggestion - Change the status to "Accepted" - Check the notices of the patron that entered the suggestion in the OPAC. Verify there is message with the title "Purchase suggestion accepted" - Now edit the purchase suggestion again, without changing the status - Check the messages of the patron again, and verify there are now to "Purchase suggestion accepted" messages The standard ACCEPTED message reads: Dear koha, You have suggested that the library acquire Test by Johan Theorin. The library has reviewed your suggestion today. The item will be ordered as soon as possible. You will be notified by mail when the order is completed, and again when the item arrives at the library. If you have any questions, please email us at . Thank you, Centerville It might be possible to phrase this another way, so it makes sense to send it out multiple times for the same suggestion even if the status is not changed, but in general I think it will be confusing to generate identical messages for the same suggestion. The suggested fix is to only send messages when the status is changed. Perhaps there are libraries that depend on the current functionality, so we might need a syspref like SuggestionsOnlySendMessagesOnChangedStatus that defaults to off, to keep the current behaviour. Thoughts? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.