[Bug 32976] New: Patron image Add/Edit button should not appear if permission is turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32976 Bug ID: 32976 Summary: Patron image Add/Edit button should not appear if permission is turned off Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If you don't have permission to upload images, you still see the add/edit button for the patron image. It does nothing when clicked, but it really shouldn't be visible at all. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32976 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32976 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32976 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 147420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147420&action=edit Bug 32976: Add permission check on Add/Edit controls for patron images This adds a check on the batch_upload_patron_images permission to the Add/Edit control for patron images in the patron account in the staff interface. To test: * Enable patronimages system preference * With your 'superlibrarian' account: * Add and edit/remove a patron image to an account * Create a staff user with batch_upload_patron_images permission * Log in with this user and verify everything works the same as before * Remove the batch_upload_patron_images permission * Verify the Add/Edit controls are on longer visible to this patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32976 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32976 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147420|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 147446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147446&action=edit Bug 32976: Add permission check on Add/Edit controls for patron images This adds a check on the batch_upload_patron_images permission to the Add/Edit control for patron images in the patron account in the staff interface. To test: * Enable patronimages system preference * With your 'superlibrarian' account: * Add and edit/remove a patron image to an account * Create a staff user with batch_upload_patron_images permission * Log in with this user and verify everything works the same as before * Remove the batch_upload_patron_images permission * Verify the Add/Edit controls are on longer visible to this patron Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32976 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147446|0 |1 is obsolete| | --- Comment #3 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 147462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147462&action=edit Bug 32976: Add permission check on Add/Edit controls for patron images This adds a check on the batch_upload_patron_images permission to the Add/Edit control for patron images in the patron account in the staff interface. To test: * Enable patronimages system preference * With your 'superlibrarian' account: * Add and edit/remove a patron image to an account * Create a staff user with batch_upload_patron_images permission * Log in with this user and verify everything works the same as before * Remove the batch_upload_patron_images permission * Verify the Add/Edit controls are on longer visible to this patron Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32976 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Owen and Christopher! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32976 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32976 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147462|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 148638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148638&action=edit Bug 32976: Add permission check on Add/Edit controls for patron images This adds a check on the batch_upload_patron_images permission to the Add/Edit control for patron images in the patron account in the staff interface. To test: * Enable patronimages system preference * With your 'superlibrarian' account: * Add and edit/remove a patron image to an account * Create a staff user with batch_upload_patron_images permission * Log in with this user and verify everything works the same as before * Remove the batch_upload_patron_images permission * Verify the Add/Edit controls are on longer visible to this patron Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32976 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32976 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32976 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32976 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32976 --- Comment #7 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org