[Bug 31640] New: Fuzzy translations of preferences can cause missing sections and inaccurate translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 Bug ID: 31640 Summary: Fuzzy translations of preferences can cause missing sections and inaccurate translations Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: kevin.carnes@ub.lu.se QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr We noticed that when installing the Swedish translations in 22.05, the translate program was using fuzzy translations for preferences. This resulted in many strange translations when viewing the preferences in Swedish. There were also some sections that were missing since multiple sections had the same translated name and there can only be one section for each name since they are hash keys. Our solution is to ignore fuzzy translations for preferences, since we prefer the original English, but it can be made an option if the fuzzy translations are helpful to others. The solution also adds warnings if a translation causes multiple sections to have the same name. When I run the warnings with fuzzy translations in 22.05.03, I get warnings in 65 languages (am-Ethi, ar-Arab, az-AZ, be-BY, bg-Cyrl, bn-IN, ca-ES, cs-CZ, cy-GB, da-DK, de-CH, el-GR, en-GB, en-NZ, eo, eu, fa-Arab, fr-CA, gl, he-Hebr, hi, hr-HR, hu-HU, hyw-Armn, id-ID, is-IS, ja-Jpan-JP, ka, ko-Kore-KP, ku-Arab, lo-Laoo, mi-NZ, mon, mr, ms-MY, nb-NO, ne-NE, nl-BE, nl-NL, nn-NO, oc, pbr, pl-PL, prs, pt-BR, pt-PT, ro-RO, ru-RU, sd-PK, sk-SK, sl-SI, sq-AL, sr-Cyrl, sv-SE, ta-LK, te, tet, th-TH, tl-PH, tr-TR, uk-UA, ur-Arab, vi-VN, zh-Hans-CN, zh-Hant-TW). If there are languages where multiple sections should have the save name, we can discuss using an array instead of a hash for the sections. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 --- Comment #1 from Kevin Carnes <kevin.carnes@ub.lu.se> --- Created attachment 141045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141045&action=edit This patch ignores fuzzy translations for preferences and warns if there are multiple sections with the same translated name. Test Plan: 1) Install Swedish translations (./misc/translator/translate install sv-SE) 2) Go to Koha administration in the staff interface 3) Click Global system preferences 4) Select I18N/L10N preferences 5) Enable Swedish in the language preference for staff interface 6) Save all I18N/L10N preferences 7) Return to Koha administration 8) Select Svenska as the language if the page is not in Swedish 9) Click on Globala systeminställningar 10) Select Cirkulation 11) Observer that there is only SelfCheckInMainUserBlock or AutoSelfCheckAllowed, but not both 12) Apply the patch 13) Install Swedish translations (./misc/translator/translate install sv-SE) 14) Go to Koha administration 15) Select Svenska as the language if the page is not in Swedish 16) Click on Globala systeminställningar 17) Select Cirkulation 18) Observer that SelfCheckInMainUserBlock and AutoSelfCheckAllowed are both present -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 Kevin Carnes <kevin.carnes@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141045|0 |1 is obsolete| | --- Comment #2 from Kevin Carnes <kevin.carnes@ub.lu.se> --- Created attachment 141046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141046&action=edit Bug 31640: Fuzzy translations of preferences can cause missing sections and inaccurate translations This patch ignores fuzzy translations for preferences and warns if there are multiple sections with the same translated name. Test Plan: 1) Install Swedish translations (./misc/translator/translate install sv-SE) 2) Go to Koha administration in the staff interface 3) Click Global system preferences 4) Select I18N/L10N preferences 5) Enable Swedish in the language preference for staff interface 6) Save all I18N/L10N preferences 7) Return to Koha administration 8) Select Svenska as the language if the page is not in Swedish 9) Click on Globala systeminställningar 10) Select Cirkulation 11) Observer that there is only SelfCheckInMainUserBlock or AutoSelfCheckAllowed, but not both 12) Apply the patch 13) Install Swedish translations (./misc/translator/translate install sv-SE) 14) Go to Koha administration 15) Select Svenska as the language if the page is not in Swedish 16) Click on Globala systeminställningar 17) Select Cirkulation 18) Observe that SelfCheckInMainUserBlock and AutoSelfCheckAllowed are both present -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 Kevin Carnes <kevin.carnes@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141046|0 |1 is obsolete| | --- Comment #3 from Kevin Carnes <kevin.carnes@ub.lu.se> --- Created attachment 141048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141048&action=edit Bug 31640: Fuzzy translations of preferences can cause missing sections and inaccurate translations This patch ignores fuzzy translations for preferences and warns if there are multiple sections with the same translated name. Test Plan: 1) Install Swedish translations (./misc/translator/translate install sv-SE) 2) Go to Koha administration in the staff interface 3) Click Global system preferences 4) Select I18N/L10N preferences 5) Enable Swedish in the language preference for staff interface 6) Save all I18N/L10N preferences 7) Return to Koha administration 8) Select Svenska as the language if the page is not in Swedish 9) Click on Globala systeminställningar 10) Select Cirkulation 11) Observe that there is only SelfCheckInMainUserBlock or AutoSelfCheckAllowed, but not both 12) Apply the patch 13) Install Swedish translations (./misc/translator/translate install sv-SE) 14) Go to Koha administration 15) Select Svenska as the language if the page is not in Swedish 16) Click on Globala systeminställningar 17) Select Cirkulation 18) Observe that SelfCheckInMainUserBlock and AutoSelfCheckAllowed are both present -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 Kevin Carnes <kevin.carnes@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141048|0 |1 is obsolete| | --- Comment #4 from Kevin Carnes <kevin.carnes@ub.lu.se> --- Created attachment 141049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141049&action=edit Bug 31640: Fuzzy translations of preferences can cause missing sections and inaccurate translations This patch ignores fuzzy translations for preferences and warns if there are multiple sections with the same translated name. Test Plan: 1) Install Swedish translations (./misc/translator/translate install sv-SE) 2) Go to Koha administration in the staff interface 3) Click Global system preferences 4) Select I18N/L10N preferences 5) Enable Swedish in the language preference for staff interface 6) Save all I18N/L10N preferences 7) Return to Koha administration 8) Select Svenska as the language if the page is not in Swedish 9) Click on Globala systeminställningar 10) Select Cirkulation 11) Observer that there is only SelfCheckInMainUserBlock or AutoSelfCheckAllowed, but not both 12) Apply the patch 13) Install Swedish translations (./misc/translator/translate install sv-SE) 14) Go to Koha administration 15) Select Svenska as the language if the page is not in Swedish 16) Click on Globala systeminställningar 17) Select Cirkulation 18) Observe that SelfCheckInMainUserBlock and AutoSelfCheckAllowed are both present -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 --- Comment #5 from Kevin Carnes <kevin.carnes@ub.lu.se> --- I couldn't reproduce the error with "koha-translate -i sv-SE", but realized that I had an old docker image with Koha 21 in /usr/share. I updated the image and can reproduce the error, but Circulation is now translated as Utlåning in Swedish. If you would like, I can attach a log of all of the conflicting sections for all languages so that you can test a language you are more comfortable with. For example en-GB: In file "cataloguing.pref", "cataloguing the record" is a translation for sections "Record structure", "Interface" at /kohadevbox/koha/misc/translator/LangInstaller.pm line 184. In file "enhanced_content.pref", "Enhanced content settings" is a translation for sections "Amazon", "Library Thing", "Tagging", "Google", "Syndetics", "All", "OverDrive", "Manual" at /kohadevbox/koha/mi sc/translator/LangInstaller.pm line 184. In file "circulation.pref", " Self return module" is a translation for sections "Self check-in module", "Stock rotation module" at /kohadevbox/koha/misc/translator/LangInstaller.pm line 184. In file "circulation.pref", "Returns Policy" is a translation for sections "Recalls", "Return claims", "Fines Policy" at /kohadevbox/koha/misc/translator/LangInstaller.pm line 184. In file "circulation.pref", " Self Issue" is a translation for sections "Interface", "Interlibrary loans" at /kohadevbox/koha/misc/translator/LangInstaller.pm line 184. In file "circulation.pref", " Batch issue" is a translation for sections "Article requests", "Batch checkout" at /kohadevbox/koha/misc/translator/LangInstaller.pm line 184. In file "circulation.pref", " Self issue module" is a translation for sections "Self check-out module", "Housebound module" at /kohadevbox/koha/misc/translator/LangInstaller.pm line 184. In file "web_services.pref", " Kohas" is a translation for sections "IdRef", "Reporting", "ILS-DI", "Mana KB", "General", "REST API", "OAI-PMH" at /kohadevbox/koha/misc/translator/LangInstaller.pm line 1 84. In file "patrons.pref", "User forms" is a translation for sections "General", "Security", "Privacy", "Patron forms" at /kohadevbox/koha/misc/translator/LangInstaller.pm line 184. In file "tools.pref", " User cards" is a translation for sections "News", "Batch item", "Patron cards", "Barcodes", "Upload" at /kohadevbox/koha/misc/translator/LangInstaller.pm line 184. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 Kevin Carnes <kevin.carnes@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 Kevin Carnes <kevin.carnes@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141049|0 |1 is obsolete| | --- Comment #6 from Kevin Carnes <kevin.carnes@ub.lu.se> --- Created attachment 141050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141050&action=edit Bug 31640: Fuzzy translations of preferences can cause missing sections and inaccurate translations This patch ignores fuzzy translations for preferences and warns if there are multiple sections with the same translated name. Test Plan: 1) Install English United Kingdom translations (./misc/translator/translate install en-GB) 2) Go to Koha administration in the staff interface 3) Click Global system preferences 4) Select I18N/L10N preferences 5) Enable English United Kingdom in the language preference for staff interface 6) Save all I18N/L10N preferences 7) Return to Koha administration 8) Select English United Kingdom as the language at the bottom of the screen 9) Click on Global system preferences 10) Select Circulation 11) Observe that there is only SelfCheckInMainUserBlock or StockRotation, but not both 12) Apply the patch 13) Install English United Kingdom translations (./misc/translator/translate install en-GB) 14) Go to Koha administration 15) Select English United Kingdom as the language at the bottom of the screen 16) Click on Global system preferences 17) Select Circulation 18) Observe that SelfCheckInMainUserBlock and StockRotation are both present -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 --- Comment #7 from Kevin Carnes <kevin.carnes@ub.lu.se> --- Of course it makes more sense to test it in English. The bug can be reproduced with koha-translate, but the patch won't affect the LangInstaller.pm in /usr/share on docker, so it's best to run the translate program in the repository. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.05 |master Assignee|koha-bugs@lists.koha-commun |kevin.carnes@ub.lu.se |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 Serhij Dubyk <dubyk@ukr.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dubyk@ukr.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141050|0 |1 is obsolete| | --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 145192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145192&action=edit Bug 31640: Fuzzy translations of preferences can cause missing sections and inaccurate translations This patch ignores fuzzy translations for preferences and warns if there are multiple sections with the same translated name. Test Plan: 1) Install English United Kingdom translations (./misc/translator/translate install en-GB) 2) Go to Koha administration in the staff interface 3) Click Global system preferences 4) Select I18N/L10N preferences 5) Enable English United Kingdom in the language preference for staff interface 6) Save all I18N/L10N preferences 7) Return to Koha administration 8) Select English United Kingdom as the language at the bottom of the screen 9) Click on Global system preferences 10) Select Circulation 11) Observe that there is only SelfCheckInMainUserBlock or StockRotation, but not both 12) Apply the patch 13) Install English United Kingdom translations (./misc/translator/translate install en-GB) 14) Go to Koha administration 15) Select English United Kingdom as the language at the bottom of the screen 16) Click on Global system preferences 17) Select Circulation 18) Observe that SelfCheckInMainUserBlock and StockRotation are both present Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks Kevin! I had also noticed this in fr-CA (it's a bit puzzling when you *know* there is a syspref called whatever, and you can't find it... it's like Koha is trying to gaslight you), so it's great that you've corrected it! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Do we really need to keep the warnings? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #10)
Do we really need to keep the warnings?
What do you mean by warnings? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- oh I see, in the patch: warn qq(In file "$file", "$translation" is a translation for sections ") . join('", "', @{$duplicates{$translation}}) . '"'; I was wondering if it was some kind of warning text generated within the files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 --- Comment #13 from Kevin Carnes <kevin.carnes@ub.lu.se> --- (In reply to Jonathan Druart from comment #10)
Do we really need to keep the warnings?
No, it was mainly to see which languages were affected, but I thought it might also be helpful in the future if a translator happened to use the same translation for two sections or if an erroneous fuzzy translation was approved. We had no idea it was a problem until we tried to find a certain section and were confused when sections would disappear after we updated the translation, so a warning would have been helpful, but not necessary. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145192|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 148533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148533&action=edit Bug 31640: Fuzzy translations of preferences can cause missing sections and inaccurate translations This patch ignores fuzzy translations for preferences and warns if there are multiple sections with the same translated name. Test Plan: 1) Install English United Kingdom translations (./misc/translator/translate install en-GB) 2) Go to Koha administration in the staff interface 3) Click Global system preferences 4) Select I18N/L10N preferences 5) Enable English United Kingdom in the language preference for staff interface 6) Save all I18N/L10N preferences 7) Return to Koha administration 8) Select English United Kingdom as the language at the bottom of the screen 9) Click on Global system preferences 10) Select Circulation 11) Observe that there is only SelfCheckInMainUserBlock or StockRotation, but not both 12) Apply the patch 13) Install English United Kingdom translations (./misc/translator/translate install en-GB) 14) Go to Koha administration 15) Select English United Kingdom as the language at the bottom of the screen 16) Click on Global system preferences 17) Select Circulation 18) Observe that SelfCheckInMainUserBlock and StockRotation are both present Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 --- Comment #16 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org