https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #2 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- Logging would be a good thing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbrown@bywatersolutions.com --- Comment #4 from Sara Brown <sbrown@bywatersolutions.com> --- Still relevant in 21.11 and still would be useful! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 hebah@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 --- Comment #6 from David Gustafsson <glasklas@gmail.com> --- Created attachment 163957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163957&action=edit Bug 26744: Log changes to extended patron attributes Log non-repeatable attributes and only log changes and creations, not deletions. When changed, attributes are first all deleted, then the relevant ones are recreated. This patch catches all deletions, and checks against them in the creation phase, logging only the attributes that have changed (with before/after content). This makes it impossible to log actual deletions. To test: 1) Ensure tests in t/db_dependent/Koha/Patron/Attribute.t passes Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 --- Comment #8 from David Gustafsson <glasklas@gmail.com> --- Created attachment 163959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163959&action=edit Bug 26744: Only log if BorrowersLog syspref is enabled -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163959|0 |1 is obsolete| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 164035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164035&action=edit Bug 26744: Only log if BorrowersLog syspref is enabled Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Stefan Berndtsson <stefan.berndtsson@ub.gu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stefan.berndtsson@ub.gu.se --- Comment #13 from Stefan Berndtsson <stefan.berndtsson@ub.gu.se> --- (In reply to Lucas Gass from comment #9)

This works as described so I will sign-off. Why not log repeatable attributes as well?

I'm the one who wrote the original patch here. The way editing of extended attributes work is that they're all first deleted, then they're recreated from the form. Since all of the previous attributes are just deleted, I have no way that I can see to know which of the repeatable attributes that was changed into what. It there had been a more conventional way to edit the existing attributes this would've been easy. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #15 from David Gustafsson <glasklas@gmail.com> --- I realised it actually was not too much trouble also logging changes to repeatable attributes (and deletions) if instead performing the logging in Koha::Patron->extended_attributes, so I revised the patch to do that instead. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 --- Comment #17 from David Gustafsson <glasklas@gmail.com> --- Created attachment 165212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165212&action=edit Bug 26744: Don't delete extended attributes outside of method And fix bug where $attribute_changes was overwritten instead of assigned default value. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #19 from David Gustafsson <glasklas@gmail.com> --- @Anneli Österman Thanks for the extensive testing, I should have added tests also for updates with multiple values. There was a line outside of the extended_attributes method that deleted the attributes in memberentry.pl that was not caught by the tests as the method is tested in isolation. But there was also a bug where the stashed repeatable attributes was overwritten where a default value should be assigned, both are now fixed and tests have been added to cover the latter case. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 --- Comment #20 from Clemens Tubach <clemens.tubach@kit.edu> --- Created attachment 165301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165301&action=edit Bug 26744: Log changes to extended patron attributes Log non-repeatable attributes and only log changes and creations, not deletions. When changed, attributes are first all deleted, then the relevant ones are recreated. This patch catches all deletions, and checks against them in the creation phase, logging only the attributes that have changed (with before/after content). This makes it impossible to log actual deletions. To test: 1) Ensure tests in t/db_dependent/Koha/Patron/Attribute.t passes Sponsored-by: Gothenburg University Library Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Clemens Tubach <clemens.tubach@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164098|0 |1 is obsolete| | --- Comment #22 from Clemens Tubach <clemens.tubach@kit.edu> --- Created attachment 165303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165303&action=edit Bug 26744: Add support for repeatable and deleted attributes Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Clemens Tubach <clemens.tubach@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165213|0 |1 is obsolete| | --- Comment #24 from Clemens Tubach <clemens.tubach@kit.edu> --- Created attachment 165305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165305&action=edit Bug 26744: Add test for multiple values of repeatable fields Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Clemens Tubach <clemens.tubach@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164034|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #26 from David Gustafsson <glasklas@gmail.com> --- Squashed (to simplify rabase and review) and rebasted against master. The changes in bug 35508 required some refactoring, and the changes in made there could be unified with the code here since both bugs deal with comparing changes for attributes.The comparison is now more granular and instead of replacing all attributes if anything changes the replacement is now on an attribute type level. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 --- Comment #28 from David Gustafsson <glasklas@gmail.com> --- Another improvement is that the comparison (that decides if attributes has changed) now resides in the extended_attributes method, and not outside in memberentry.pl, so the updated column will not be set if patron attributes are updated some where else using this method, when no value has changed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #31 from David Gustafsson <glasklas@gmail.com> --- Rebased against main. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178728|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #34 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- The only problem I now see here is that changes are not logged when I update attributes with the Batch patron modification tool. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178787|0 |1 is obsolete| | --- Comment #36 from David Gustafsson <glasklas@gmail.com> --- Created attachment 178788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178788&action=edit Bug 26744: Log changes also in modborrowers.pl and when calling add_extended_attribute -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178788|0 |1 is obsolete| | --- Comment #38 from David Gustafsson <glasklas@gmail.com> --- Created attachment 178789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178789&action=edit Bug 26744: Log changes also in modborrowers.pl and when calling add_extended_attribute -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178771|0 |1 is obsolete| | --- Comment #39 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 178801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178801&action=edit Bug 26744: Log changes to extended patron attributes Log non-repeatable attributes and only log changes and creations, not deletions. When changed, attributes are first all deleted, then the relevant ones are recreated. This patch catches all deletions, and checks against them in the creation phase, logging only the attributes that have changed (with before/after content). This makes it impossible to log actual deletions. To test: 1) Ensure tests in t/db_dependent/Koha/Patron/Attribute.t passes Sponsored-by: Gothenburg University Library Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 --- Comment #41 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Small note, the string this puts into the info field isn't formatted exactly like edits of other parts of the patron record. For example, here's an edit to a name field: { "preferred_name" : { "after" : "Huey", "before" : "Hank" } } And an edit to an attribute: Patron attribute SHOW_BCODE: { "after" : "1", "before" : "" } Not a blocker, but worth noting for its impact on reports. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 --- Comment #43 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- David, this is looking very nice. I tidied some things but you might want to look into pulling fresh ktd images and use the new pre-commit tidy stuff. See Bug 38664. You might face more QA challenges in the future without. I have one question here: Is List::Util's zip6 really necessary for comparison? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 --- Comment #45 from David Gustafsson <glasklas@gmail.com> --- (In reply to Andrew Fuerste-Henry from comment #41)

Small note, the string this puts into the info field isn't formatted exactly like edits of other parts of the patron record. For example, here's an edit to a name field: { "preferred_name" : { "after" : "Huey", "before" : "Hank" } }

And an edit to an attribute: Patron attribute SHOW_BCODE: { "after" : "1", "before" : "" }

Not a blocker, but worth noting for its impact on reports.

Ok! I changed the log format to pure json, prepending "attribute." to the "field" name. Also saw that the normal field logging writes one log entry for all field changes, so fixed so this is done also for attribute changes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 --- Comment #47 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to David Gustafsson from comment #45)

(In reply to Andrew Fuerste-Henry from comment #41)

...

Small note, the string this puts into the info field isn't formatted exactly like edits of other parts of the patron record. For example, here's an edit to a name field: { "preferred_name" : { "after" : "Huey", "before" : "Hank" } }

And an edit to an attribute: Patron attribute SHOW_BCODE: { "after" : "1", "before" : "" }

Not a blocker, but worth noting for its impact on reports.

Ok! I changed the log format to pure json, prepending "attribute." to the "field" name. Also saw that the normal field logging writes one log entry for all field changes, so fixed so this is done also for attribute changes.

Thanks, David! I can confirm the syntax change looks good and multiple attribute changes all log as one entry. Is there some inherent reason attribute changes and edits to the regular borrower fields couldn't all go in one log line when performed together? If that's feasible, I may file a followup bug for it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178801|0 |1 is obsolete| | --- Comment #48 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178839&action=edit Bug 26744: Log changes to extended patron attributes Log non-repeatable attributes and only log changes and creations, not deletions. When changed, attributes are first all deleted, then the relevant ones are recreated. This patch catches all deletions, and checks against them in the creation phase, logging only the attributes that have changed (with before/after content). This makes it impossible to log actual deletions. To test: 1) Ensure tests in t/db_dependent/Koha/Patron/Attribute.t passes Sponsored-by: Gothenburg University Library Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178803|0 |1 is obsolete| | --- Comment #50 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178841&action=edit Bug 26744: (QA follow up) Tidy Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 --- Comment #53 from David Gustafsson <glasklas@gmail.com> --- (In reply to Andrew Fuerste-Henry from comment #47)

(In reply to David Gustafsson from comment #45)

...

(In reply to Andrew Fuerste-Henry from comment #41)

...

Small note, the string this puts into the info field isn't formatted exactly like edits of other parts of the patron record. For example, here's an edit to a name field: { "preferred_name" : { "after" : "Huey", "before" : "Hank" } }

And an edit to an attribute: Patron attribute SHOW_BCODE: { "after" : "1", "before" : "" }

Not a blocker, but worth noting for its impact on reports.

Ok! I changed the log format to pure json, prepending "attribute." to the "field" name. Also saw that the normal field logging writes one log entry for all field changes, so fixed so this is done also for attribute changes.

Thanks, David! I can confirm the syntax change looks good and multiple attribute changes all log as one entry. Is there some inherent reason attribute changes and edits to the regular borrower fields couldn't all go in one log line when performed together? If that's feasible, I may file a followup bug for it.

That's not practically possible I'm afraid, even though I can se how it makes sense from a user perspective. as code wise fields and attributes are very different things, with no common methods for updates/changes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Keywords| |additional_work_needed --- Comment #55 from Jonathan Druart <jonathan.druart@gmail.com> --- I suspect this change to be the cause of the following 2 failures: $ prove t/db_dependent/api/v1/patrons.t t/db_dependent/api/v1/patrons.t .. 3/7 # Failed test at t/db_dependent/api/v1/patrons.t line 1042. # got: 'zmEXaS_1HNKHibXWfmUaGo2s8GVHLodtQe5ulfn2oLO' # expected: 'pD7HHacPDh6DExQ7wl2XBBZNj2cmz3_F0_iSUhNAFEVY4Wv16OS55oN9aVWVjB' # Failed test at t/db_dependent/api/v1/patrons.t line 1042. # got: 'zmEXaS_1HNKHibXWfmUaGo2s8GVHLodtQe5ulfn2oLO' # expected: 'Z1dK8ALzVvAz3pjOgpVOzM9cVizAnWw7Fy8rB9eTfuLvCRCdhzqpgFcMN3' # Failed test at t/db_dependent/api/v1/patrons.t line 1042. # got: 'Z1dK8ALzVvAz3pjOgpVOzM9cVizAnWw7Fy8rB9eTfuLvCRCdhzqpgFcMN3' # expected: 'zmEXaS_1HNKHibXWfmUaGo2s8GVHLodtQe5ulfn2oLO' # Failed test at t/db_dependent/api/v1/patrons.t line 1042. # got: 'pD7HHacPDh6DExQ7wl2XBBZNj2cmz3_F0_iSUhNAFEVY4Wv16OS55oN9aVWVjB' # expected: 'zmEXaS_1HNKHibXWfmUaGo2s8GVHLodtQe5ulfn2oLO' # Looks like you failed 4 tests of 26. # Failed test 'extended_attributes tests' # at t/db_dependent/api/v1/patrons.t line 1045. # Looks like you failed 1 test of 44. # Failed test 'librarian access tests' # at t/db_dependent/api/v1/patrons.t line 1048. # Looks like you failed 1 test of 2. t/db_dependent/api/v1/patrons.t .. 4/7 # Failed test 'update() tests' # at t/db_dependent/api/v1/patrons.t line 1049. t/db_dependent/api/v1/patrons.t .. 7/7 # Looks like you failed 1 test of 7. t/db_dependent/api/v1/patrons.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/7 subtests $ prove t/db_dependent/api/v1/patrons_extended_attributes.t t/db_dependent/api/v1/patrons_extended_attributes.t .. 2/5 # Failed test 'exact match for JSON Pointer "/0/type"' # at t/db_dependent/api/v1/patrons_extended_attributes.t line 358. # got: 'KDtH_WsRVKD5KY5R9N_VTJTJkZ6xfGKtqmD' # expected: 'DDqUW_ML8Mz3FfSWsx2kOUoywRGNwi2UuGvNjhVKyqkoKexxB_0aidSXowl6' # Failed test 'exact match for JSON Pointer "/0/value"' # at t/db_dependent/api/v1/patrons_extended_attributes.t line 358. # got: 'updated_mandatory' # expected: 'updated_repeatable_1' # Failed test 'exact match for JSON Pointer "/1/value"' # at t/db_dependent/api/v1/patrons_extended_attributes.t line 358. # got: 'updated_repeatable_1' # expected: 'updated_repeatable_2' # Failed test 'exact match for JSON Pointer "/2/value"' # at t/db_dependent/api/v1/patrons_extended_attributes.t line 358. # got: 'updated_repeatable_2' # expected: 'updated_repeatable_3' # Failed test 'exact match for JSON Pointer "/3/type"' # at t/db_dependent/api/v1/patrons_extended_attributes.t line 358. # got: 'DDqUW_ML8Mz3FfSWsx2kOUoywRGNwi2UuGvNjhVKyqkoKexxB_0aidSXowl6' # expected: 'KDtH_WsRVKD5KY5R9N_VTJTJkZ6xfGKtqmD' # Failed test 'exact match for JSON Pointer "/3/value"' # at t/db_dependent/api/v1/patrons_extended_attributes.t line 358. # got: 'updated_repeatable_3' # expected: 'updated_mandatory' # Looks like you failed 6 tests of 29. t/db_dependent/api/v1/patrons_extended_attributes.t .. 3/5 # Failed test 'overwrite() tests' # at t/db_dependent/api/v1/patrons_extended_attributes.t line 361. They could eventually pass as it's a random failure, but it's failing almost every run locally. The problem is the following: We send some attributes to the PUT route, but return the attributes in a different order. My guess is that the culprit is this line: Koha/Patron.pm 2308 # Sort new attributes by code 2309 @new_attributes = sort { $a->attribute cmp $b->attribute } @new_attributes; Please fix ASAP. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 --- Comment #57 from David Gustafsson <glasklas@gmail.com> --- Created attachment 179284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179284&action=edit Bug 26744i: (follow up) Preserve order when adding patron attributes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 --- Comment #59 from David Gustafsson <glasklas@gmail.com> --- I'm not sure about now patches for bugs that has already been push are handled, should I have created a new bug for this? Posting the patch her meanwhile. It was the insertion order that was the issue, but I initially put the code that checks for required types before storing the attributes, while it previously was the other way around, so tests failed since some errors that exceptions where thrown in a different order, so when there where many validation errors a different one showed up in the tests. When preserving the same order as before all tests pass. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39334 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 --- Comment #62 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Gustafsson from comment #61)

Pretty sure should be handled as a new bug, so created Bug 39334.

Hi David, sorry for being a little late :( Follow-up patches on bugs not yet in a released version are fine. If I set "additional_work_needed" and don't aks for a new bug it's usually fine. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #63 from David Cook <dcook@prosentient.com.au> --- (In reply to David Gustafsson from comment #46)

(In reply to Lucas Gass (lukeg) from comment #43)

...

Is List::Util's zip6 really necessary for comparison?

It could of course be done in other ways, but I don't see why using zip6 would be a problem as it makes the code compact and concise.

It looks like zip6 became available in List::MoreUtils 0.423 (from August 2017). Older versions of Debian/Ubuntu used version 0.416 so they wouldn't have been able to support this change. Fortunately, all the currently supported versions of Debian/Ubuntu have version 0.430 so it's all good. That said, I'll open a follow-up report to bump up the required version of List::MoreUtils in the cpanfile. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #64 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looks like we followed-up on all lose ends here. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41145 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41145 [Bug 41145] Logging patron attributes logs even if there's no changes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41244 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41244 [Bug 41244] Logging patron attributes logs two entries everytime a new patron account (with extended attribute values) is created -- You are receiving this mail because: You are watching all bug changes.