[Bug 39334] New: Preserve order when saving patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39334 Bug ID: 39334 Summary: Preserve order when saving patron attributes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: glasklas@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com A changed introduced in Bug 26744 affects the order in which patron attribtes are saved, so that one no longer can rely on that the attribute ids are assigned in the same order as the data was passed in. This has very minor implications in Koha itself. since attributes are sorted by other columns when retrieved. but many tests in t/db_dependent/api/v1/patrons_extended_attributes.t now fail because of this. This patch makes sure the order is preserved when saving the attributes, and tests should now work again. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39334 --- Comment #1 from David Gustafsson <glasklas@gmail.com> --- Created attachment 179329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179329&action=edit Bug 39334: (follow up) Preserve order when adding patron attributes To test: 1) Run tests in t/db_dependent/api/v1/patrons_extended_attributes.t, serveral should fail 2) Apply patch 3) Run the tests in 1) again, all should now pass -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39334 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |glasklas@gmail.com |ity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26744 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39334 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39334 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Version|unspecified |Main Depends on| |26744 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi David, please make sure you are using the newest components (newest ktd, nuke erm_module, yarn install...) - the patch was not tidy. I fixed before pushing and treating this as a follow-up to the original bug Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 [Bug 26744] Log changes to extended patron attributes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39334 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39334 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, on second thought: since this doesn't fix the tests but changes the code I am asking for a set of QA eyes here too please. Attaching the tidied patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39334 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 179377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179377&action=edit Bug 39334: (follow-up) Preserve order when adding patron attributes To test: 1) Run tests in t/db_dependent/api/v1/patrons_extended_attributes.t, serveral should fail 2) Apply patch 3) Run the tests in 1) again, all should now pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39334 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179329|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39334 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39334 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39334 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179377|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179388&action=edit Bug 39334: (follow-up) Preserve order when adding patron attributes To test: 1) Run tests in t/db_dependent/api/v1/patrons_extended_attributes.t, serveral should fail 2) Apply patch 3) Run the tests in 1) again, all should now pass Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39334 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39334 --- Comment #6 from David Gustafsson <glasklas@gmail.com> --- (In reply to Katrin Fischer from comment #2)
Hi David, please make sure you are using the newest components (newest ktd, nuke erm_module, yarn install...) - the patch was not tidy. I fixed before pushing and treating this as a follow-up to the original bug
Ok, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39334 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39334 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39334 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39970 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39970 [Bug 39970] REST API - Creating a patron without mandatory attribute types does not error (it should) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39334 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39334 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 26744 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39334 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org