[Bug 38903] New: getTranslatedLanguages is still called with wrong theme
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 Bug ID: 38903 Summary: getTranslatedLanguages is still called with wrong theme Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: f.demians@tamil.fr, jonathan.druart@gmail.com Four years after bug 29245. Triggered by work on bug 38630. Another try ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38630 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38630 [Bug 38630] Make the REST API respect KohaOpacLanguage cookie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38904 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38904 [Bug 38904] admin/localization should allow translation in OPAC languages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 176621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176621&action=edit Bug 38903: Fix theme in some getTranslatedLanguages calls Combining opac with pref template is wrong. This pref should actually be renamed to something like intranetTheme(s) or so. Replacing the obsolete prog theme in Languages.t by undef. This achieves the same: getting all themes for that interface. Test plan: Add some languages for opac and intranet. Do not enable exactly the same set. Enable TranslateNotices. Verify that you have all OPAC languages on memberentry and opac-messaging. And all languages on additional contents. Run t/db_dependent/Languages.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested with: OPAC languages: en, nl-NL, de-DE Staff languages: en, de-DE, fr-FR -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Trivial adding self SO. You might view them as QA follow-ups for bug 38630 too. Julian: Could you QA here ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- I've tried different combinations of sysprefs, and even tried the exact same syspref values as in comment 1. All installed languages (even those that are disabled in both interfaces) show up in language selectors on memberentry and opac-messaging. Applying the patch does not change anything for me. The changes make sense to me but I cannot validate them because of that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Julian Maurice from comment #3)
I've tried different combinations of sysprefs, and even tried the exact same syspref values as in comment 1. All installed languages (even those that are disabled in both interfaces) show up in language selectors on memberentry and opac-messaging. Applying the patch does not change anything for me. The changes make sense to me but I cannot validate them because of that.
Strange. Would restart / flushing cache make a difference? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- I restarted koha & memcached each time I switched branch (which I did a few times) so cache was not the problem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- After looking at the code, I think this patch would make a difference only if the language directories in koha-tmpl/intranet-tmpl/prog/ are different from the language directories in koha-tmpl/opac-tmpl/bootstrap/ But how could we end up in this situation as the `translate install` command always install languages in both locations ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Julian Maurice from comment #6)
After looking at the code, I think this patch would make a difference only if the language directories in koha-tmpl/intranet-tmpl/prog/ are different from the language directories in koha-tmpl/opac-tmpl/bootstrap/ But how could we end up in this situation as the `translate install` command always install languages in both locations ?
Yes thats an important observation. Look at my test description: OPAC languages: en, nl-NL, de-DE Staff languages: en, de-DE, fr-FR Note that we locally do not translate staff. So after e.g. installing nl-NL I am removing those folders on intranet-tmpl. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Marcel de Rooy from comment #7)
Yes thats an important observation. Look at my test description: OPAC languages: en, nl-NL, de-DE Staff languages: en, de-DE, fr-FR
Note that we locally do not translate staff. So after e.g. installing nl-NL I am removing those folders on intranet-tmpl. I thought those were values of systempreferences OPACLanguages and StaffInterfaceLanguages... >_<
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Julian Maurice from comment #8)
(In reply to Marcel de Rooy from comment #7)
Yes thats an important observation. Look at my test description: OPAC languages: en, nl-NL, de-DE Staff languages: en, de-DE, fr-FR
Note that we locally do not translate staff. So after e.g. installing nl-NL I am removing those folders on intranet-tmpl. I thought those were values of systempreferences OPACLanguages and StaffInterfaceLanguages... >_<
Could you QA please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Wait, i need to rebase first ;) tidy all.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176621|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178330&action=edit Bug 38903: Fix theme in some getTranslatedLanguages calls Combining opac with pref template is wrong. This pref should actually be renamed to something like intranetTheme(s) or so. Replacing the obsolete prog theme in Languages.t by undef. This achieves the same: getting all themes for that interface. Test plan: Add some languages for opac and intranet. Do not enable exactly the same set. Enable TranslateNotices. Verify that you have all OPAC languages on memberentry and opac-messaging. And all languages on additional contents. Run t/db_dependent/Languages.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested with: OPAC languages: en, nl-NL, de-DE Staff languages: en, de-DE, fr-FR -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #10)
Wait, i need to rebase first ;) tidy all..
Rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178330|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179069&action=edit Bug 38903: Fix theme in some getTranslatedLanguages calls Combining opac with pref template is wrong. This pref should actually be renamed to something like intranetTheme(s) or so. Replacing the obsolete prog theme in Languages.t by undef. This achieves the same: getting all themes for that interface. Test plan: Add some languages for opac and intranet. Do not enable exactly the same set. Enable TranslateNotices. Verify that you have all OPAC languages on memberentry and opac-messaging. And all languages on additional contents. Run t/db_dependent/Languages.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested with: OPAC languages: en, nl-NL, de-DE Staff languages: en, de-DE, fr-FR Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Took me a few minutes here to wrap my head around the translation picking code again, but I agree with the changes. No regressions and barely noticeable change in most cases.. but in the few cases it counts this is an important change. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|25.05.00 |25.05.00,24.11.10 released in| | --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #17 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38903 Bug 38903 depends on bug 38630, which changed state. Bug 38630 Summary: Make the REST API respect KohaOpacLanguage cookie https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38630 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org