[Bug 39421] New: Date picker for renewals not showing on Circulation->Renewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 Bug ID: 39421 Summary: Date picker for renewals not showing on Circulation->Renewals Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: Browse to Circulation->Checkins Note the settings icon in the barcode box Click it to see a date picker for checkin date Browse to Circulation->Renewals Note there is no icon Inspect the page and see there is a picker, but it is hidden -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 179631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179631&action=edit Bug 39421: Restore settings icon and date picker -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- I attached patch that simply adds the button and JS needed -I am not sure that this is correct, would appreciate a second set of eyes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org Depends on| |35402 --- Comment #3 from Phil Ringnalda <phil@chetcolibrary.org> --- I don't have an opinion about whether it's better to give it the toggle, or to put it back to always showing like it used to, but I did spend too much time figuring out how it broke. The "show" in class="circ-settings show" is a class we had in our BS4 bootstrap.min.css that sets display: block !important, and we no longer have it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 179897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179897&action=edit Bug 39421: Restore missing date picker on Circulation > Renew This patch restores the renewal date input field (with a date picker) for Circulation > Renew. This was missing. It changes the behavor slightly so that it mirrors Circulation > Check in. A settings icon is included in the barcode field, clicking this then shows the date field with the date picker (and any other options). Previously on the renewals page (24.05.x and earlier), there was no settings icon in the barcode field and the date input field with date picker was already shown. This user interface pattern is used elsewhere in Koha, and this chnage will help improve consistency. Test plan: 1. Browse to Circulation > Check in. 2. Note the settings icon in the barcode form field. 3. Click it to show the the return date field with a date picker, and other options. 4. Browse to Circulation > Renew. 5. Note there is no settings icon. 6. Apply the patch. 7. Repeat step 4 - note that there is now a settings icon. 8. Click the settings icon to show the renewal date form field. 9. Click the input field to show teh date picker. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #179631|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This restores the renewal release notes| |due date input field and | |date picker on the | |Circulation > Renew page - | |this was missing. It | |changes the behavor | |slightly so that it matches | |the Circulation > Check in | |page (and other areas of | |Koha) - the barcode input | |field now has a settings | |icon, clicking this now | |shows the renewal date | |input field (with the date | |picker). Summary|Date picker for renewals |Renewal date input field |not showing on |(and date picker) not |Circulation->Renewals |showing on Circulation > | |Renew --- Comment #5 from David Nind <david@davidnind.com> --- I've signed off (I amended the commit message to add the test plan, and added a description). I checked 24.11, 24.05, and 23.11 (from demo installations). The renewal date input field was missing from 24.11, but for 24.05 and 23.11 there was no settings icon in the barcode input field - the renewal date field was already shown when you loaded the page. However, I think there is some merit in mirroring the behavour used for Circulation > Check in, and elsewhere in Koha. It is a common user interface pattern used in Koha and helps improve consistency. If there are no other options shown on this page, then some staff may find it an extra click. Maybe we should add (on another bug?) a "Remember renewal date for next renewal" checkbox. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Status|Signed Off |Failed QA --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Could you please find a better wording for the title? This is not checkin :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181159&action=edit Bug 39421: (follow-up) Correct title attribute -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179897|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 181250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181250&action=edit Bug 39421: Restore missing date picker on Circulation > Renew This patch restores the renewal date input field (with a date picker) for Circulation > Renew. This was missing. It changes the behavor slightly so that it mirrors Circulation > Check in. A settings icon is included in the barcode field, clicking this then shows the date field with the date picker (and any other options). Previously on the renewals page (24.05.x and earlier), there was no settings icon in the barcode field and the date input field with date picker was already shown. This user interface pattern is used elsewhere in Koha, and this chnage will help improve consistency. Test plan: 1. Browse to Circulation > Check in. 2. Note the settings icon in the barcode form field. 3. Click it to show the the return date field with a date picker, and other options. 4. Browse to Circulation > Renew. 5. Note there is no settings icon. 6. Apply the patch. 7. Repeat step 4 - note that there is now a settings icon. 8. Click the settings icon to show the renewal date form field. 9. Click the input field to show teh date picker. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181159|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 181251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181251&action=edit Bug 39421: (follow-up) Correct title attribute Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 Irene <i.tortorella@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |i.tortorella@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 Ray Delahunty <r.delahunty@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 --- Comment #11 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184551&action=edit [24.11] Bug 39421: Restore missing date picker on Circulation > Renew This patch restores the renewal date input field (with a date picker) for Circulation > Renew. This was missing. It changes the behavor slightly so that it mirrors Circulation > Check in. A settings icon is included in the barcode field, clicking this then shows the date field with the date picker (and any other options). Previously on the renewals page (24.05.x and earlier), there was no settings icon in the barcode field and the date input field with date picker was already shown. This user interface pattern is used elsewhere in Koha, and this chnage will help improve consistency. Test plan: 1. Browse to Circulation > Check in. 2. Note the settings icon in the barcode form field. 3. Click it to show the the return date field with a date picker, and other options. 4. Browse to Circulation > Renew. 5. Note there is no settings icon. 6. Apply the patch. 7. Repeat step 4 - note that there is now a settings icon. 8. Click the settings icon to show the renewal date form field. 9. Click the input field to show teh date picker. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> PA amended: Squashed both patches for 24.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1082 Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Thanks for the 24.11 patch, fixed a tab instead of 4 spaces -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.10 released in| | Status|Pushed to main |Pushed to stable --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #14 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39421 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #15 from David Nind <david@davidnind.com> --- Documented by Caroline. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org