[Bug 18360] New: Allow deletion of cancelled order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Bug ID: 18360 Summary: Allow deletion of cancelled order lines Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Sometimes an order is just a mistake (double entry or similar) and it should be possible to delete those entries entirely from the database so they won't show up in any reports. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Sebastian Hierl <s.hierl@aarome.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |s.hierl@aarome.org --- Comment #1 from Sebastian Hierl <s.hierl@aarome.org> --- Our Acquisitions Assistant confirms that this would be a welcome improvement / bugfix. Let us know if we can help with sign-off. -Sebastian -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Karen <karen@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karen@bywatersolutions.com --- Comment #2 from Karen <karen@bywatersolutions.com> --- One of our partners just told me that she would love to have the ability to delete an order entry. She says,"What KOHA needs is a delete order line feature. That is quite different from cancelling an order. I guess because we are small in comparison to many libraries, keeping records of cancelled orders is not important to us and gets in the way actually." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 14091 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Version|3.22 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36066 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- See bug 36066 too. We only allow API to delete cancelled lines there. This bug is for the interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10869 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 162294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162294&action=edit Bug 18360: Allow to delete a cancelled order from open basket Doing this under flag of order_manage and not on the higher level of baskets. Starting here with a single order delete for cancelled lines. So deleting an open order line requires cancelling it first. Can be extended later if needed. Test plan: Pick an open basket with cancelled lines. Try to delete a few lines. Test that you cannot do this on an closed basket. (Bonus: manipulate URL with basketno, ordernumber and op=cud-delete-order.) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #0)
Sometimes an order is just a mistake (double entry or similar) and it should be possible to delete those entries entirely from the database so they won't show up in any reports.
The current proposal does build on this use case and just starts with only allowing deletion of cancelled order lines without a biblio record. Can be extended later on a follow-up if needed. First try to get this moving. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33664 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 --- Comment #7 from Michaela Sieber <michaela.sieber@kit.edu> --- Hi Marcel, thanks for the patch. I tested it in Sandbox http://staff-b18360.sandboxes.ptfs-europe.co.uk/ I'm not sure if I missed something but the Link to delete the cancelled lines only appears if the basket is open. was that the intention? With Bug 33664 the ability to cancel order lines in closed baskets was added. I think it would make sense to be able to delete the line even if the basket is closed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Michaela Sieber from comment #7)
Hi Marcel, thanks for the patch. I tested it in Sandbox http://staff-b18360.sandboxes.ptfs-europe.co.uk/
I'm not sure if I missed something but the Link to delete the cancelled lines only appears if the basket is open.
was that the intention?
With Bug 33664 the ability to cancel order lines in closed baskets was added. I think it would make sense to be able to delete the line even if the basket is closed.
Hi Michaela, Yes that was the intention. Normally we can only edit a basket and its lines when we reopen. Was not aware of 33664. Making things inconsistent imo.. Prefer to keep this as is now here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162294|0 |1 is obsolete| | --- Comment #9 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 162484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162484&action=edit Bug 18360: Allow to delete a cancelled order from open basket Doing this under flag of order_manage and not on the higher level of baskets. Starting here with a single order delete for cancelled lines. So deleting an open order line requires cancelling it first. Can be extended later if needed. Test plan: Pick an open basket with cancelled lines. Try to delete a few lines. Test that you cannot do this on an closed basket. (Bonus: manipulate URL with basketno, ordernumber and op=cud-delete-order.) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to PTFS Europe Sandboxes from comment #9)
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Thanks Michaela -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162484|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 165273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165273&action=edit Bug 18360: Allow to delete a cancelled order from open basket Doing this under flag of order_manage and not on the higher level of baskets. Starting here with a single order delete for cancelled lines. So deleting an open order line requires cancelling it first. Can be extended later if needed. Test plan: Pick an open basket with cancelled lines. Try to delete a few lines. Test that you cannot do this on an closed basket. (Bonus: manipulate URL with basketno, ordernumber and op=cud-delete-order.) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Tiny rebase (CSRF) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165273|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165525&action=edit Bug 18360: Allow to delete a cancelled order from open basket Doing this under flag of order_manage and not on the higher level of baskets. Starting here with a single order delete for cancelled lines. So deleting an open order line requires cancelling it first. Can be extended later if needed. Test plan: Pick an open basket with cancelled lines. Try to delete a few lines. Test that you cannot do this on an closed basket. (Bonus: manipulate URL with basketno, ordernumber and op=cud-delete-order.) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Clear simple code, QA scripts happy and all working. Whilst it regresses bug 33664 I think that's OK here and brings more consistency. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #14)
Whilst it regresses bug 33664 I think that's OK here and brings more consistency.
Could you explain? The other bug is about cancelling. This one about delete?
Passing QA
Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #15)
(In reply to Martin Renvoize from comment #14)
Whilst it regresses bug 33664 I think that's OK here and brings more consistency.
Could you explain? The other bug is about cancelling. This one about delete?
Passing QA
Thanks
From Mattermost: ashimema: About having to re-open the basket you already noted it with Micheala and she signed off so I felt it was OK
marcelr Ah ok not really a regression. But perhaps inconsistent? Though I like the idea of reopening before deleting personally. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we might want to discuss the open/closed basket again, but this is progress and I love it :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Taking a closer look - maybe also to be handled on a separate bug: Why is it necessary to delete the record first? I could imagine libraries still having the record with older items or other linked orders. + alert( _("Please delete the linked bibliographic record first.") ); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, this needs a follow-up for CSRF: Programming error - No CSRF token passed for POST http://localhost:8081/intranet/acqui/basket.pl?basketno=1 (referer: http://localhost:8081/cgi-bin/koha/acqui/basket.pl?basketno=1) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #18)
Taking a closer look - maybe also to be handled on a separate bug:
Why is it necessary to delete the record first? I could imagine libraries still having the record with older items or other linked orders.
+ alert( _("Please delete the linked bibliographic record first.") );
Probably had in mind to prevent 'ghost records' in the catalog. Created by Acquisition and now having no links anymore. Could imagine that there will be different opinions here. Maybe still move that to a new report? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #20)
(In reply to Katrin Fischer from comment #18)
Taking a closer look - maybe also to be handled on a separate bug:
Why is it necessary to delete the record first? I could imagine libraries still having the record with older items or other linked orders.
+ alert( _("Please delete the linked bibliographic record first.") );
Probably had in mind to prevent 'ghost records' in the catalog. Created by Acquisition and now having no links anymore. Could imagine that there will be different opinions here. Maybe still move that to a new report?
Yes, it was not meant as a blocker here. Just wondering about reasoning. I'll add additional_work_needed as a reminder for this loose end. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 165869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165869&action=edit Bug 18360: (follow-up) Fix for CSRF Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #21)
(In reply to Marcel de Rooy from comment #20)
(In reply to Katrin Fischer from comment #18)
Taking a closer look - maybe also to be handled on a separate bug:
Why is it necessary to delete the record first? I could imagine libraries still having the record with older items or other linked orders.
+ alert( _("Please delete the linked bibliographic record first.") );
Probably had in mind to prevent 'ghost records' in the catalog. Created by Acquisition and now having no links anymore. Could imagine that there will be different opinions here. Maybe still move that to a new report?
Yes, it was not meant as a blocker here. Just wondering about reasoning. I'll add additional_work_needed as a reminder for this loose end.
Bug 36731 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36731 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36731 [Bug 36731] Delete cancelled order line that still refers to bibliographic record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch set allows you release notes| |to delete cancelled order | |lines from an open | |acquisition basket. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #25 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org