[Bug 14634] New: Warns when placing hold on record with no items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14634 Bug ID: 14634 Summary: Warns when placing hold on record with no items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Use of uninitialized value $canReserve in string eq at /home/vagrant/kohaclone/reserve/request.pl line 204 Use of uninitialized value $canReserve in string eq at /home/vagrant/kohaclone/reserve/request.pl line 208 Use of uninitialized value $canReserve in string eq at /home/vagrant/kohaclone/reserve/request.pl line 211 Use of uninitialized value $canReserve in hash element at /home/vagrant/kohaclone/reserve/request.pl line 216 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14634 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14634 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 41308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41308&action=edit Bug 14634: Warns when placing hold on record with no items To test: 1) Create a new record in Cataloguing 2) When done, instead of adding an item to the record, click on the Holds tab in the left nav 3) Notice warns 4) Apply patch and refresh page 5) Click on Holds tab again 6) Notice warns are gone and page still works -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14634 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleishaamohia@hotmail.com |ity.org | CC| |jonathan.druart@bugs.koha-c | |ommunity.org Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14634 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14634 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41308|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 41912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41912&action=edit Bug 14634: Warns when placing hold on record with no items To test: 1) Create a new record in Cataloguing 2) When done, instead of adding an item to the record, click on the Holds tab in the left nav 3) Notice warns 4) Apply patch and refresh page 5) Click on Holds tab again 6) Notice warns are gone and page still works Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Warns disappear; note that the display of the error message is still ugly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14634 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14634 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41912|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41990&action=edit Bug 14634: Warns when placing hold on record with no items To test: 1) Create a new record in Cataloguing 2) When done, instead of adding an item to the record, click on the Holds tab in the left nav 3) Notice warns 4) Apply patch and refresh page 5) Click on Holds tab again 6) Notice warns are gone and page still works Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Warns disappear; note that the display of the error message is still ugly. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14634 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14634 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #5 from Liz Rea <liz@catalyst.net.nz> --- Patch pushed to 3.18.x, will be in 3.18.11 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14634 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.4 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org