[Bug 14579] New: 'You are not logged in' should link to log in page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 Bug ID: 14579 Summary: 'You are not logged in' should link to log in page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When you are not logged in and go to any page (for example an error page, cgi-bin/koha/errors/400.pl), it says 'You are not logged in |' in the top right in the style of a link, but does not redirect anywhere when you click it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 41106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41106&action=edit Bug 14579: 'You are not logged in' should link to log in page To test: 1) Go to any page on the staff client and make sure you are not logged in (ie an error page, cgi-bin/koha/errors/400.pl) 2) Try click on 'You are not logged in |' 3) Notice it is not really a link and doesn't take you anywhere 4) Apply patch 5) Refresh page 6) Click on what now says 'Log in |' 7) Confirm that you are redirected to the intranet log in page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 cnorthcott.work@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnorthcott.work@gmail.com Status|Needs Signoff |Signed Off --- Comment #2 from cnorthcott.work@gmail.com --- Patch applies, link now works but alignment of Log In text and Help text are mismatched. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to cnorthcott.work from comment #2)
Patch applies, link now works but alignment of Log In text and Help text are mismatched.
Aleisha, could you try to fix the alignment? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|koha-bugs@lists.koha-commun |aleishaamohia@hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41106|0 |1 is obsolete| | --- Comment #4 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 41658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41658&action=edit Bug 14579: 'You are not logged in' should link to log in page I fixed the aligment of the two links but the padding still needs to be set right. I also fixed mismatching html tags. To test: 1) Go to any page on the staff client and make sure you are not logged in (ie an error page, cgi-bin/koha/errors/400.pl) 2) Try click on 'You are not logged in |' 3) Notice it is not really a link and doesn't take you anywhere 4) Apply patch 5) Refresh page 6) Click on what now says 'Log in |' 7) Confirm that you are redirected to the intranet log in page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41658|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 42004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42004&action=edit Bug 14579: 'You are not logged in' should link to log in page To test: 1) Go to any page on the staff client and make sure you are not logged in (ie an error page, cgi-bin/koha/errors/400.pl) 2) Try click on 'You are not logged in |' 3) Notice it is not really a link and doesn't take you anywhere 4) Apply patch 5) Refresh page 6) Click on what now says 'Log in |' 7) Confirm that you are redirected to the intranet log in page Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42004|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42008&action=edit Bug 14579: 'You are not logged in' should link to log in page To test: 1) Go to any page on the staff client and make sure you are not logged in (ie an error page, cgi-bin/koha/errors/400.pl) 2) Try click on 'You are not logged in |' 3) Notice it is not really a link and doesn't take you anywhere 4) Apply patch 5) Refresh page 6) Click on what now says 'Log in |' 7) Confirm that you are redirected to the intranet log in page Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Joonas, and congratulations for your first commit in Koha! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #8 from Liz Rea <liz@catalyst.net.nz> --- This patch moved the help menu from the top right, next to the login menu to inside the dropdown. I don't think we want to hide it like that. Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Liz, it's the same place as when you are logged in. What do you suggest? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 --- Comment #10 from Liz Rea <liz@catalyst.net.nz> --- I'll make a different bug :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14773 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.4 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org