[Bug 7135] New: save button options
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7135 Bug #: 7135 Summary: save button options Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org CC: ian.walls@bywatersolutions.com would be nice if the save button in cataloging was at the top and the bottom - or better yet is always on the screen - floating as you scroll. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7135 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gmcharlt@gmail.com |oleonard@myacpl.org --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-11-03 18:59:29 UTC --- Created attachment 6167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6167 Proposed fix This patch adds a jQuery plugin which will cause an element to remain "fixed" at the top of the screen if it would otherwise scroll up out of view. I submit this patch for TESTING ONLY because the plugin was not posted with explicit licensing. I'm waiting to hear back from the author. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7135 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7135 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-11-03 19:07:21 UTC --- How it should look: http://screencast.com/t/0gBcTT6OKQ Tested successfully so far in: FF7 / Win7 Chrome 15 / Win7 IE8 / Win7 Opera 11 / Win7 Safari 5 / Win7 Chrome 14 / Ubuntu 11.10 Firefox 7 / Ubuntu 11.10 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7135 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> 2011-11-18 18:29:03 UTC --- Not exactly a license, but the author responds "This plugin is as free as fresh air. Feel free to use it anywhere." -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7135 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-03 00:54:02 UTC --- I think that is pretty close to the WTFPL http://en.wikipedia.org/wiki/WTFPL :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7135 --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-06 22:55:53 UTC --- Signing off, works in 11.10 Chromium 17 as well -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7135 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6167|0 |1 is obsolete| | --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-06 22:56:47 UTC --- Created attachment 6626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6626 Bug 7135: Save button options This patch adds a jQuery plugin which will cause an element to remain "fixed" at the top of the screen if it would otherwise scroll up out of view. I submit this patch for TESTING ONLY because the plugin was not posted with explicit licensing. I'm waiting to hear back from the author. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7135 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7135 --- Comment #7 from Liz Rea <wizzyrea@gmail.com> 2011-12-06 23:00:37 UTC --- Created attachment 6627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6627 [Signed Off] Fix for Bug 7135: Save button options This patch adds a jQuery plugin which will cause an element to remain "fixed" at the top of the screen if it would otherwise scroll up out of view. I submit this patch for TESTING ONLY because the plugin was not posted with explicit licensing. I'm waiting to hear back from the author. Signed-off-by: Liz Rea <wizzyrea@gmail.com> I tested this on Chrome OSX saving works changing framework works scrolling works, obviously. tabbing through the records works z39 button works as expected -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7135 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #8 from Liz Rea <wizzyrea@gmail.com> 2011-12-06 23:02:28 UTC --- And Firefox 8.0.1 (In reply to comment #7)
Created attachment 6627 [details] [Signed Off] Fix for Bug 7135: Save button options
This patch adds a jQuery plugin which will cause an element to remain "fixed" at the top of the screen if it would otherwise scroll up out of view.
I submit this patch for TESTING ONLY because the plugin was not posted with explicit licensing. I'm waiting to hear back from the author.
Signed-off-by: Liz Rea <wizzyrea@gmail.com> I tested this on Chrome OSX saving works changing framework works scrolling works, obviously. tabbing through the records works z39 button works as expected
-- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7135 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6626|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7135 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |rel_3_6 Patch Status|Signed Off |Patch Pushed --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-13 17:03:07 UTC --- QA comment: * tested, works fine * license question solved, i've updated the patch comment to reflect that passed QA patch pushed, please test chris_n = maybe worth for 3.6, but beware it changes addbiblio behaviour, that can surprise users ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7135 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|save button options |in addbiblio, make save | |button floating to have it | |on always on screen -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7135 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Patch Pushed |Failed QA --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-13 17:09:26 UTC --- oups... failed QA detected just before pushing the patch !!! * addbiblio * open the "More" menu => the menus are BELOW the save button, making Reports & Serial unreachable ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7135 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> 2011-12-13 19:41:12 UTC --- Created attachment 6760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6760 Follow-up fix Follow-up fix corrects z-index of toolbar so that "More" menu is not hidden behind it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7135 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7135 Duncan <duncan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6627|0 |1 is obsolete| | Attachment #6760|0 |1 is obsolete| | --- Comment #12 from Duncan <duncan@catalyst.net.nz> 2011-12-13 20:58:16 UTC --- Created attachment 6761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6761 Signed off follow up fix for patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7135 Duncan <duncan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |duncan@catalyst.net.nz Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7135 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-14 14:54:23 UTC --- follow-up patch pushed, thanks for the quick fix ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7135 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2710 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7135 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This fix was included in the 3.6.x branch prior to 3.6.4. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org