[Bug 6842] New: Branch transfer limits broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 Bug #: 6842 Summary: Branch transfer limits broken Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All URL: /admin/branch_transfer_limits.pl?branchcode=FPL OS/Version: All Status: NEW Severity: major Priority: P5 Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha-bugs@lists.koha-community.org 1) Select of library broken When selecting a library and clicking 'choose' the page reloads but the pull down jumps back to the first branch in the list 2) Can't save changes If you change the checkboxed for the selected library and click 'save' nothing happens. Page does not reload, there is no message displayed and changes are not saved. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-09-15 14:25:16 UTC --- Created attachment 5438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5438 Proposed fix - Changing library select form so that chosen library is preselected To test, use the form to switch libraries. The library you switch to should now be pre-selected in the <select> form. - Changing pager <form> to a <p> so that nested form tags don't conflict. It was the addition of the javascript table pager which broke the functionality on this page. To test, make changes to the selections under a collection code's policy. Submitting the form should work, and the selections you make should be reflected when the page reloads. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5438|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-20 06:34:41 UTC --- Created attachment 5471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5471 [SIGNED-OFF] Fix for Bug 6842 - Branch transfer limits broken - Changing library select form so that chosen library is preselected - Changing pager <form> to a <p> so that nested form tags don't conflict. It was the addition of the javascript table pager which broke the functionality on this page. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> - It's possible to select a different library now. The pull down shows the chosen library correctly. - I can make changes and save them without any problems. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Passed QA --- Comment #3 from Ian Walls <ian.walls@bywatersolutions.com> 2011-09-20 11:52:05 UTC --- Mainly a template change, with one additional param in the Perl. Easy to read, correct HTML nesting, marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-20 21:41:20 UTC --- Pushed please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P1 - high Status|ASSIGNED |NEW Patch Status|Patch Pushed |--- --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-18 20:07:29 UTC --- I tested this on current master and can't save changes to branch transfer limists. Clicking on 'save' gives no reaction. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 laurenthdl <henridamien.laurent@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5471|0 |1 is obsolete| | --- Comment #6 from laurenthdl <henridamien.laurent@biblibre.com> 2011-12-22 13:44:48 UTC --- Created attachment 6923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6923 patch proposed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 --- Comment #7 from laurenthdl <henridamien.laurent@biblibre.com> 2011-12-22 16:15:33 UTC --- Created attachment 6925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6925 followup patch : assigns a problem of deleted information when editing an other branch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P1 - high |PATCH-Sent Status|NEW |ASSIGNED CC| |francois.charbonnier@biblib | |re.com, | |paul.poulain@biblibre.com Patch Status|--- |Needs Signoff AssignedTo|oleonard@myacpl.org |paul.poulain@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6836 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> 2011-12-28 16:47:36 UTC --- Created attachment 6944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6944 Alternate fix which doesn't require Datatables plugin The patch which moved the table pager markup into an include undid the fix which was previously pushed for this problem. Re-implementing the fix in the pager include is a simpler fix which doesn't depend on the Datatables plugin. The markup change in table-pager.inc fixes the problem in branch transfer limits and does not affect functionality on other pages. The changes in this patch to branch_transfer_limits.tt and staff-global.css are for cosmetic reasons only. Note that I don't submit this patch because I disapprove of the use of Datatables but because I think a simpler fix is more expedient in this case. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6944|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-29 20:43:26 UTC --- Created attachment 6960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6960 [SIGNED-OFF] Bug 6842 Alternate fix, Branch transfer limits broken The patch which moved the table pager markup into an include undid the fix which was previously pushed for this problem. Re-implementing the fix in the pager include is a simpler fix which doesn't depend on the Datatables plugin. The markup change in table-pager.inc fixes the problem in branch transfer limits and does not affect functionality on other pages. The changes in this patch to branch_transfer_limits.tt and staff-global.css are for cosmetic reasons only. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Saving changes works now correctly. I tried: - uncheck all for a branch - check all for a branch - making changes for different itemtypes on different tabs -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-29 20:50:59 UTC --- I had no problems deleting branch transfer rules, so I am not sure how to test the second patch attached to this bug. Moving this to signed off for now. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P2 Status|Signed Off |Needs Signoff --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-01 21:50:32 UTC --- Katrin: about the 2nd patch, here is the test case: * select a branch * unselect some checkboxes to prevent transfer * save * change your branch * unselect some checkboxes and save * go back to the 1st branch => everything is checked again ! This is because the SQL delete everything and not only the branch rules you're saving ! I've tested the patch, please test it too, so I can QA & push both patches I'll obsolet the 1st patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6923|0 |1 is obsolete| | --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-01 21:50:51 UTC --- Comment on attachment 6923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6923 patch proposed. obsoleted by owen patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6925|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> 2012-02-07 15:31:36 UTC --- Created attachment 7477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7477 [SIGNED-OFF] followup patch : assigns a problem of deleted information when editing an other branch I see now why the follow-up patch is required. If you make a change to a one branch the correct changes are saved. If you make a change to another branch after that the changes to the first branch are lost. The patch fixes that problem. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 --- Comment #14 from Ian Walls <koha.sekjal@gmail.com> 2012-02-07 16:11:33 UTC --- Initial patch: template only change, replacing <form> with <p>, and updating the necessary CSS. Unfortunately, it does not apply to current master. Rebased patch forthcoming. Followup patch: alters the subroutine DeleteBranchTransferLimits() to take a branchcode param. Subsequently alters ALL usages of this subroutine in Koha (only one) to make use of this new param. Marking Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 --- Comment #15 from Ian Walls <koha.sekjal@gmail.com> 2012-02-07 16:13:54 UTC --- Created attachment 7484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7484 Bug 6842 Alternate fix, Branch transfer limits broken The patch which moved the table pager markup into an include undid the fix which was previously pushed for this problem. Re-implementing the fix in the pager include is a simpler fix which doesn't depend on the Datatables plugin. The markup change in table-pager.inc fixes the problem in branch transfer limits and does not affect functionality on other pages. The changes in this patch to branch_transfer_limits.tt and staff-global.css are for cosmetic reasons only. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Saving changes works now correctly. I tried: - uncheck all for a branch - check all for a branch - making changes for different itemtypes on different tabs -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6960|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from Ian Walls <koha.sekjal@gmail.com> 2012-02-07 16:15:16 UTC --- CSS conflict from local cover images development. Rebased now, marking both patches here as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_6 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 Bug 6842 depends on bug 6836, which changed state. Bug 6836 Summary: jQuery plugin Datatables integration http://wiki.koha-community.org/wiki/DataTables_HowTo http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 What |Old Value |New Value ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6842 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #17 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This fix was included in the 3.6.x branch prior to 3.6.4. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org